Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Sean Coffey
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Lance Andersen
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Iris Clark
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Justin Lu
On Wed, 18 Sep 2024 06:53:27 GMT, Alan Bateman wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reflect review comments > > src/java.base/share/classes/java/nio/charset/spi/CharsetProvider.java line 39: > >> 37: * im

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Justin Lu
On Wed, 18 Sep 2024 06:52:17 GMT, Alan Bateman wrote: >> `repaint()` could be substituted with another arbitrary method name to >> highlight some work this thread has to perform. >> >> given the thread name `blink`, perhaps we could just use `blink()` in this >> example. > > Don't waste too mu

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Justin Lu
> Please review this PR which removes occurrences of 'applet' within the > corelibs specification. Applet has been deprecated since JDK9, and may be a > confusing term for new Java developers, so it should be removed from the > documentation. > > Primarily, usages where 'applet' is used interch

Re: RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java [v3]

2024-09-18 Thread serhiysachkov
> 8339787: Add some additional diagnostic output to > java/net/ipv6tests/UdpTest.java serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: 8339787: updating copyright - Changes: - all: https://git.openjdk.org/jdk/pull/210

Re: RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java [v2]

2024-09-18 Thread Daniel Fuchs
On Wed, 18 Sep 2024 15:57:20 GMT, serhiysachkov wrote: >> 8339787: Add some additional diagnostic output to >> java/net/ipv6tests/UdpTest.java > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8339787: align output to use s

Re: RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java

2024-09-18 Thread Daniel Fuchs
On Wed, 18 Sep 2024 15:24:14 GMT, serhiysachkov wrote: > 8339787: Add some additional diagnostic output to > java/net/ipv6tests/UdpTest.java test/jdk/java/net/ipv6tests/Tests.java line 127: > 125: dprintln ("dest2 = " + dest2); > 126: dprintln ("sender endpoint == " + s1.getLoc

Re: RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java [v2]

2024-09-18 Thread serhiysachkov
> 8339787: Add some additional diagnostic output to > java/net/ipv6tests/UdpTest.java serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: 8339787: align output to use single = - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java [v2]

2024-09-18 Thread serhiysachkov
On Wed, 18 Sep 2024 15:49:50 GMT, Daniel Fuchs wrote: >> serhiysachkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8339787: align output to use single = > > test/jdk/java/net/ipv6tests/Tests.java line 127: > >> 125: dprintln

RFR: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java

2024-09-18 Thread serhiysachkov
8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java - Commit messages: - 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java Changes: https://git.openjdk.org/jdk/pull/21055/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21055&range=00

Re: RFR: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java

2024-09-18 Thread Daniel Fuchs
On Wed, 18 Sep 2024 10:31:59 GMT, serhiysachkov wrote: > 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java Trivial and looks reasonable. - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21055#pullrequestreview-2313055780

RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java

2024-09-18 Thread serhiysachkov
8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java - Commit messages: - 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java Changes: https://git.openjdk.org/jdk/pull/21066/files Webrev: https://webrevs.openjdk.org/?rep

Re: RFR: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java

2024-09-18 Thread duke
On Wed, 18 Sep 2024 10:31:59 GMT, serhiysachkov wrote: > 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java @serhiysachkov Your change (at version 453749c9b01477139001679a0c5cef35752199cb) is now ready to be sponsored by a Committer. - PR Comment: https://git.o

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-18 Thread Sean Mullan
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote: > Please review this PR which removes occurrences of 'applet' within the > corelibs specification. Applet has been deprecated since JDK9, and may be a > confusing term for new Java developers, so it should be removed from the > documentation.

Re: RFR: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java [v3]

2024-09-18 Thread Daniel Fuchs
On Wed, 18 Sep 2024 16:05:40 GMT, serhiysachkov wrote: >> 8339787: Add some additional diagnostic output to >> java/net/ipv6tests/UdpTest.java > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8339787: updating copyright M

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Naoto Sato
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Roger Riggs
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati