On Thu, 12 Sep 2024 06:24:50 GMT, Daniel Jeliński wrote:
> Thanks for making the changes. LGTM, assuming that tests still pass.
The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In any
case, I will run another round of tests before integrating.
> src/java.base/unix/native/
On Thu, 12 Sep 2024 02:05:50 GMT, Brian Burkhalter wrote:
>> We don't need it in `libjava`, but `NTLMAuthentication` was (perhaps
>> unwittingly) relying on it to load `net.dll` during boot phase 2. I'll move
>> the load to a more appropriate location in the next commit.
>
> Moved to `NTLMAuthe
On Thu, 12 Sep 2024 15:38:18 GMT, Brian Burkhalter wrote:
> The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In any
> case, I will run another round of tests before integrating.
Can you hold off integrating, I plan to go over the changes soon.
-
PR Comment: h
On Thu, 12 Sep 2024 15:43:32 GMT, Alan Bateman wrote:
> Can you hold off integrating, I plan to go over the changes soon.
I don't plan to integrate until you have reviewed it. I set the minimum
reviewer count to 3 to avoid doing so accidentally.
-
PR Comment: https://git.openjdk.o
This PR suggests introducing an internal class in `java.base` to simplify the
use of some `MethodHandles.Lookup` operations.
While the utility of the methods might appear to be limited in classes with
many static `VarHandle`/`MethodHandle` variables, it should be noted that the
class files beco
On Thu, 12 Sep 2024 17:38:44 GMT, Per Minborg wrote:
> This PR suggests introducing an internal class in `java.base` to simplify the
> use of some `MethodHandles.Lookup` operations.
>
> While the utility of the methods might appear to be limited in classes with
> many static `VarHandle`/`Metho
On Thu, 12 Sep 2024 17:38:44 GMT, Per Minborg wrote:
> This PR suggests introducing an internal class in `java.base` to simplify the
> use of some `MethodHandles.Lookup` operations.
>
> While the utility of the methods might appear to be limited in classes with
> many static `VarHandle`/`Metho
