Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v11]

2024-09-09 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Feedback from CSR review - C

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v10]

2024-09-09 Thread Daniel Fuchs
On Fri, 6 Sep 2024 12:01:21 GMT, Alan Bateman wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/classes/java/net/NetworkInterface.java > > Marked as reviewed by alanb (Reviewer). I pushed

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v11]

2024-09-09 Thread Mark Sheppard
On Mon, 9 Sep 2024 10:01:40 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v12]

2024-09-09 Thread Daniel Fuchs
> Please find here a change that adds a few `@apiNote` and `@implNote` to > `NetworkInterface` to clarify user expectation and implementation. Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: More review feedback - Chang

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v11]

2024-09-09 Thread Daniel Fuchs
On Mon, 9 Sep 2024 10:37:44 GMT, Mark Sheppard wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Feedback from CSR review > > src/java.base/share/classes/java/net/NetworkInterface.java line 64: > >> 62: * Network i

Re: RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v12]

2024-09-09 Thread Alan Bateman
On Mon, 9 Sep 2024 13:40:43 GMT, Daniel Fuchs wrote: >> Please find here a change that adds a few `@apiNote` and `@implNote` to >> `NetworkInterface` to clarify user expectation and implementation. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

2024-09-09 Thread Brian Burkhalter
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request inc