Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v3]

2024-08-28 Thread Michael McMahon
On Tue, 27 Aug 2024 08:38:23 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8338445? >> >> The JDK internal class `jdk.internal.loader.URLClassPath` is used by >> classloader implementations i

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v3]

2024-08-28 Thread Christian Stein
On Tue, 27 Aug 2024 08:38:23 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8338445? >> >> The JDK internal class `jdk.internal.loader.URLClassPath` is used by >> classloader implementations i

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v3]

2024-08-28 Thread Jaikiran Pai
On Tue, 27 Aug 2024 08:38:23 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8338445? >> >> The JDK internal class `jdk.internal.loader.URLClassPath` is used by >> classloader implementations i

Integrated: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest

2024-08-28 Thread Jaikiran Pai
On Fri, 23 Aug 2024 10:45:49 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8338445? > > The JDK internal class `jdk.internal.loader.URLClassPath` is used by > classloader implementations in the

RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes

2024-08-28 Thread Daniel Fuchs
The `java/net/httpclient/HttpsTunnelAuthTest.java` has been observed failing intermittently with `java.io.IOException: HTTP/1.1 header parser received no bytes`, ... `Caused by: java.net.SocketException: Connection reset `. My suspicion is that the ProxyServer used by this test is the cause of t

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v2]

2024-08-28 Thread Jaikiran Pai
On Thu, 22 Aug 2024 13:43:28 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v2]

2024-08-28 Thread Jaikiran Pai
On Thu, 22 Aug 2024 13:43:28 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v2]

2024-08-28 Thread Daniel Fuchs
On Wed, 28 Aug 2024 16:12:58 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Better exception message for ShutdownNow > > src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v3]

2024-08-28 Thread Daniel Fuchs
> The java/net/httpclient/DigestEchoClient.java fails intemittently with > IOException: HTTP/1.1 header parser received no bytes. > > Analysis shows that this is caused by the CleanupTrigger which receives data > after the reused connection has been taken out of the HTTP/1.1 clear pool. > This

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v2]

2024-08-28 Thread Daniel Fuchs
On Thu, 22 Aug 2024 13:43:28 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v4]

2024-08-28 Thread Daniel Fuchs
> The java/net/httpclient/DigestEchoClient.java fails intemittently with > IOException: HTTP/1.1 header parser received no bytes. > > Analysis shows that this is caused by the CleanupTrigger which receives data > after the reused connection has been taken out of the HTTP/1.1 clear pool. > This

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v4]

2024-08-28 Thread Daniel Fuchs
On Wed, 28 Aug 2024 17:06:34 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v4]

2024-08-28 Thread Jaikiran Pai
On Wed, 28 Aug 2024 17:06:34 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne

Re: RFR: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started [v4]

2024-08-28 Thread Daniel Fuchs
On Wed, 28 Aug 2024 17:06:34 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne