On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
This PR modifies links in the `InetAddress` class-level javadoc showed as
`"#format"`.
In addition, it changes one grammatical error in the adjacent paragraph.
-
Commit messages:
- 8329398: Links in InetAddress class description show "#format"
Changes: https://git.openjdk.org/jdk/p
Can I get a review for this change that fixes some broken links in javadoc
comments? The new docs are hosted
[here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
It's mostly fixing some relative links.
If using `{@docroot}` isn't ideal I can change it.
Here is the res
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
On Fri, 19 Jul 2024 11:49:54 GMT, Aleksei Efimov wrote:
> This PR modifies links in the `InetAddress` class-level javadoc showed as
> `"#format"`.
> In addition, it changes one grammatical error in the adjacent paragraph.
Looks good to me.
-
Marked as reviewed by jpai (Reviewer).
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 12:44:47 GMT, Daniel Jeliński wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove docroot based on review
>
> src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java
> lin
On Fri, 19 Jul 2024 13:08:06 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 13:08:06 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 14:05:07 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 14:20:48 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 14:20:48 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 13:11:05 GMT, Chen Liang wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove docroot based on review
>
> src/java.base/share/classes/java/lang/foreign/Arena.java line 64:
>
>> 62: * such,
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
18 matches
Mail list logo
