Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread Michael McMahon
On Sat, 15 Jun 2024 03:22:47 GMT, Ethan McCue wrote: > To reiterate, I'm still not the biggest fan of the constant names given > > * The parameter name they are being used for is `responseLength`. "The > responseLength is CHUNKED_CONTENT" feels jank and `lengthOrChunked` doesn't > inspire

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread Michael McMahon
On Sat, 15 Jun 2024 03:22:47 GMT, Ethan McCue wrote: > To reiterate, I'm still not the biggest fan of the constant names given > > * The parameter name they are being used for is `responseLength`. "The > responseLength is CHUNKED_CONTENT" feels jank and `lengthOrChunked` doesn't > inspire

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread Ethan McCue
On Sat, 15 Jun 2024 03:33:23 GMT, robert engels wrote: >> robert engels has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'robaho/HttpExchange-api-change' into >> HttpExchange-api-change >> >># Confl

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread Ethan McCue
On Thu, 20 Jun 2024 09:27:55 GMT, Michael McMahon wrote: > That would force the developer to read further @Michael-Mc-Mahon I don't think any force in this life or the next will force a developer to read. - PR Comment: https://git.openjdk.org/jdk/pull/18955#issuecomment-2180930937

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread robert engels
On Sat, 15 Jun 2024 03:33:23 GMT, robert engels wrote: >> robert engels has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'robaho/HttpExchange-api-change' into >> HttpExchange-api-change >> >># Confl

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread Ethan McCue
On Wed, 1 May 2024 21:12:05 GMT, robert engels wrote: >> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge remot

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread Ethan McCue
On Wed, 1 May 2024 21:12:05 GMT, robert engels wrote: >> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge remot

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]

2024-06-20 Thread robert engels
On Wed, 1 May 2024 21:12:05 GMT, robert engels wrote: >> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge remot