Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Alan Bateman
On Mon, 20 May 2024 18:47:35 GMT, Phil Race wrote: > Have you looked into / thought about how this will work for jpackaged apps ? > I suspect that both the existing FFM usage and this will be options the > application packager will need to supply when building the jpackaged app - > the end use

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Maurizio Cimadamore
On Tue, 21 May 2024 07:20:05 GMT, Alan Bateman wrote: > > Have you looked into / thought about how this will work for jpackaged apps > > ? I suspect that both the existing FFM usage and this will be options the > > application packager will need to supply when building the jpackaged app - > >

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Alexey Semenyuk
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Phil Race
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-21 Thread Alexey Semenyuk
On Tue, 21 May 2024 08:44:47 GMT, Maurizio Cimadamore wrote: > These are all good suggestions. I have not looked into jpackage, but yes, I > would expect that the jpackage user would need to provide extra options when > packaging the application. It would be good to document how jpackage user

RFR: 8325766: Review seclibs tests for cert expiry

2024-05-21 Thread Matthew Donovan
For this PR, I identified TLS tests that can fail due to hard-code certificates expiring. I updated those tests to use certificates that are generated programmatically. This includes adding some helper methods to the CertificateBuilder class to create builder objects with common default values.

Re: RFR: 8325766: Review seclibs tests for cert expiry

2024-05-21 Thread Sean Mullan
On Thu, 25 Apr 2024 17:20:11 GMT, Matthew Donovan wrote: > For this PR, I identified TLS tests that can fail due to hard-code > certificates expiring. I updated those tests to use certificates that are > generated programmatically. This includes adding some helper methods to the > CertificateB

Re: RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v4]

2024-05-21 Thread Jaikiran Pai
On Fri, 17 May 2024 11:33:14 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which clarifies the value >> type for the `java.net.SocketOptions.SO_LINGER` option? > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last

Integrated: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER

2024-05-21 Thread Jaikiran Pai
On Wed, 15 May 2024 05:06:02 GMT, Jaikiran Pai wrote: > Can I please get a review of this doc-only change which clarifies the value > type for the `java.net.SocketOptions.SO_LINGER` option? This pull request has now been integrated. Changeset: 5f804b2e Author:Jaikiran Pai URL: http