Re: RFR: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket [v3]

2024-05-20 Thread Alan Bateman
On Mon, 20 May 2024 06:02:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have b

Re: RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v4]

2024-05-20 Thread Alan Bateman
On Fri, 17 May 2024 11:33:14 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which clarifies the value >> type for the `java.net.SocketOptions.SO_LINGER` option? > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v4]

2024-05-20 Thread Jaikiran Pai
On Fri, 17 May 2024 11:33:14 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which clarifies the value >> type for the `java.net.SocketOptions.SO_LINGER` option? > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v11]

2024-05-20 Thread Sergey Chernyshev
> There are two distinct approaches to parsing IPv4 literal addresses. One is > the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another > one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr` > allowing octal and hexadecimal forms [2]). The goal of this

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v9]

2024-05-20 Thread Sergey Chernyshev
On Sun, 19 May 2024 14:29:49 GMT, Alan Bateman wrote: > I think you may have mis-read my comment. I think we need to add `@see > InetAddress4#ofPosixLiteral(String)` to InetAddress.ofLiteral, not > Inet4Address.ofLiteral. The reason is that methods defined by Inet4Address > are not very discov

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v11]

2024-05-20 Thread Aleksei Efimov
On Mon, 20 May 2024 09:25:31 GMT, Sergey Chernyshev wrote: >> There are two distinct approaches to parsing IPv4 literal addresses. One is >> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another >> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr

Re: RFR: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket [v3]

2024-05-20 Thread Daniel Fuchs
On Mon, 20 May 2024 06:02:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have b

Re: RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v4]

2024-05-20 Thread Daniel Fuchs
On Fri, 17 May 2024 11:33:14 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which clarifies the value >> type for the `java.net.SocketOptions.SO_LINGER` option? > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-20 Thread Phil Race
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-20 Thread Phil Race
On Mon, 13 May 2024 10:49:30 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > make/conf/module-loader-map.conf line 105: > >> 103: java.smartcardio \

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-20 Thread Alan Bateman
On Mon, 20 May 2024 18:39:31 GMT, Phil Race wrote: >> make/conf/module-loader-map.conf line 105: >> >>> 103: java.smartcardio \ >>> 104: jdk.accessibility \ >>> 105: jdk.attach \ >> >> The list of allowed modules has been rewritten from scratch, by looking at >> the set of modules

Re: RFR: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket [v3]

2024-05-20 Thread Iris Clark
On Mon, 20 May 2024 06:02:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have b

Re: RFR: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket [v3]

2024-05-20 Thread Jaikiran Pai
On Mon, 20 May 2024 06:02:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have b

Integrated: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket

2024-05-20 Thread Jaikiran Pai
On Wed, 15 May 2024 04:20:09 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to deprecate for > removal 3 methods on `java.net.MulticastSocket`? This addresses > https://bugs.openjdk.org/browse/JDK-8332181. > > As noted in that issue these methods have been d