On Fri, 17 May 2024 05:44:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which clarifies the value
>> type for the `java.net.SocketOptions.SO_LINGER` option?
>
> Jaikiran Pai has updated the pull request incrementally with one additional
> commit since the last
> Can I please get a review of this doc-only change which clarifies the value
> type for the `java.net.SocketOptions.SO_LINGER` option?
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
reword based on Alan's suggestion
-
On Fri, 17 May 2024 08:32:07 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reword the javadoc
>
> src/java.base/share/classes/java/net/SocketOptions.java line 197:
>
>> 195: * can be passe
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Fri, 17 May 2024 08:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which clarifies the value
>> type for the `java.net.SocketOptions.SO_LINGER` option?
>
> Jaikiran Pai has updated the pull request incrementally with one additional
> commit since the last
On Wed, 15 May 2024 04:20:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to deprecate for
> removal 3 methods on `java.net.MulticastSocket`? This addresses
> https://bugs.openjdk.org/browse/JDK-8332181.
>
> As noted in that issue these methods have been d
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Fri, 17 May 2024 10:31:02 GMT, Michael McMahon wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/net/Inet4Address.java
>>
>> Co-authored-by: Daniel Fuchs <67001856
On Fri, 17 May 2024 11:23:34 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
> Can I please get a review of this doc-only change which clarifies the value
> type for the `java.net.SocketOptions.SO_LINGER` option?
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
linger interval instead of linger timeout
--
On Fri, 17 May 2024 10:55:26 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reword based on Alan's suggestion
>
> src/java.base/share/classes/java/net/SocketOptions.java line 196:
>
>> 194:
On Fri, 17 May 2024 11:09:31 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> also add forRemoval in internal classes
>
> src/java.base/share/classes/java/net/NetMulticastSocket.java line 655:
>
>
> Can I please get a review of this change which proposes to deprecate for
> removal 3 methods on `java.net.MulticastSocket`? This addresses
> https://bugs.openjdk.org/browse/JDK-8332181.
>
> As noted in that issue these methods have been deprecated since Java 1.2 and
> 1.4 days. They currently
On Fri, 17 May 2024 10:42:44 GMT, Alan Bateman wrote:
> The new method is not easily discovered, which is okay as it's very much a
> method for experts, I see wonder if we should put a `@see` in
> InetAddress.ofLiteral.
Thanks @AlanBateman for your note. There's a link to `ofPosixLiteral` from
On Fri, 17 May 2024 11:47:34 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/net/NetMulticastSocket.java line 655:
>>
>>> 653: @Deprecated
>>> 654: @Override
>>> 655: @SuppressWarnings("removal")
>>
>> Instead of adding `@SuppressWarning("removal")` here (and at other p
On Fri, 17 May 2024 11:50:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal 3 methods on `java.net.MulticastSocket`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8332181.
>>
>> As noted in that issue these methods have b
On Fri, 17 May 2024 11:23:34 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 16 May 2024 18:39:57 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add note on --illegal-native-access default value in the launcher help
>
> src/java.base/share/classes/java/lang
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
> the use of JNI in the following ways:
>
> * `System::load` and `System::loadLibrary` are now restricted methods
> * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods
> * binding a JNI `native` metho
On Fri, 17 May 2024 11:50:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal 3 methods on `java.net.MulticastSocket`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8332181.
>>
>> As noted in that issue these methods have b
On Fri, 17 May 2024 11:23:34 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
27 matches
Mail list logo
