Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v8]

2024-05-16 Thread Sergey Chernyshev
On Wed, 15 May 2024 17:34:21 GMT, Daniel Fuchs wrote: >> Sergey Chernyshev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed class level docs > > src/java.base/share/classes/java/net/Inet4Address.java line 102: > >> 100: * Please

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v9]

2024-05-16 Thread Sergey Chernyshev
> There are two distinct approaches to parsing IPv4 literal addresses. One is > the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another > one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr` > allowing octal and hexadecimal forms [2]). The goal of this

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v5]

2024-05-16 Thread Daniel Fuchs
On Tue, 7 May 2024 10:08:12 GMT, Aleksei Efimov wrote: >> The parsing code and the test changes look good to me with a couple of minor >> suggestions. > >> @AlekseiEfimov @jaikiran @Michael-Mc-Mahon Could you please take a look and >> review the [CSR ](https://bugs.openjdk.org/browse/JDK-832987

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v9]

2024-05-16 Thread Aleksei Efimov
On Thu, 16 May 2024 09:12:20 GMT, Sergey Chernyshev wrote: >> There are two distinct approaches to parsing IPv4 literal addresses. One is >> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another >> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Jaikiran Pai
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Jaikiran Pai
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Maurizio Cimadamore
On Thu, 16 May 2024 11:42:48 GMT, Jaikiran Pai wrote: > Hello Maurizio, in the current mainline, we have code in `LauncherHelper` > https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/launcher/LauncherHelper.java#L636 > where we enable native access to all unnamed modules

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Jaikiran Pai
On Thu, 16 May 2024 11:47:13 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/sun/launcher/resources/launcher.properties line >> 72: >> >>> 70: \ by code in modules for which native access is not >>> explicitly enabled.\n\ >>> 71: \ is one of "

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Maurizio Cimadamore
On Thu, 16 May 2024 11:55:35 GMT, Jaikiran Pai wrote: >> We already do, see >> https://github.com/openjdk/jdk/pull/19213/files/1c45e5d56c429205ab8185481bc1044a86ab3bc6#diff-d05029afe6aed86f860a10901114402f1f6af4fe1e4b46d883141ab1d2a527b8R582 > > This is slightly different from what we do in the o

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v7]

2024-05-16 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native` metho

Re: RFR: 8315767: InetAddress: constructing objects from BSD literal addresses [v5]

2024-05-16 Thread Sergey Chernyshev
On Tue, 7 May 2024 10:08:12 GMT, Aleksei Efimov wrote: >> The parsing code and the test changes look good to me with a couple of minor >> suggestions. > >> @AlekseiEfimov @jaikiran @Michael-Mc-Mahon Could you please take a look and >> review the [CSR ](https://bugs.openjdk.org/browse/JDK-832987

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v7]

2024-05-16 Thread Alan Bateman
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8332181: Deprecate for removal the java.net.MulticastSocket.setTTL/getTTL and the 2-arg send methods

2024-05-16 Thread robert engels
On Wed, 15 May 2024 04:20:09 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to deprecate for > removal 3 methods on `java.net.MulticastSocket`? This addresses > https://bugs.openjdk.org/browse/JDK-8332181. > > As noted in that issue these methods have been d

Re: RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v2]

2024-05-16 Thread Jaikiran Pai
> Can I please get a review of this doc-only change which clarifies the value > type for the `java.net.SocketOptions.SO_LINGER` option? Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: reword the javadoc - Changes: - a

Re: RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v2]

2024-05-16 Thread Jaikiran Pai
On Wed, 15 May 2024 11:07:05 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reword the javadoc > > src/java.base/share/classes/java/net/SocketOptions.java line 197: > >> 195: * {@link #setO