On Tue, 9 Apr 2024 13:35:00 GMT, Daniel Fuchs wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments in Javadoc
>
> src/java.base/share/classes/java/net/Inet4Address.java line 103:
>
>> 101
On Wed, 10 Apr 2024 15:34:22 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Wed, 10 Apr 2024 15:30:52 GMT, Sergey Chernyshev
wrote:
>> src/java.base/share/classes/java/net/Inet4Address.java line 103:
>>
>>> 101: * octal and hexadecimal address segments. Please refer to
>>> 102: * https://www.ietf.org/rfc/rfc6943.html#section-3.1.1";>
>>> RFC
>>> 103: * 6943: Is
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Wed, 10 Apr 2024 15:34:22 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
On Thu, 11 Apr 2024 09:15:54 GMT, Daniel Fuchs wrote:
>> This removes the reference of loose syntax that was opposed to strict
>> syntax. Would you think to also remove the word "strict"?
>
> @sercher the word "loose" is still there - it's not removed?
Right. Apologies, i didn't notice it.
---
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
On Thu, 11 Apr 2024 09:56:56 GMT, Florent Guillaume wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments in Javadoc
>
> test/jdk/java/net/InetAddress/OfLiteralTest.java line 232:
>
>> 230
On Thu, 11 Apr 2024 09:21:36 GMT, Daniel Fuchs wrote:
>> I updated the docs to link to the class specification, also added an anchor
>> in the spec.
>
> I would rather move the description of the loose syntax fully here, since the
> only method that accepts it is `Inet4Address.ofPosixLiteral`.
On Thu, 11 Apr 2024 12:58:07 GMT, Sergey Chernyshev
wrote:
>> There are two distinct approaches to parsing IPv4 literal addresses. One is
>> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
>> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr
> There are two distinct approaches to parsing IPv4 literal addresses. One is
> the Java baseline "strict" syntax (all-decimal d.d.d.d form family), another
> one is the "loose" syntax of RFC 6943 section 3.1.1 [1] (POSIX `inet_addr`
> allowing octal and hexadecimal forms [2]). The goal of this
11 matches
Mail list logo
