On Tue, 2 Apr 2024 11:55:12 GMT, Darragh Clarke wrote:
>> Currently this test occasionally doesn't cleanup between runs, sometimes not
>> stopping the server or leaving Streams open
>>
>> Changes:
>> - Use try-with-resources to ensure streams close.
>> - Use try-finally to make sure the server
Can I please get a review of this test-only change which updates an existing
test case to verify the behaviour of `HttpRequest.Builder.HEAD()` method?
As noted in https://bugs.openjdk.org/browse/JDK-8329662, this test now verifies
the default implementation specified for `HttpRequest.Builder.HEA
When doing some testing on github.com/robaho/httpserver - which is a fork of the jdk http server, I discovered a significant performance issue.When an http connection is in ‘keep-alive’ - the default for http 1.1 - the headers are “flushed” here https://github.com/openjdk/jdk21/blob/890adb6410dab
When doing some testing on github.com/robaho/httpserver - which is a fork of the jdk http server, I discovered a significant performance issue.When an http connection is in ‘keep-alive’ - the default for http 1.1 - the headers are “flushed” here https://github.com/openjdk/jdk21/blob/890adb6410dab4
Hi Robert,
Thanks for bringing this up! We are aware of the issue, it's tracked under
https://bugs.openjdk.org/browse/JDK-6968351.
If you have an idea for a proper fix that doesn't add too much complexity,
please open a PR, and we'll be happy to help.
Cheers,
Daniel
czw., 4 kwi 2024, 14:55 użytko
On Thu, 4 Apr 2024 11:50:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which updates an existing
> test case to verify the behaviour of `HttpRequest.Builder.HEAD()` method?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8329662, this test now
> verifies
