On Tue, 25 Mar 2025 09:39:07 GMT, Eirik Bjørsnøs wrote:
>> Please help review this cleanup PR which makes the
>> `java.net.JarURLConnection` fields `jarFileURL` and `entryName` final.
>>
>> The current `parseSpec` method is somewhat crufty, with some code quality
>> issues which this PR aims
On Tue, 25 Mar 2025 21:06:29 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/JarURLConnection.java line 165:
>>
>>> 163: int separatorIndex = spec.indexOf("!/");
>>> 164:
>>> 165: // REMIND: we don't handle nested JAR URLs
>>
>> Just noticed that this comment s
On Tue, 25 Mar 2025 19:59:43 GMT, Eirik Bjørsnøs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename 'separator' to 'separatorIndex', 'nameIdx' to 'nameIndex'
>
> src/java.base/share/classes/java/net/JarURLCon
On Tue, 25 Mar 2025 09:39:07 GMT, Eirik Bjørsnøs wrote:
>> Please help review this cleanup PR which makes the
>> `java.net.JarURLConnection` fields `jarFileURL` and `entryName` final.
>>
>> The current `parseSpec` method is somewhat crufty, with some code quality
>> issues which this PR aims
On Tue, 25 Mar 2025 09:39:07 GMT, Eirik Bjørsnøs wrote:
>> Please help review this cleanup PR which makes the
>> `java.net.JarURLConnection` fields `jarFileURL` and `entryName` final.
>>
>> The current `parseSpec` method is somewhat crufty, with some code quality
>> issues which this PR aims
On Tue, 25 Mar 2025 09:39:07 GMT, Eirik Bjørsnøs wrote:
>> Please help review this cleanup PR which makes the
>> `java.net.JarURLConnection` fields `jarFileURL` and `entryName` final.
>>
>> The current `parseSpec` method is somewhat crufty, with some code quality
>> issues which this PR aims
On Tue, 25 Mar 2025 09:52:38 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename 'separator' to 'separatorIndex', 'nameIdx' to 'nameIndex'
>
> Thank you for the update. Looks fine to me.
@ja
On Tue, 25 Mar 2025 09:27:15 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename 'separator' to 'separatorIndex', 'nameIdx' to 'nameIndex'
>
> src/java.base/share/classes/java/net/JarURLConne
> Please help review this cleanup PR which makes the
> `java.net.JarURLConnection` fields `jarFileURL` and `entryName` final.
>
> The current `parseSpec` method is somewhat crufty, with some code quality
> issues which this PR aims to improve:
>
> * The method-level comment seems stale and mis
