On Fri, 10 May 2024 14:46:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 14:46:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address, the printed URL doesn't enclose the
> IPv6 literal in
On Fri, 10 May 2024 12:02:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 12:02:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 10:53:36 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Daniel's suggestion - don't change resource bundle messages
>
> test/jdk/com/sun/net/httpserver/simpleserver/jwebserver
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address, the printed URL doesn't enclose the
> IPv6 literal in
On Fri, 10 May 2024 10:31:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 10:16:10 GMT, Jaikiran Pai wrote:
>> Oh - I see... Hmmm - good question. I'd say it should be OK, since it's only
>> a log message.
>> My concern here is potentially backporting this change - where we would need
>> to make sure that all resource bundles in all possible langu
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address, the printed URL doesn't enclose the
> IPv6 literal in
On Fri, 10 May 2024 10:14:13 GMT, Daniel Fuchs wrote:
> My concern here is potentially backporting this change - where we would need
> to make sure that all resource bundles in all possible languages that are
> supported are correctly updated.
I hadn't considered that. Given that, I think it's
On Fri, 10 May 2024 10:05:07 GMT, Jaikiran Pai wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java
>> line 185:
>>
>>> 183:
>>> writer.println(ResourceBundleHelper.getMessage("msg.start.anylocal", root,
>>> port, url));
>>> 184:
On Fri, 10 May 2024 10:00:57 GMT, Daniel Fuchs wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8332020?
>>
>> `jwebserver` when it is launched prints a URL where the server is
>> accessible. When launched using an IPv6 bind ad
On Fri, 10 May 2024 09:21:15 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible.
> When launched using an IPv6 bind address
14 matches
Mail list logo