On Tue, 23 Apr 2024 10:49:42 GMT, Christoph Langer wrote:
>> In su.net.www.http.KeepAliveCache we could use pattern matching for
>> instanceof.
>
> Christoph Langer has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add Daniel's more awesome
On Tue, 23 Apr 2024 08:54:17 GMT, Daniel Jeliński wrote:
> I'd prefer this instead:
>
> ```
> if (!(obj instanceof KeepAliveKey kae))
> return false;
> ```
>
> because it's more awesome :) but what you propose looks good too.
Yes, you're right. Adapted. 😄
-
PR
> In su.net.www.http.KeepAliveCache we could use pattern matching for
> instanceof.
Christoph Langer has updated the pull request incrementally with one additional
commit since the last revision:
Add Daniel's more awesome suggestion
-
Changes:
- all: https://git.openjdk.org/jd
On Mon, 22 Apr 2024 11:23:59 GMT, Christoph Langer wrote:
> In su.net.www.http.KeepAliveCache we could use pattern matching for
> instanceof.
I'd prefer this instead:
if (!(obj instanceof KeepAliveKey kae))
return false;
because it's more awesome :) but what you propose lo
On Mon, 22 Apr 2024 11:23:59 GMT, Christoph Langer wrote:
> In su.net.www.http.KeepAliveCache we could use pattern matching for
> instanceof.
Hello Christoph, this cleanup change looks good to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pul
