Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v2]

2025-07-07 Thread Daniel Fuchs
On Mon, 7 Jul 2025 09:32:33 GMT, Volkan Yazici wrote: >> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` >> method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` >> publisher to upload a certain region of a file. The new publisher does not >> modi

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v2]

2025-07-07 Thread Volkan Yazici
On Mon, 7 Jul 2025 08:36:51 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implement review feedback > > src/java.net.http/share/classes/jdk/internal/net/http/RequestPublishers.java > line 488:

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v2]

2025-07-07 Thread Volkan Yazici
On Mon, 7 Jul 2025 08:31:10 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 739: >> >>> 737: * @param channel a file channel >>> 738: * @param offset the offset of the first byte >>> 739: * @param length the number of byt

Re: RFR: 8329829: HttpClient: Add a BodyPublishers.ofFileChannel method [v2]

2025-07-07 Thread Volkan Yazici
> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` > method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` > publisher to upload a certain region of a file. The new publisher does not > modify the state of the passed `FileChannel`, streams the file c