Re: RFR: Mark not subclassable classes final in java.base exported classes

2024-11-29 Thread Jaikiran Pai
Hello Eirik, On 27/11/24 2:26 am, Eirik Bjørsnøs wrote: On Tue, Nov 26, 2024 at 2:22 PM Eirik Bjørsnøs wrote: In addition to simply adding the final modifier, the CSR suggests minor updates to the classes DynamicCallSiteDesc, ModuleDescriptor and InterfaceAddress to better express

Re: RFR: Mark not subclassable classes final in java.base exported classes

2024-11-26 Thread Eirik Bjørsnøs
On Tue, Nov 26, 2024 at 2:22 PM Eirik Bjørsnøs wrote: > In addition to simply adding the final modifier, the CSR suggests minor > updates to the classes DynamicCallSiteDesc, ModuleDescriptor and > InterfaceAddress to better express them being non-subclassable. > The changes to make the Interface

RFR: Mark not subclassable classes final in java.base exported classes

2024-11-26 Thread Eirik Bjørsnøs
Hi, I have drafted a CSR for JDK-8344943 which is now ready for an initial round of reviews: https://bugs.openjdk.org/browse/JDK-8345054 The CSR adds the "final" modifier to 21 classes in java.base which are today "effectively not subclassable", but not marked as such. In addition to simply add