Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v3]

2025-05-13 Thread Daniel Fuchs
On Tue, 13 May 2025 15:08:08 GMT, kieran-farrell wrote: >> Spec currently suggests that only IPv6 addresses can return null for >> InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 >> address such as the loopback address do not support broadcasting and can >> therefor

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v3]

2025-05-13 Thread kieran-farrell
On Tue, 13 May 2025 13:55:49 GMT, Daniel Fuchs wrote: >> I think the original wording of the class level doc was phrased awkwardly. >> I'd like to suggest the following: >> >> * This class represents a Network Interface address. In the case of >> * IPv4, this comprises the IP address, a subne

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v3]

2025-05-13 Thread kieran-farrell
> Spec currently suggests that only IPv6 addresses can return null for > InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 > address such as the loopback address do not support broadcasting and can > therefore also return null. kieran-farrell has updated the pull reque

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v2]

2025-05-13 Thread Daniel Fuchs
On Tue, 13 May 2025 09:59:02 GMT, Michael McMahon wrote: >> Thanks Daniel, I have commited the above change in wording to the get >> broadcast method and updated the CSR to reflect (JDK-8356002). I will await >> confirmation on the class level API documentation before updating. > > I think the

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v2]

2025-05-13 Thread Michael McMahon
On Fri, 9 May 2025 10:02:25 GMT, kieran-farrell wrote: >> src/java.base/share/classes/java/net/InterfaceAddress.java line 67: >> >>> 65: * >>> 66: * Certain IPv4 addresses, such as the loopback address, do not >>> support >>> 67: * broadcasting and will also result in {@code nul

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v2]

2025-05-09 Thread kieran-farrell
On Wed, 7 May 2025 14:41:58 GMT, Daniel Fuchs wrote: >> kieran-farrell has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.base/share/classes/java/net/InterfaceAddress.java >> >> Co-authored-by: Daniel Fuchs <67001856+df

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method [v2]

2025-05-09 Thread kieran-farrell
> Spec currently suggests that only IPv6 addresses can return null for > InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 > address such as the loopback address do not support broadcasting and can > therefore also return null. kieran-farrell has updated the pull reque

Re: RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method

2025-05-07 Thread Daniel Fuchs
On Wed, 7 May 2025 14:02:52 GMT, kieran-farrell wrote: > Spec currently suggests that only IPv6 addresses can return null for > InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 > address such as the loopback address do not support broadcasting and can > therefore als

RFR: 8356395: Spec needs to be clarified for InterfaceAddress.getBroadcast() method

2025-05-07 Thread kieran-farrell
Spec currently suggests that only IPv6 addresses can return null for InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 address such as the loopback address do not support broadcasting and can therefore also return null. - Commit messages: - update inetadd