Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes [v2]

2025-04-10 Thread Jaikiran Pai
On Mon, 7 Apr 2025 13:22:56 GMT, Eirik Bjørsnøs wrote: >> Please help review this cleanup PR which consolidates 'local file' URL >> checks across the 'file:' and 'jar:' URL scheme implementations and defines >> this check in terms of RFC 8089, Section 2. >> >> This PR: >> >> * Moves `URLJarFi

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes [v2]

2025-04-07 Thread Daniel Fuchs
On Mon, 7 Apr 2025 13:26:45 GMT, Eirik Bjørsnøs wrote: >> Please help review this cleanup PR which consolidates 'local file' URL >> checks across the 'file:' and 'jar:' URL scheme implementations and defines >> this check in terms of RFC 8089, Section 2. >> >> This PR: >> >> * Moves `URLJarFi

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes [v2]

2025-04-07 Thread Eirik Bjørsnøs
On Mon, 7 Apr 2025 13:13:40 GMT, Jaikiran Pai wrote: > Hello Eirik, these changes look good to me and merely centralizing the logic > to one single `ParseUtil.isLocalFileURL()` method. Thank you for cleaning > this up. Thank you for verifying! > The copyright year on `URLJarFile.java` will ne

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes [v2]

2025-04-07 Thread Eirik Bjørsnøs
> Please help review this cleanup PR which consolidates 'local file' URL checks > across the 'file:' and 'jar:' URL scheme implementations and defines this > check in terms of RFC 8089, Section 2. > > This PR: > > * Moves `URLJarFile.isFileURL` to `sun.net.www.ParseUtil` where it is > document

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes

2025-04-07 Thread Jaikiran Pai
On Mon, 31 Mar 2025 14:46:32 GMT, Eirik Bjørsnøs wrote: > Please help review this cleanup PR which consolidates 'local file' URL checks > across the 'file:' and 'jar:' URL scheme implementations and defines this > check in terms of RFC 8089, Section 2. > > This PR: > > * Moves `URLJarFile.isF

RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes

2025-04-05 Thread Eirik Bjørsnøs
Please help review this cleanup PR which consolidates 'local file' URL checks across the 'file:' and 'jar:' URL scheme implementations and defines this check in terms of RFC 8089, Section 2. This PR: * Moves `URLJarFile.isFileURL` to `sun.net.www.ParseUtil` where it is documented according to

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes

2025-04-04 Thread Daniel Fuchs
On Mon, 31 Mar 2025 14:46:32 GMT, Eirik Bjørsnøs wrote: > Please help review this cleanup PR which consolidates 'local file' URL checks > across the 'file:' and 'jar:' URL scheme implementations and defines this > check in terms of RFC 8089, Section 2. > > This PR: > > * Moves `URLJarFile.isF

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes

2025-04-04 Thread Jaikiran Pai
On Mon, 31 Mar 2025 14:46:32 GMT, Eirik Bjørsnøs wrote: > Please help review this cleanup PR which consolidates 'local file' URL checks > across the 'file:' and 'jar:' URL scheme implementations and defines this > check in terms of RFC 8089, Section 2. > > This PR: > > * Moves `URLJarFile.isF

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes

2025-04-03 Thread Eirik Bjørsnøs
On Thu, 3 Apr 2025 10:12:44 GMT, Daniel Fuchs wrote: > My tests came back green - but it wouldn't hurt to have another > reviewer/committer eyeball these changes before integrating. As far as I > could tell - the code with the new changes is strictly equivalent to the old. Thanks Daniel! I'v

Re: RFR: 8353278: Consolidate local file URL checks in jar: and file: URL schemes

2025-04-03 Thread Daniel Fuchs
On Mon, 31 Mar 2025 14:46:32 GMT, Eirik Bjørsnøs wrote: > Please help review this cleanup PR which consolidates 'local file' URL checks > across the 'file:' and 'jar:' URL scheme implementations and defines this > check in terms of RFC 8089, Section 2. > > This PR: > > * Moves `URLJarFile.isF