Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v5]

2025-02-04 Thread duke
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote: >> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Fix `assertEquals()` argument order @vy Your ch

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v5]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote: >> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Fix `assertEquals()` argument order Attached suc

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v5]

2025-02-04 Thread Jaikiran Pai
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote: >> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Fix `assertEquals()` argument order Thank you fo

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v4]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 11:22:41 GMT, Jaikiran Pai wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace `assert`s with explicit checks throwing `AssertionError`s > > test/jdk/java/net/httpclient/HttpRequestBuilderTe

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v5]

2025-02-04 Thread Volkan Yazici
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Fix `assertEquals()` argument order - Changes: - all: https://git.openjdk.org/jdk/pull/23415/files

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v4]

2025-02-04 Thread Daniel Fuchs
On Tue, 4 Feb 2025 11:07:09 GMT, Volkan Yazici wrote: >> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Replace `assert`s with explicit checks throwing `

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v4]

2025-02-04 Thread Jaikiran Pai
On Tue, 4 Feb 2025 11:07:09 GMT, Volkan Yazici wrote: >> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Replace `assert`s with explicit checks throwing `

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v4]

2025-02-04 Thread Volkan Yazici
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Replace `assert`s with explicit checks throwing `AssertionError`s - Changes: - all: https://git.ope

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v3]

2025-02-04 Thread Volkan Yazici
On Tue, 4 Feb 2025 07:24:20 GMT, Jaikiran Pai wrote: >> Volkan Yazici has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v3]

2025-02-03 Thread Jaikiran Pai
On Mon, 3 Feb 2025 19:33:23 GMT, Volkan Yazici wrote: >> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v3]

2025-02-03 Thread Volkan Yazici
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional co

Re: RFR: 8349135: Add tests for HttpRequest.Builder.copy() [v2]

2025-02-03 Thread Volkan Yazici
> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/23415/files - new: https

RFR: 8349135: Add tests for HttpRequest.Builder.copy()

2025-02-03 Thread Volkan Yazici
Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`. - Commit messages: - Verify `copy()` in `HttpRequestBuilderTest` Changes: https://git.openjdk.org/jdk/pull/23415/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23415&range=00 Issue: https://bugs.openjdk.