> Can I get a review of this test-only cleanup/speedup PR which modernizes the
> test `RemoveJar.java`.
>
> This test attempts a variety of class loading scenarios on a URLClassLoader
> and verifies that when the loader is closed, it has released its JAR file
> (such that it may be deleted on W
On Sat, 23 Nov 2024 10:32:28 GMT, Eirik Bjørsnøs wrote:
>> Can I get a review of this test-only cleanup/speedup PR which modernizes the
>> test `RemoveJar.java`.
>>
>> This test attempts a variety of class loading scenarios on a URLClassLoader
>> and verifies that when the loader is closed, it
> Can I get a review of this test-only cleanup/speedup PR which modernizes the
> test `RemoveJar.java`.
>
> This test attempts a variety of class loading scenarios on a URLClassLoader
> and verifies that when the loader is closed, it has released its JAR file
> (such that it may be deleted on W
On Fri, 22 Nov 2024 14:12:10 GMT, Eirik Bjørsnøs wrote:
> I could add an `assertEmptyJarFileCaches` method to the start of the test
> execution, this will verify that all test runs starting with a non-empty
> cache fails.
I went ahead and added a sanity check verifying that the `JarFileFactory
On Fri, 22 Nov 2024 13:57:17 GMT, Daniel Fuchs wrote:
> Hi Eirik, IIRC the cache is global - so I don't think running the test in the
> same VM will work. I mean, I don't think we will be testing the same thing.
That is a fair point. On the other hand; the test asserts that the file can be
del
On Fri, 22 Nov 2024 10:55:37 GMT, Eirik Bjørsnøs wrote:
> Can I get a review of this test-only cleanup/speedup PR which modernizes the
> test `RemoveJar.java`.
>
> This test attempts a variety of class loading scenarios on a URLClassLoader
> and verifies that when the loader is closed, it has
Can I get a review of this test-only cleanup/speedup PR which modernizes the
test `RemoveJar.java`.
This test attempts a variety of class loading scenarios on a URLClassLoader and
verifies that when the loader is closed, it has released its JAR file (such
that it may be deleted on Windows).
Ch
