Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v3]

2024-10-24 Thread Daniel Fuchs
On Tue, 22 Oct 2024 15:08:57 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v3]

2024-10-23 Thread Jaikiran Pai
On Tue, 22 Oct 2024 15:08:57 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v3]

2024-10-22 Thread Daniel Fuchs
> Please find here a fix that improves flow control in the HTTP/2 > implementation. > > The change makes sure that flow control issues are reported to the server as > FLOW_CONTROL_ERROR. > It also clarify how some system properties that allow to initialize flow > control windows are handled, by

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Jaikiran Pai
On Tue, 22 Oct 2024 14:15:49 GMT, Daniel Fuchs wrote: > Maybe I should say "is called directly" ? I think that would still be unclear since "directly" is contextual and depends on who is calling it. So we would then have to clarify what a direct call is. Perhaps we should reword it to say tha

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Jaikiran Pai
On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Daniel Fuchs
On Tue, 22 Oct 2024 14:09:29 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply suggestions from code review >> >> Co-authored-by: Andrey Turbanov > > src/java.net.http/share/classes/jdk/

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Jaikiran Pai
On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Daniel Fuchs
On Tue, 22 Oct 2024 13:47:32 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply suggestions from code review >> >> Co-authored-by: Andrey Turbanov > > src/java.net.http/share/classes/jdk/

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Jaikiran Pai
On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Jaikiran Pai
On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-22 Thread Jaikiran Pai
On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs wrote: >> Please find here a fix that improves flow control in the HTTP/2 >> implementation. >> >> The change makes sure that flow control issues are reported to the server as >> FLOW_CONTROL_ERROR. >> It also clarify how some system properties th

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

2024-10-21 Thread Daniel Fuchs
> Please find here a fix that improves flow control in the HTTP/2 > implementation. > > The change makes sure that flow control issues are reported to the server as > FLOW_CONTROL_ERROR. > It also clarify how some system properties that allow to initialize flow > control windows are handled, by

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks

2024-10-21 Thread Daniel Fuchs
On Thu, 17 Oct 2024 16:33:47 GMT, Daniel Fuchs wrote: > Please find here a fix that improves flow control in the HTTP/2 > implementation. > > The change makes sure that flow control issues are reported to the server as > FLOW_CONTROL_ERROR. > It also clarify how some system properties that all

Re: RFR: 8342075: HttpClient: improve HTTP/2 flow control checks

2024-10-21 Thread Andrey Turbanov
On Thu, 17 Oct 2024 16:33:47 GMT, Daniel Fuchs wrote: > Please find here a fix that improves flow control in the HTTP/2 > implementation. > > The change makes sure that flow control issues are reported to the server as > FLOW_CONTROL_ERROR. > It also clarify how some system properties that all

RFR: 8342075: HttpClient: improve HTTP/2 flow control checks

2024-10-17 Thread Daniel Fuchs
Please find here a fix that improves flow control in the HTTP/2 implementation. The change makes sure that flow control issues are reported to the server as FLOW_CONTROL_ERROR. It also clarify how some system properties that allow to initialize flow control windows are handled, by documenting th