On Mon, 23 Dec 2024 13:59:14 GMT, Volkan Yazıcı wrote:
>> Cleans up `sun.net.www.MimeTable`:
>>
>> * Removes unused methods & variables
>> * Removes commented out code
>> * Simplifies iterations over arrays
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commi
On Mon, 23 Dec 2024 13:59:14 GMT, Volkan Yazıcı wrote:
>> Cleans up `sun.net.www.MimeTable`:
>>
>> * Removes unused methods & variables
>> * Removes commented out code
>> * Simplifies iterations over arrays
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commi
On Mon, 23 Dec 2024 12:52:24 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/net/www/MimeTable.java line 186:
>>
>>> 184: }
>>> 185:
>>> 186: public synchronized Enumeration elements() {
>>
>> Can we drop `elements` as well?
>
> `sun.net.www.MimeTable#find` seems unused
> Cleans up `sun.net.www.MimeTable`:
>
> * Removes unused methods & variables
> * Removes commented out code
> * Simplifies iterations over arrays
Volkan Yazıcı has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused and hide locally access
On Mon, 23 Dec 2024 12:51:04 GMT, Andrey Turbanov wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make `MimeTable` final
>
> src/java.base/share/classes/sun/net/www/MimeTable.java line 186:
>
>> 184: }
>> 185
On Mon, 23 Dec 2024 12:36:54 GMT, Volkan Yazıcı wrote:
>> Cleans up `sun.net.www.MimeTable`:
>>
>> * Removes unused methods & variables
>> * Removes commented out code
>> * Simplifies iterations over arrays
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commi
On Mon, 23 Dec 2024 12:36:54 GMT, Volkan Yazıcı wrote:
>> Cleans up `sun.net.www.MimeTable`:
>>
>> * Removes unused methods & variables
>> * Removes commented out code
>> * Simplifies iterations over arrays
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commi
On Thu, 19 Dec 2024 17:11:15 GMT, Roger Riggs wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make `MimeTable` final
>
> src/java.base/share/classes/sun/net/www/MimeTable.java line 370:
>
>> 368: }
>> 369:
>
> Cleans up `sun.net.www.MimeTable`:
>
> * Removes unused methods & variables
> * Removes commented out code
> * Simplifies iterations over arrays
Volkan Yazıcı has updated the pull request incrementally with one additional
commit since the last revision:
Make `MimeTable` final
-
On Thu, 19 Dec 2024 16:23:51 GMT, Volkan Yazıcı wrote:
> Cleans up `sun.net.www.MimeTable`:
>
> * Removes unused methods & variables
> * Removes commented out code
> * Simplifies iterations over arrays
Hello Volkan, the changes look good to me. I agree with Roger that marking this
(internal) c
On Thu, 19 Dec 2024 19:42:50 GMT, Andrey Turbanov wrote:
>> I don't think we have a deprecation process for this kind of dependency but
>> dropping these deserves a CSR since the behavior is changing (and a release
>> note).
>
>>behavior is changing
>
> What behavior is changing?
My mistake,
On Thu, 19 Dec 2024 17:01:42 GMT, Roger Riggs wrote:
>behavior is changing
What behavior is changing?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/22831#discussion_r1893046714
On Thu, 19 Dec 2024 16:25:49 GMT, Volkan Yazıcı wrote:
>> Cleans up `sun.net.www.MimeTable`:
>>
>> * Removes unused methods & variables
>> * Removes commented out code
>> * Simplifies iterations over arrays
>
> src/java.base/share/classes/sun/net/www/MimeTable.java line 233:
>
>> 231:
On Thu, 19 Dec 2024 16:23:51 GMT, Volkan Yazıcı wrote:
> Cleans up `sun.net.www.MimeTable`:
>
> * Removes unused methods & variables
> * Removes commented out code
> * Simplifies iterations over arrays
src/java.base/share/classes/sun/net/www/MimeTable.java line 370:
> 368: }
> 369:
> 370:
On Thu, 19 Dec 2024 16:23:51 GMT, Volkan Yazıcı wrote:
> Cleans up `sun.net.www.MimeTable`:
>
> * Removes unused methods & variables
> * Removes commented out code
> * Simplifies iterations over arrays
`tier1` tests pass on 91554c5873d4b643ca1234507aece44b33ecfd90 – the run report
is shared in
Cleans up `sun.net.www.MimeTable`:
* Removes unused methods & variables
* Removes commented out code
* Simplifies iterations over arrays
-
Commit messages:
- Clean up `sun.net.www.MimeTable`
Changes: https://git.openjdk.org/jdk/pull/22831/files
Webrev: https://webrevs.openjdk.org
16 matches
Mail list logo
