On Tue, 29 Jul 2025 17:18:12 GMT, Darragh Conway wrote:
> Refactor remove the test logic for Windows OS and replace with jtreg check
> for os
@DarraghConway
Your change (at version c29e8dabe1886913fa1b3b2895aa41705f7663e3) is now ready
to be sponsored by a Committer.
-
PR Commen
On Tue, 22 Jul 2025 10:47:44 GMT, Ayush Rigal wrote:
>> This is part of a series of diagnostic output updates to java.net tests to
>> assist in the analysis of failures in IPv6 only environments
>> for Linux there is not IPv4 configuration but the IPv4 stack remains enabled
>> For macOS, and win
On Wed, 19 Feb 2025 15:48:10 GMT, Matthew Donovan wrote:
> This PR updates the CertificateBuilder with a new method that creates a new
> instance with common fields (subject name, public key, serial number,
> validity, and key uses) filled-in. One test, IPIdentities.java, is updated to
> show
On Wed, 5 Feb 2025 17:39:42 GMT, Mikhail Yankelevich
wrote:
> * fully automated the test
> * removed the race condition
> * client on a thread and server on a thread options are now run together
> automatically
This pull request has been closed without being integrated.
-
PR: htt
On Tue, 24 Jun 2025 15:52:48 GMT, David Beaumont wrote:
>> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
>> non-resource data to users.
>>
>> This change has the following distinct parts:
>> 1. Refactor code to use Node instead of directly accessing low level
>> ImageLoc
On Thu, 12 Jun 2025 17:52:51 GMT, p-nima wrote:
>> The AuthenticationFilter did not respect the default retry limit of 3
>> retries in case of invalid credentials supplied.
>>
>> This PR helps to resolve the bug and tests it with default and updated retry
>> limit set via `jdk.httpclient.auth.
On Mon, 9 Jun 2025 10:54:29 GMT, kieran-farrell wrote:
> Intermittent failures have been seen with HttpURLConnectionExpectContinueTest
> on macOS possible due to the test using the host systems proxy configuations.
>
> Failures seen on JDK11 and JDK17 but adding no proxy conifguration to othe
On Tue, 27 May 2025 18:42:38 GMT, Mikhail Yankelevich
wrote:
>> HttpServer::stop will terminate the server immidiately after all exhcnages
>> are complete.
>> If the exchanges take longer then the specified delay it will terminate
>> straight after the delay, the same as the previous behaviour
On Wed, 7 May 2025 14:39:35 GMT, kieran-farrell wrote:
>> Clarificatiion of spec to outline that Authenticator.getRequestingURL()
>> returns null in the event that the corresponding request does not specify a
>> URL.
>
> kieran-farrell has updated the pull request incrementally with one additio
On Thu, 15 May 2025 05:14:02 GMT, Patrick Strawderman wrote:
> Avoid allocating a substring to parse the response code in
> HttpURLConnection#getResponseCode, but instead use the Integer.parseInt
> overload that accepts String indices.
@kilink
Your change (at version b2d42d35a1d113649adb69664
On Thu, 15 May 2025 13:47:23 GMT, serhiysachkov wrote:
>> change
>> test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to
>> a manual test
>
> serhiysachkov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes t
On Thu, 15 May 2025 11:29:33 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Tue, 13 May 2025 15:08:08 GMT, kieran-farrell wrote:
>> Spec currently suggests that only IPv6 addresses can return null for
>> InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4
>> address such as the loopback address do not support broadcasting and can
>> therefor
On Mon, 12 May 2025 19:53:35 GMT, Volkan Yazici wrote:
>> `ServerUdsChannelHolder` is introduced to manage the life cycle of a
>> `ServerSocketChannel` created using Unix domain sockets (UDS) in a
>> thread-safe manner.
>>
>> ### Testing
>>
>> Changes can be tested as follows:
>>
>>
>> make
On Fri, 9 May 2025 09:53:08 GMT, Volkan Yazici wrote:
>> Allows relative paths in the content root directory passed to the
>> `jwebserver`. Changes effect both the `jwebserver` executable and the `java
>> -m jdk.httpserver` execution.
>>
>> ### Implementation notes
>>
>> Received `Path` is re
On Fri, 2 May 2025 09:15:24 GMT, Volkan Yazici wrote:
>> Replaces `os.name` checks in tests with `@requires`. This prevents these
>> tests from being run, and superficial results being generated, on
>> unnecessary platforms.
>>
>> Note that `os.name` checks are replaced with `os.family` instea
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote:
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
This pull request has been closed without being integr
On Thu, 24 Apr 2025 07:24:36 GMT, Volkan Yazici wrote:
>> Incorporates the test server name while deriving the HTTP/2 test server
>> (i.e., `jdk.httpclient.test.lib.http2.Http2TestServer`) thread names to
>> improve diagnostics.
>>
>> ### Making `HttpTestServer` implement `AutoCloseable`
>>
>
On Thu, 17 Apr 2025 01:36:30 GMT, Artur Barashev wrote:
>> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates:
>>
>>
>> Any endpoint receiving any certificate which it would need to
>> validate using any signature algorithm using an MD5 hash MUST abort
>> the handshake with a
On Wed, 16 Apr 2025 09:46:59 GMT, Rohitash Kumar wrote:
>> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
>> e.g., https://.x.y/
>> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
>> `parseIPv4Address` uses `NumberFormatException` fo
On Tue, 15 Apr 2025 09:28:05 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnectio
On Thu, 10 Apr 2025 05:47:09 GMT, Volkan Yazici wrote:
> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
@vy
Your change (at version 4385b04466227cacdc9d58e9f6cd1f55968b0e27) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/
On Thu, 10 Apr 2025 05:52:07 GMT, Volkan Yazici wrote:
>> Overhauls `EmptyAuthenticate` to
>>
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related
>> problems
>
> Volkan Yaz
On Tue, 8 Apr 2025 12:33:52 GMT, serhiysachkov wrote:
> Remove extra args to System.out.printf in open/test/jsk/java/net/httpclient
> tests
@serhiysachkov
Your change (at version 8dea22e4088f5f09cecb4886d50b0b41a28a0411) is now ready
to be sponsored by a Committer.
-
PR Comment:
On Fri, 4 Apr 2025 09:13:30 GMT, Daishi Tabata wrote:
>> The output `jwebserver` and `java -m jdk.httpserver` uses UTF-8 encoding.
>> Therefore, if the console encoding is not set to UTF-8 (for example, MS932
>> on Japanese Windows), garbled characters may appear.
>> Since System.out knows the
On Sat, 29 Mar 2025 17:27:20 GMT, Patrick Strawderman wrote:
> Use `HexFormat.fromHexDigits` in URLDecoder, instead of `Integer.parseInt`.
@kilink
Your change (at version 64ddccdaeeaec4e1196976d3c5f4c329008dd4ef) is now ready
to be sponsored by a Committer.
-
PR Comment: https://
On Mon, 31 Mar 2025 10:35:55 GMT, serhiysachkov wrote:
> 8330598: java/net/httpclient/Http1ChunkedTest.java fails with
> java.util.MissingFormatArgumentException: Format specifier '%s'
@serhiysachkov
Your change (at version 9abbaf2e4849ef4a6c06e244ccd31ce4af03ab80) is now ready
to be sponsore
On Fri, 31 Jan 2025 09:47:35 GMT, Fabian Meumertzheim wrote:
> `URLClassPath` called into `ParseUtil.fileToEncodedURL`, which misencoded
> characters with a four byte UTF-8 representation. Replacing that function
> with `toPath().toUri().toURL()` (and removing it, since its only used once)
> r
On Tue, 25 Mar 2025 09:49:24 GMT, Volkan Yazici wrote:
>> Guards against multi-deletes in `UnixSocketChannelReadWrite`.
>>
>> The fix can be verified as follows:
>>
>>
>> make build-microbenchmark
>> build/linux-x64/jdk/bin/java \
>> -jar build/linux-x64/images/test/micro/benchmarks.jar \
>>
On Wed, 15 Jan 2025 13:21:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which updates the
> `test/jdk/java/net/DatagramSocket/InterruptibleDatagramSocket.java` to match
> the specified behaviour of `DatagramSocket.receive()` method?
>
> This test was introduc
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Mon, 10 Feb 2025 11:47:25 GMT, Xiaolong Peng wrote:
>> java.net.URI.scanIPv4Address is a private method, it is only called by
>> java.net.URI.takeIPv4Address and java.net.URI.parseIPv4Address, the
>> URISyntaxException("Malformed IPv4 address") is not necessary, returning -1
>> should be go
On Wed, 5 Mar 2025 10:42:29 GMT, serhiysachkov wrote:
>> switching to nanoTime as suggested in ticket comments
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8281511: updating TcpTest to use new checkIfTimeOut method inst
On Fri, 28 Feb 2025 12:50:15 GMT, Volkan Yazici wrote:
> Fixes deletion of non-existent (i.e., already-deleted) files in
> `SocketChannelConnectionSetup`. Confirmed the fix using
>
>
> make build-microbenchmark
> build/linux-x64/jdk/bin/java \
> -jar build/linux-x64/images/test/micro/benchma
On Thu, 20 Feb 2025 14:31:38 GMT, Volkan Yazici wrote:
> Updates `HttpClientImpl.DelegatingExecutor` to resort to the fallback
> executor only on `RejectedExecutionException`. `DelegatingExecutorTest` is
> added to verify the behavior of `DelegatingExecutor`. `tier1,2` reports are
> attached t
On Mon, 2 Dec 2024 13:53:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this minor enhancement to the error text that is
> reported if the `getaddrinfo()` native call returns the `EAI_SYSTEM` error?
> This addresses https://bugs.openjdk.org/browse/JDK-8227493.
>
> The `java.net.Ine
On Fri, 22 Nov 2024 10:55:37 GMT, Eirik Bjørsnøs wrote:
> Can I get a review of this test-only cleanup/speedup PR which modernizes the
> test `RemoveJar.java`.
>
> This test attempts a variety of class loading scenarios on a URLClassLoader
> and verifies that when the loader is closed, it has
On Wed, 12 Feb 2025 09:16:51 GMT, Volkan Yazici wrote:
>> Add tests verifying the behavior of `limiting()` factory methods (introduced
>> in JDK-8328919) of `HttpResponse` on misbehaving Reactive Streams operators
>> that throw exceptions.
>
> Volkan Yazici has updated the pull request with a n
On Tue, 11 Feb 2025 11:46:44 GMT, Volkan Yazici wrote:
>> Fixes stream cancellation in `Http2Connection::putStream`. See comments in
>> the ticket for details on the issue. `tier1,2` results are attached to the
>> ticket too.
>
> Volkan Yazici has updated the pull request incrementally with two
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
>> tracked by git:
>>
>>
On Tue, 4 Feb 2025 12:22:28 GMT, Volkan Yazici wrote:
>> Adds `HttpRequest.Builder::copy` tests to `HttpRequestBuilderTest`.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix `assertEquals()` argument order
@vy
Your ch
On Wed, 22 Jan 2025 15:58:22 GMT, Volkan Yazici wrote:
>> Adds `limiting()` factory methods to
>> `HttpResponse.Body{Handlers,Subscribers}` to handle excessive server input
>> in `HttpClient`. I would appreciate your input whether `discardExcess`
>> should be kept or dropped. I plan to file a
On Thu, 16 Jan 2025 19:03:48 GMT, Volkan Yazıcı wrote:
> Hardens `URI` build in `AbstractConnectTimeoutHandshake`, which is extended
> by both `ConnectTimeoutHandshakeSync` and `ConnectTimeoutHandshakeAsync`.
@vy
Your change (at version a7559023d66c7d511f4901b24d3502eeb05a3a79) is now ready
t
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Mon, 18 Nov 2024 16:11:13 GMT, Nicolas Henneaux wrote:
> 8346705: Use configured SNI from
> java.net.http.HttpClient.Builder#sslParameters#ServerNames in addition of the
> detected SNI from the URL
This pull request has been closed without being integrated.
-
PR: https://git.o
On Mon, 23 Dec 2024 13:59:14 GMT, Volkan Yazıcı wrote:
>> Cleans up `sun.net.www.MimeTable`:
>>
>> * Removes unused methods & variables
>> * Removes commented out code
>> * Simplifies iterations over arrays
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commi
On Mon, 16 Dec 2024 09:24:16 GMT, Volkan Yazıcı wrote:
>> [JDK-8343791](https://bugs.openjdk.org/browse/JDK-8343791) modified
>> `Socket::connect` to throw `UHE` on unresolved addresses – merged in #22160.
>> As reported in [JDK-8346017](https://bugs.openjdk.org/browse/JDK-8346017),
>> this re
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Tue, 3 Dec 2024 21:15:55 GMT, Volkan Yazıcı wrote:
>> Removes `SecurityManager` and friends from `jdk.httpserver`. Successful
>> `tier1..2` results are attached to the ticket.
>>
>> **Methodology:** Case-insensitively and recursively searched for the
>> occurrences of `("removal"|secu|privi
On Mon, 2 Dec 2024 08:12:32 GMT, Volkan Yazıcı wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close
>> the `Socket` in the event that the connection cannot be established, the
>> timeout expires before the connection is established, or the socket address
>> is un
On Fri, 29 Nov 2024 15:04:20 GMT, Volkan Yazıcı wrote:
>> [8343791](https://bugs.openjdk.org/browse/JDK-8343791) (addressed by #22160)
>> stresses that `Socket::connect()` failures should be handled such that the
>> resultant state of the `Socket` and its underlying `SocketImpl` should
>> matc
On Wed, 27 Nov 2024 09:22:54 GMT, Volkan Yazıcı wrote:
>> This change set, addressing
>> [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes
>> `SecurityManager` and friends from
>> `sun.net.www.protocol.ftp.FtpURLConnection`. This is the only leftover from
>> `SM` cleanup in the
On Fri, 22 Nov 2024 08:44:55 GMT, Volkan Yazıcı wrote:
>> Removes `SecurityManager` et al. from `SocksSocketImpl`. `tier2` and `tier3`
>> tests have passed – CI run links are available in the ticket.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since
On Tue, 19 Nov 2024 19:52:25 GMT, Volkan Yazıcı wrote:
> I'd appreciate a review of this change set removing `SecurityManager` et al.
> from `java.net.Socket` and `java.net.ServerSocket`.
@vy
Your change (at version 12944a26f95b7f94a8518270ddf5632bb5b8118e) is now ready
to be sponsored by a C
On Fri, 15 Nov 2024 08:54:38 GMT, Volkan Yazıcı wrote:
>> This PR introduces the following changes addressing intermittent
>> `PlainProxyConnectionTest` failures reported in
>> [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
>>
>> * Increase logging verbosity to aid in troubleshoot
On Wed, 18 Sep 2024 16:05:40 GMT, serhiysachkov wrote:
>> 8339787: Add some additional diagnostic output to
>> java/net/ipv6tests/UdpTest.java
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8339787: updating copyright
@
On Wed, 18 Sep 2024 10:31:59 GMT, serhiysachkov wrote:
> 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
@serhiysachkov
Your change (at version 453749c9b01477139001679a0c5cef35752199cb) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.o
On Wed, 21 Aug 2024 12:45:22 GMT, SendaoYan wrote:
>> Hi,
>> On linux test environments which has docker service, `ifconfig` shows that
>> `docker0` appears to be a virtual ethernet bridge which is created by the
>> docker host. And the `docker0` virtual ethernet bridge may cause test
>> `java
On Thu, 25 Apr 2024 15:49:54 GMT, robert engels wrote:
> improve the HttpExchange api with documented constants and convenience
> methods to avoid common bugs
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/18955
On Thu, 25 Apr 2024 17:20:11 GMT, Matthew Donovan wrote:
> For this PR, I identified TLS tests that can fail due to hard-code
> certificates expiring. I updated those tests to use certificates that are
> generated programmatically. This includes adding some helper methods to the
> CertificateB
On Sun, 26 May 2024 08:22:44 GMT, Lei Zhu wrote:
> Remove setTTL()/getTTL() methods from DatagramSocketImpl/MulticastSocket and
> MulticastSocket.send(DatagramPacket, byte)
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/19404
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 28 Jun 2024 15:36:28 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [f23295ec](https://github.com/openjdk/jdk/commit/f23295ec1dde58d239a2625c9b1645534a2bb625)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Fri, 10 May 2024 01:22:17 GMT, SendaoYan wrote:
>> Hi,
>> The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm
>> options. With -Xcomp jvm options, the jvm consumes a lot of time to compile
>> the java code, but the timeout value is set to 5 second.
>>
>> I think it has 3
On Tue, 12 Mar 2024 10:46:00 GMT, Michael McMahon wrote:
> Hi,
>
> This PR proposes to add simple utility method which returns a simple GET
> HttpRequest in one call. The current builder pattern requires 4 (or 3 since
> GET is the default method) method calls to achieve the same effect.
>
> T
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This do
On Wed, 8 Nov 2023 15:52:13 GMT, Izumi Ryuu wrote:
> 8305839: Add application/sql MIME type for SQL file extension
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/16563
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Thu, 25 May 2023 07:14:19 GMT, Deepa Kumari wrote:
> DatagramSocket delegates to an inner DatagramSocket object. Irrespective of
> whether datagramSocket is IPv4 or IPv6, we create an IPv6 datagramChannel as
> its's delegate. So, This can cause problems with operations like joinGroup.
>
>
On Tue, 4 Apr 2023 19:46:32 GMT, Jonathan Gibbons wrote:
> Please review a doc update to add `@spec` into the rest of the files in
> `java.base` (compared to those in
> [JDK-8305206](https://bugs.openjdk.org/browse/JDK-8305206) PR #13248)
This pull request has been closed without being integra
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote:
> When using HttpClient to make requests to HTTPS resources, there is an issue
> where the entire file is being downloaded into memory without the ability to
> limit the buffer size.
> If the SSLEngine cannot decode the entire buffer due to the alg
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Fri, 5 Aug 2022 14:57:45 GMT, Xue-Lei Andrew Fan wrote:
> This update is to support key exchange named groups customization for
> individual (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.org/browse/JDK-8291950
> RFE: https://bugs.openjdk.org/browse/JDK-8281236
74 matches
Mail list logo
