On Tue, 1 Apr 2025 17:25:00 GMT, Daniel Fuchs wrote:
> Interesting. Please run tier2 tests.
I've run the tier 2 tests locally and they pass.
-
PR Comment: https://git.openjdk.org/jdk/pull/24314#issuecomment-2773910295
On Wed, Apr 2, 2025 at 2:20 PM Alan Bateman wrote:
As a general point, neither method is correct when converting from a
> file URL to a file path. Much of the code here goes back to JDK 1.2 so
> we have to be careful with any changes.
>
Thanks Alan & Daniel.
Yes, I agree that the value of "fixi
On Tue, 1 Apr 2025 19:11:02 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
On 01/04/2025 20:09, Eirik Bjørsnøs wrote:
:
Looking at the Windows implementation of
sun.net.protocol.www.file.Handler, it indeed uses URL::getFile when
constructing the file path, while the unix implementation uses
URL::getPath.
As a general point, neither method is correct when conver
On Tue, 1 Apr 2025 19:11:02 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
On Tue, 1 Apr 2025 19:13:36 GMT, Volkan Yazici wrote:
>> When we close a connection, we take it out of the set. So it's not about
>> ordering the connection but about quickly finding the connection in that set.
>
> It was already a puzzler for me to figure out `id` cannot be used for
> `label`,
On Tue, 1 Apr 2025 19:11:02 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
On Tue, 1 Apr 2025 19:11:02 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
On Wed, 2 Apr 2025 11:01:22 GMT, Jaikiran Pai wrote:
>> It was already a puzzler for me to figure out `id` cannot be used for
>> `label`, and `label` cannot be used for `id` either. Both are due to the
>> fact that `label` can be shared across instances, whereas `id` cannot. In
>> short, I've
On Tue, 1 Apr 2025 19:11:02 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
Hi Eirik,
This is an old API and I suspect the current behavior has
been here from the start. I would prefer not to change
it, unless we really have to.
best regards,
-- daniel
On 01/04/2025 20:09, Eirik Bjørsnøs wrote:
Hi,
*Observation:*
On Unix and Windows respectively, the following code
On Tue, 1 Apr 2025 22:59:07 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/net/URLDecoder.java line 208:
>>
>>> 206: while ( ((i+2) < numChars) &&
>>> 207: (c=='%')) {
>>> 208: int v = HexFormat.fromHexDigits(s,
12 matches
Mail list logo
