Integrated: 8315454: Add a way to create an immutable snapshot of a BitSet

2023-09-04 Thread Per Minborg
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote: > This PR proposes adding a new method to BitSet that provides an immutable > snapshot of the set in the form of an `IntPredicate`. > > The predicate is eligible for constant folding. > > Here are some classes in the JDK that would benefit di

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Jaikiran Pai
On Mon, 4 Sep 2023 16:44:24 GMT, Daniel Fuchs wrote: >> I don't know the history but it is very old code and just to be on safer >> side i did the same changes as per getInputStream0(). Looking from out side >> wrapping the 'RuntimeException' into another 'RuntimeException' not make >> much s

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Vyom Tewari
On Mon, 4 Sep 2023 16:49:39 GMT, Daniel Fuchs wrote: > IIRC the `ProtocolException` here is caught higher in the stack - I believe > that's what the comment `// responseCode will be returned to caller` means. > @DarraghClarke might remember. There is much history here. The fix may appear > sim

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Daniel Fuchs
On Sun, 3 Sep 2023 09:16:24 GMT, Vyom Tewari wrote: >> With the current implementation of HttpURLConnection if server rejects the >> “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will >> be thrown from 'expect100Continue()' method. >> >> After the exception thrown, I

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Daniel Fuchs
On Mon, 4 Sep 2023 08:25:43 GMT, Vyom Tewari wrote: >> src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java >> line 1436: >> >>> 1434: if (rememberedException != null) { >>> 1435: if (rememberedException instanceof RuntimeException) { >>> 1436

Re: RFR: 8308807: [AIX] MulticastSocket and jdp test fails due to joinGroup

2023-09-04 Thread Thomas Obermeier
On Thu, 3 Aug 2023 12:06:33 GMT, Alan Bateman wrote: >> Hi @AlanBateman , >> >> I ran the Jtreg tests on **jdk17** and observed the following tests passed >> unexpectedly when I set the **VM_OPTIONS to >> `-Djdk.net.usePlainDatagramSocketImpl=true`** >> >> 1. java/net/MulticastSocket/B6427

Re: RFR: 8315454: Add a way to create an immutable snapshot of a BitSet [v5]

2023-09-04 Thread Per Minborg
> This PR proposes adding a new method to BitSet that provides an immutable > snapshot of the set in the form of an `IntPredicate`. > > The predicate is eligible for constant folding. > > Here are some classes in the JDK that would benefit directly from > constant-folding of BitSets: > > PoolR

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Vyom Tewari
On Sun, 3 Sep 2023 09:16:24 GMT, Vyom Tewari wrote: >> With the current implementation of HttpURLConnection if server rejects the >> “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will >> be thrown from 'expect100Continue()' method. >> >> After the exception thrown, I

Re: RFR: 8315454: Add a way to create an immutable snapshot of a BitSet [v4]

2023-09-04 Thread Claes Redestad
On Mon, 4 Sep 2023 06:54:40 GMT, Per Minborg wrote: >> This PR proposes adding a new method to BitSet that provides an immutable >> snapshot of the set in the form of an `IntPredicate`. >> >> The predicate is eligible for constant folding. >> >> Here are some classes in the JDK that would bene

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Vyom Tewari
On Mon, 4 Sep 2023 07:22:46 GMT, Jaikiran Pai wrote: >> Vyom Tewari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> modified the junit tests names > > src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java > line 1

Re: RFR: 8314877: Make fields final in 'java.net' package [v2]

2023-09-04 Thread Jaikiran Pai
On Wed, 23 Aug 2023 11:04:14 GMT, Andrey Turbanov wrote: >> A few classes in `java.net` package have non-final fields which could easily >> be marked `final`. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8314877: Mak

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Jaikiran Pai
On Sun, 3 Sep 2023 09:16:24 GMT, Vyom Tewari wrote: >> With the current implementation of HttpURLConnection if server rejects the >> “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will >> be thrown from 'expect100Continue()' method. >> >> After the exception thrown, I

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Jaikiran Pai
On Sun, 3 Sep 2023 09:16:24 GMT, Vyom Tewari wrote: >> With the current implementation of HttpURLConnection if server rejects the >> “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will >> be thrown from 'expect100Continue()' method. >> >> After the exception thrown, I

Re: RFR: 8314978: Multiple server call from connection failing with expect100 in getOutputStream [v2]

2023-09-04 Thread Jaikiran Pai
On Sun, 3 Sep 2023 09:16:24 GMT, Vyom Tewari wrote: >> With the current implementation of HttpURLConnection if server rejects the >> “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will >> be thrown from 'expect100Continue()' method. >> >> After the exception thrown, I