On Wed, 5 Apr 2023 16:45:06 GMT, Jonathan Gibbons wrote:
>> Please review a doc update to add `@spec` into the rest of the files in
>> `java.base` (compared to those in
>> [JDK-8305206](https://bugs.openjdk.org/browse/JDK-8305206) PR #13248)
>
> Jonathan Gibbons has updated the pull request inc
On Thu, 6 Apr 2023 19:31:32 GMT, Sean Mullan wrote:
> There are references to other specifications missing, like NIST Special
> Publication 800-90A Revision 1, referenced in `java.security.DrbgParameters`.
> I think there are others, I haven't done a thorough review yet. Will there be
> subseq
On Tue, 11 Apr 2023 13:46:16 GMT, Daniel Fuchs wrote:
> The HttpClient close tests could be improved to provide better diagnosis.
>
> The tests make some requests and register some dependent actions to check the
> response state, followed by some dependent action that will read the request
>
On Tue, 11 Apr 2023 13:46:16 GMT, Daniel Fuchs wrote:
> The HttpClient close tests could be improved to provide better diagnosis.
>
> The tests make some requests and register some dependent actions to check the
> response state, followed by some dependent action that will read the request
>
On Tue, 11 Apr 2023 13:46:16 GMT, Daniel Fuchs wrote:
> The HttpClient close tests could be improved to provide better diagnosis.
>
> The tests make some requests and register some dependent actions to check the
> response state, followed by some dependent action that will read the request
>
On Thu, 13 Apr 2023 07:42:31 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java
>> line 229:
>>
>>> 227: this.realm = realm;
>>> 228: this.path = null;
>>> 229: this.authcache = acache == null ? defCache : acache;
On Thu, 13 Apr 2023 11:30:15 GMT, Daniel Fuchs wrote:
>> That structure is not related to this change though. Previously, the value
>> added itself to the single static cache, but now to add itself, it needs a
>> reference to the cache instance. We could certainly reorganise this code,
>> but
Can I please get a review of this change which proposes to fix the issue
reported in https://bugs.openjdk.org/browse/JDK-8305906?
As noted in that issue, when IPv6 hosts are involved, the HttpClient on certain
occasions can end up caching the connection with a key which doesn't match with
the k
> Hi,
>
> Can I get a review for this please? This change uses a Cleaner to check when
> java.net.Authenticator instances become unreachable, and then prunes the
> authentication cache for entries that correspond to that Authenticator and
> therefore cannot be used again. This stops the authent
On Wed, 12 Apr 2023 12:36:27 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only changes to the
> `java/net/httpclient/` tests? This addresses
> https://bugs.openjdk.org/browse/JDK-8305900.
>
> As noted in the JBS issue, the changes here update the security policy files
> a
On Wed, 12 Apr 2023 12:36:27 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only changes to the
> `java/net/httpclient/` tests? This addresses
> https://bugs.openjdk.org/browse/JDK-8305900.
>
> As noted in the JBS issue, the changes here update the security policy files
> a
On Wed, 12 Apr 2023 11:58:44 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - error in test
>> - Jai's review
>
> src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java
12 matches
Mail list logo
