Re: RFR: 8298498: sun/net/www/http/KeepAliveCache/B8291637.java fails with "Server exception terminating: java.net.SocketException: Socket closed"

2022-12-13 Thread Jaikiran Pai
On Tue, 13 Dec 2022 10:34:16 GMT, Daniel Jeliński wrote: > This patch attempts to address a rare test failure where read from a socket > succeeds immediately after sending the response. > > The existing `readRequest` method did not verify if it received the entire > request. The method `readOn

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body [v2]

2022-12-13 Thread Michal Karm Babacek
> According to > [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the > close frame MAY contain a body, i.e. it is considered > [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It seems that > the contemporary JDK HEAD (tip) does populate the body and thus enab

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Michal Karm Babacek
On Tue, 13 Dec 2022 14:04:00 GMT, Michal Karm Babacek wrote: >> Checking the response URI is good but for the mainline I'd advise to check >> both the response URI and the body. It's fine to not check the response body >> on the update releases where >> [JDK-8240666](https://bugs.openjdk.org/b

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Severin Gehwolf
On Tue, 13 Dec 2022 14:04:00 GMT, Michal Karm Babacek wrote: >> Checking the response URI is good but for the mainline I'd advise to check >> both the response URI and the body. It's fine to not check the response body >> on the update releases where >> [JDK-8240666](https://bugs.openjdk.org/b

Re: RFR: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"

2022-12-13 Thread Michael McMahon
On Tue, 13 Dec 2022 13:57:30 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPTestClient.java >> line 53: >> >>> 51: try { >>> 52: Thread.sleep(500); >>> 53: } catch (InterruptedException iex) { >> >> If it only fails

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Michal Karm Babacek
On Tue, 13 Dec 2022 10:42:12 GMT, Daniel Fuchs wrote: > Checking the response URI is good but for the mainline I'd advise to check > both the response URI and the body. It's fine to not check the response body > on the update releases where > [JDK-8240666](https://bugs.openjdk.org/browse/JDK-8

Re: RFR: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"

2022-12-13 Thread Daniel Fuchs
On Tue, 13 Dec 2022 13:50:30 GMT, Michael McMahon wrote: >> The test has been observed failing once in the CI, on windows, with a >> BindException (address already in use) on the client side. This usually >> means that the system has run out of ephemeral ports or file descriptors. >> The propo

Re: RFR: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"

2022-12-13 Thread Michael McMahon
On Mon, 12 Dec 2022 14:50:21 GMT, Daniel Fuchs wrote: > The test has been observed failing once in the CI, on windows, with a > BindException (address already in use) on the client side. This usually means > that the system has run out of ephemeral ports or file descriptors. The > proposed fix

Re: RFR: 8298498: sun/net/www/http/KeepAliveCache/B8291637.java fails with "Server exception terminating: java.net.SocketException: Socket closed"

2022-12-13 Thread Daniel Fuchs
On Tue, 13 Dec 2022 10:34:16 GMT, Daniel Jeliński wrote: > This patch attempts to address a rare test failure where read from a socket > succeeds immediately after sending the response. > > The existing `readRequest` method did not verify if it received the entire > request. The method `readOn

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Daniel Fuchs
On Fri, 2 Dec 2022 15:55:30 GMT, Michal Karm Babacek wrote: > According to > [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the > close frame MAY contain a body, i.e. it is considered > [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It seems that > the co

RFR: 8298498: sun/net/www/http/KeepAliveCache/B8291637.java fails with "Server exception terminating: java.net.SocketException: Socket closed"

2022-12-13 Thread Daniel Jeliński
This patch attempts to address a rare test failure where read from a socket succeeds immediately after sending the response. The existing `readRequest` method did not verify if it received the entire request. The method `readOneRequest` (copied from other tests) makes sure that we read the trai

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Severin Gehwolf
On Fri, 2 Dec 2022 15:55:30 GMT, Michal Karm Babacek wrote: > According to > [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the > close frame MAY contain a body, i.e. it is considered > [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It seems that > the co

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Severin Gehwolf
On Mon, 5 Dec 2022 06:52:36 GMT, Jaikiran Pai wrote: > Hello @Karm, > > > According to > > [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the > > close frame MAY contain a body, i.e. it is considered > > [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It s

RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Michal Karm Babacek
According to [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the close frame MAY contain a body, i.e. it is considered [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It seems that the contemporary JDK HEAD (tip) does populate the body and thus enables `Hand

Re: RFR: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

2022-12-13 Thread Jaikiran Pai
On Fri, 2 Dec 2022 15:55:30 GMT, Michal Karm Babacek wrote: > According to > [rfc6455](https://www.rfc-editor.org/rfc/rfc6455.html#section-5.5.1), the > close frame MAY contain a body, i.e. it is considered > [optional](https://www.rfc-editor.org/rfc/rfc2119#section-5). It seems that > the co