RFR JDK-8240921: Minor correction to HttpResponse.BodySubscribers example

2020-03-19 Thread rahul . r . yadav
Hello,  Can I please have my fix reviewed for issue JDK-8240921 - Minor correction to HttpResponse.BodySubscribers example?  The fix updates the incorrect example of the usage of the class java.net.http.HttpResponse.BodySubscribers.The patch also updates the test case for this scenario.  I

RFR JDK-8240921: Minor correction to HttpResponse.BodySubscribers example

2020-03-19 Thread rahul . r . yadav
Hello,  Can I please have my fix reviewed for issue JDK-8240921 - Minor correction to HttpResponse.BodySubscribers example?  The fix updates the incorrect example of the usage of the class java.net.http.HttpResponse.BodySubscribers.The patch also updates the test case for this scenario.  I

RFR JDK-8240921: Minor correction to HttpResponse.BodySubscribers example

2020-03-19 Thread rahul . r . yadav
Hello,  Can I please have my fix reviewed for issue JDK-8240921 - Minor correction to HttpResponse.BodySubscribers example?  The fix updates the incorrect example of the usage of the class java.net.http.HttpResponse.BodySubscribers.The patch also updates the test case for this scenario.  I

RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-26 Thread rahul . r . yadav
Hello, Request to have my fix reviewed for issues:     JDK-8239595 : ssl context version is not respected     JDK-8239594 : jdk.tls.client.protocols is not respected The fix updates jdk.internal.net.http.HttpClientImpl.getDefaultParams(SSLContext ctx) to use ctx.getDefaultSSLParameters()instea

Re: RFR JDK-8239595/JDK-8239594 : ssl context version is not respected/jdk.tls.client.protocols is not respected

2020-03-30 Thread rahul . r . yadav
The current fix does not affect the scenarios discussed earlier(that is a broader discussion,may be a different bug/enhancement). The scenarios would be vaild even if the fix would not have been in place. -Rahul On 27/03/2020 17:50, Chris Hegarty wrote: Thank you for these clarifications. We wi

Re: RFR 8240666: Websocket client’s OpeningHandshake discards the HTTP response body

2020-05-06 Thread rahul . r . yadav
Thanks Daniel , webrev updated. - rahul On 06/05/2020 16:16, Daniel Fuchs wrote: Hi Rahul, LGTM.  111 WebSocketHandshakeException wse = (WebSocketHandshakeException) t;  112 out.println("Status code is " + wse.getResponse().statusCode());  113