RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-03 Thread Mark Sheppard
Hi please oblige and review the fix below to address the issue in JDK-8021372: NetworkInterface.getNetworkInterfaces() returns duplicate hardware address http://cr.openjdk.java.net/~msheppar/8021372/webrev/ the handling of the Ipv6IfIndex was suspect when setting the interface index and when ret

Re: RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-03 Thread Mark Sheppard
to me passed index couldn't be 0 so null check is redundant, but I don't mind to keep it. It might make sense to explicitly check passed index for 0 above loop. -Dmitry On 2013-09-03 13:23, Mark Sheppard wrote: Hi please oblige and review the fix below to address the issue in J

RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-04 Thread Mark Sheppard
Hi based on feedback for initial fix, an amended webrev has been created. So, please oblige and review the fix below to address the issue in JDK-8021372: NetworkInterface.getNetworkInterfaces() returns duplicate hardware address webrev: http://cr.openjdk.java.net/~msheppar/8021372/webrev.01/

RFR:JDK-8021372 NetworkInterface.getNetworkInterfaces() returns duplicate hardware address

2013-09-05 Thread Mark Sheppard
thervm mode. 2) remove all exception handling code, and just declare all methods to throw Exception. The jtreg harness will show the test as failed if an unhandled exception is thrown. -Chris. On 04/09/2013 08:59, Mark Sheppard wrote: Hi based on feedback for initial fix, an amended

RFR: JDK-8024675 - java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows

2013-09-13 Thread Mark Sheppard
Hi please oblige and review the webrev below which addresses the issue problem: https://bugs.openjdk.java.net/browse/JDK-8024675 webrev: http://cr.openjdk.java.net/~msheppar/8024675/webrev/ The test has been amended to only consider NetworkInterfaces that are active (i.e. isUp() == true) and

RFR: JDK-6458027 - Disabling IPv6 on a specific network interface causes problems

2013-09-15 Thread Mark Sheppard
Hi please oblige and review the webrev below which addresses the issue problem: https://bugs.openjdk.java.net/browse/JDK-6458027 webrev: http://cr.openjdk.java.net/~msheppar/6458027/webrev/ the core of the issue is that a windows platform may be IPv6 enabled, but an individual adapter/interf

Re: RFR: JDK-6458027 - Disabling IPv6 on a specific network interface causes problems

2013-09-16 Thread Mark Sheppard
module, but it seems this file contains native code common to both dual stack/two stacks mode. We probably should move this code to a different source file some time, but it might be useful to put a comment in at least to say that it is common to both modes. Michael On 15/09/13 12:34, Mark

Re: RFR: JDK-6458027 - Disabling IPv6 on a specific network interface causes problems

2013-09-16 Thread Mark Sheppard
a comment in at least to say that it is common to both modes. I'm not sure what what code you are referring to here, but as far as I am aware there is no dual stack code in this file. Yes, there is both IPv4 and IPv6, but both should be on separate sockets. -Chris. Michael On

Re: RFR: JDK-6458027 - Disabling IPv6 on a specific network interface causes problems

2013-09-16 Thread Mark Sheppard
yep. Forget that as well. I thought it was being called from common code. So, I'm missing how this code is relevant then on Vista, which should be using the dual stack implementation then ? Michael -Chris. Michael On 15/09/13 12:34, Mark Sheppard wrote: Hi please oblige and

<    1   2   3