Thanks Tristan for following up with this!
-Kurchi
> On Oct 22, 2013, at 5:28 AM, Chris Hegarty wrote:
>
> Thanks Tristan.
>
> Given your clarifications, I will push this change for you.
>
> -Chris.
>
>> On 22/10/2013 13:13, Tristan Yan wrote:
>> Hi Chris
>> Have you verified Kurchi's chang
That is fine with me.
Thanks,
Kurchi
On 10/19/11 8:48 AM, Chris Hegarty wrote:
Michael, Kurchi,
java/net/DatagramSocket/ChangingAddress.java was added recently in
JDK8, see CR 7084030. Looking at it again I'm not sure if the test
makes sense, or at least we would have to loosen its restricti
That is fine with me. Can I remove the test as a part of fixing 7102704?
Thanks,
Kurchi
On 10/19/11 8:48 AM, Chris Hegarty wrote:
Michael, Kurchi,
java/net/DatagramSocket/ChangingAddress.java was added recently in
JDK8, see CR 7084030. Looking at it again I'm not sure if the test
makes sense
Changeset: 8f61ac5986ee
Author:khazra
Date: 2012-03-02 13:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f61ac5986ee
7146763: Warnings cleanup in the sun.rmi and related packages
Summary: Cleanup warnings and use jkd7 features in sun.rmi.*
Reviewed-by: smarks, chegar, for
Changeset: ce6b852bf4e2
Author:khazra
Date: 2012-03-05 17:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce6b852bf4e2
7151348: Build breaks due to warning clean up in sun.rmi.*(7146763)
Summary: Undo changes to sun/rmi/rmic/* commited as fix for 7146763
Reviewed-by: smarks
Changeset: 3bfebedb549f
Author:khazra
Date: 2012-03-15 13:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bfebedb549f
7045655: An empty InMemoryCookieStore should not return true for removeAll
Summary: CookieStore.removeAll() should return false for an empty CookieStore
Re
Changeset: 337d4570b8d6
Author:khazra
Date: 2012-03-16 11:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/337d4570b8d6
7152007: Fix warnings in sun/rmi/rmic
Summary: Minor code changes to remove warnings in sun/rmi/rmic
Reviewed-by: chegar, smarks
! src/share/classes/sun/r
I think the HTTP spec needs an http server to handle LF gracefully,
although it expects a CRLF, and that is how this is working.
It is a small change, I will anyway correct it.
- Kurchi
On 4/17/12 3:24 AM, Chris Hegarty wrote:
On 16/04/12 22:18, Kurchi Hazra wrote:
Hi,
Thanks for the review
Changeset: 31c15e2f51ba
Author:khazra
Date: 2012-04-17 11:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31c15e2f51ba
7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows
Summary: Remove usage of HTTP Server at test/sun/net/www/httptest
Reviewed-by:
Changeset: 1757f049e8c0
Author:khazra
Date: 2012-04-17 12:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1757f049e8c0
7157893: Warnings Cleanup in java.util.*
Summary: Minor code changes to cleanup warnings in java.util.*
Reviewed-by: mduigou, naoto, smarks
Contributed-by:
Changeset: bc51d0569ccd
Author:khazra
Date: 2012-04-19 13:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc51d0569ccd
7162385: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing again
Summary: Enable finding "foo1.jar"
Reviewed-by: chegar
! test/sun/net/www/protocol
Changeset: 715f50872ae7
Author:khazra
Date: 2012-04-19 18:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/715f50872ae7
7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on
WLAN
Summary: Update Windows native code to infer WLAN interface type in Win
Changeset: fcdbd1f34309
Author:khazra
Date: 2012-04-24 14:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcdbd1f34309
7144274: [macosx] Default IPv6 multicast interface is not being set when
calling MulticastSocket.joinGroup()
Summary: Get default interface for Mac OS X w
Changeset: 3e398b549cea
Author:khazra
Date: 2012-04-25 12:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e398b549cea
7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx]
Summary: Insert null check of argument in remove()'s implementation
Reviewed-by: fora
Changeset: 108a02a57b75
Author:khazra
Date: 2012-04-26 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/108a02a57b75
7118100: (prefs) Inconsistency when using system and user preference on OSX Lion
Summary: Enable user to read/write preferences to persistent storage
Revie
Changeset: 59121a4c71c6
Author:khazra
Date: 2012-05-09 11:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59121a4c71c6
7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE
Summary: Insert null argument check in AbstractPreferences.remove()
Reviewed-by: dholm
Changeset: 5152c832745a
Author:khazra
Date: 2012-05-09 16:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5152c832745a
7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured
non-blocking
Summary: Set localAddress only when connection is established
Changeset: 9a18e318f95a
Author:khazra
Date: 2012-05-15 11:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a18e318f95a
7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs
Summary: Remove rawtype usages and other code cleanup
Reviewed-by: chegar, briangoetz
! src/ma
Changeset: 0c3d9050c918
Author:khazra
Date: 2012-05-23 10:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918
7170169: (props) System.getProperty("os.name") should return "Windows 8" when
run on Windows 8
Summary: Enable Windows Version 6.2 to be recognized as Win
Changeset: eb441933f6fe
Author:khazra
Date: 2012-05-29 13:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb441933f6fe
7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c
should return a value
Summary: Use CHECK_NULL_RETURN instead of CHECK_NULL
Revie
Changeset: af313ded4ffb
Author:khazra
Date: 2012-06-06 11:37 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af313ded4ffb
7173645: (props) System.getProperty("os.name") should return "Windows Server
2012" for Windows Server 2012
Summary: Enable Windows Server 2012 to be recog
Hi,
Currently HttpURLConnection.setRequestProperty() does not
document that it can throw an IllegalArgumentException. However, this method
does
throw an IAE if the key or value contains illegal characters. The same applies
for HttpURLConnection.addRequestProperty(), and this webrev tries to a
Changeset: e9461aeff91f
Author:khazra
Date: 2012-07-13 16:02 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e9461aeff91f
7160252: (prefs) NodeAddedEvent was not delivered when new node add when new
Node
Summary: Change native code to convey to Java code whether a new node wa
Changeset: 1469be7182b4
Author:khazra
Date: 2012-07-16 16:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1469be7182b4
7177045: Rework the TestProviderLeak.java regression test, it is too fragile to
low memory errors.
Summary: Increase Xmx to 20 MB and add mechanisms to ea
I have read the sections dealing with cookie-name in 6265, and these
changes look good to me.
- Kurchi
On 7/17/12 7:32 AM, Michael McMahon wrote:
Thanks for reviewing this Chris. On the question of whether $ should
be allowed
in cookie names, it appears like that restriction has been removed
Changeset: 773474da570b
Author:khazra
Date: 2012-07-18 15:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/773474da570b
7185051: Remove TestProviderLeak.java from the ProblemList
Summary: Remove TestProviderLeak.java from jdk test problem list.
Reviewed-by: khazra
Contribute
Changeset: 74ceda3a98a0
Author:khazra
Date: 2012-07-24 13:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74ceda3a98a0
7184287: (prefs) BackingStoreException when calling flush on root node[macosx]
Summary: Change implementation to enable user without administrative privile
- HttpClient createClient() -- is this the same as
HttpClientProvider.provider().createAsynchronousHttpClient()?
yes, and that needs to be documented.
Just on this one, the method name createAsynchronousHttpClient() looks
like a remnant of our previous API iterations, and I think this
should
Just as a reminder, for reading the response, we had originally decided to
simply terminate whatever bytebuffer/byte arrays we have with a -1 to
indicate
EOF. But if returning the number of bytes read results in cleaner code,
maybe we should do this.
HttpResponse::
- getBodyAsBytes(byte[],
Changeset: bd91a601265c
Author:khazra
Date: 2012-08-24 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c
7168172: (fs) Files.isReadable slow on Windows
Summary: Remove DACL checking for read access, also reviewed by
ulf.zi...@cosoco.de, zhong.j...@gmail.com
R
Looks good John. Any particular reason that you renamed HttpServer to
TestHttpServer
but HttpsServer to SimpleHttpsServer?
Thanks,
- Kurchi
On 9/5/12 7:39 AM, John Zavgren wrote:
Greetings:
Please help to review the fix below for bug 6354758:
http://cr.openjdk.java.net/~chegar/6354758/webrev.
Changeset: e143d8f8e477
Author:dxu
Date: 2012-09-18 14:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e143d8f8e477
7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc
page of Package java.util.zip
Summary: Correct a java doc link in java.util.zip
Changeset: 3a6b76a468bd
Author:khazra
Date: 2012-10-16 15:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a6b76a468bd
7198073: (prefs) user prefs not saved [macosx]
Summary: Using class member field to get node instead of argument
Reviewed-by: alanb
! src/macosx/classes/j
Changeset: 0ee09f17361e
Author:khazra
Date: 2012-11-16 12:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ee09f17361e
8003518: (prefs) Tests in jdk/test/java/util/prefs should not be run
concurrently
Summary: Add java/util/prefs to exclusiveAccess.dirs in TEST.ROOT
Review
Changeset: 43d2e02c4098
Author:khazra
Date: 2012-11-30 12:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43d2e02c4098
7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or
by "couldn't get file lock"
Summary: Set -Djava.util.prefs.userRoot to cur
Thanks a lot for your comments David.
On 1/8/13 6:39 PM, David Schlosnagle wrote:
Hi Kurchi,
I had a couple quick comments:
On line 1756, you might want to allocate the StringBuilder normalizedS
= new StringBuilder(s.length()); to avoid resizing during the
appending.
- I am now wondering if I
On 1/8/13 6:55 PM, Vitaly Davidovich wrote:
Also, I'm not sure how hot this method is in practice but allocating
StringBuilder seems a bit heavy (maybe it gets partially escape
analyzed out though). Can you instead loop over all the chars in the
string and build up the hash code as you go al
The change looks ok. You might want to move the comments
on this bug to 8006153 for the sake of book-keeping.
Thanks,
Kurchi
On 1/14/13 2:24 PM, Mark Sheppard wrote:
Hi,
Request for review of JDK-8005406, this time!
This is the second in a series of refactorings which migrate base64 support i
Changeset: e8414d69692c
Author:khazra
Date: 2013-01-17 14:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8414d69692c
7171415: java.net.URI.equals/hashCode not consistent for some URIs
Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed
by vita..
Looks good - I looked into the bug details for the test too, but could
not find any
reason why we would need server and client to bind to consecutive ports.
Thanks,
- Kurchi
On 1/18/13 6:23 AM, Chris Hegarty wrote:
This test can be seen to fail intermittently on a very busy system.
The test
The change looks consistent with what we had already (findResource()
will now silently consume
an UnknownServiceException instead of a NullPointerException for
MailToURLConnection).
Also, I noticed that the test does not fail on Mac OS X even without
the fix - it does fail on Windows
though.
T
/2013 4:42 AM, Chris Hegarty wrote:
On 01/21/2013 08:36 PM, Kurchi Subhra Hazra wrote:
The change looks consistent with what we had already (findResource()
will now silently consume
an UnknownServiceException instead of a NullPointerException for
MailToURLConnection).
Also, I noticed that the test
Changeset: 77bde15bc6a9
Author:khazra
Date: 2013-01-25 11:52 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77bde15bc6a9
7017962: Obsolete link is used in URL class level spec
Summary: Change the link to an archived document
Reviewed-by: chegar, mduigou
! src/share/classes/j
I am wondering why do you need two try-catch blocks here.
- Kurchi
On 3/7/13 8:18 AM, Rob McKenna wrote:
Hi folks,
This is a slight alteration of the fix contributed by Stuart Douglas.
This fix deals with a SocketException caused by getSoTimeout() on a
closed connection.
http://cr.openjdk.
On 4/2/13 6:27 PM, chris...@zoulas.com wrote:
On Apr 2, 5:26pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote:
-- Subject: Re: DefaultProxySelector socks override
| Also, I should have clarified why I am changing the test. Since now we
| are defining the socks non-proxy property -
| local
So the default non-proxy hosts are localhost|127.*|[::1]|0.0.0.0|[::0].
There can thus be a problem only if the local machine is being used as a
proxy, which will be
unlikely in real environments.
We could go a step further and allow setting socksNonProxyHosts to ""
(an empty string) to overri
Sure Christos, I will include a comment in the test. I should also
include the bug id in the jtreg tag, now
that I am changing the test.
- Kurchi
On 4/3/13 1:22 PM, chris...@zoulas.com wrote:
On Apr 3, 9:15am, kurchi.subhra.ha...@oracle.com (Kurchi Subhra Hazra) wrote:
-- Subject: Re
Alright, thanks, I'll push it today.
- Kurchi
On 4/4/13 1:33 AM, Chris Hegarty wrote:
I'm happy to go with what you have Kurchi.
-Chris.
On 04/04/2013 01:57 AM, Kurchi Subhra Hazra wrote:
So the default non-proxy hosts are localhost|127.*|[::1]|0.0.0.0|[::0].
There can thus be
Changeset: b702977e7212
Author:khazra
Date: 2013-04-05 12:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b702977e7212
5001942: Missings SOCKS support for direct connections
Summary: Add support for socksNonProxyHosts
Reviewed-by: chegar, khazra
Contributed-by: Christos Zou
Hi John,
Minor nit, the formatting around line 101 looks off,
How about something like this:
if {
// remains same
} else {
adapterInfo = adapterInfoTemp;
}
- Kurchi
On 4/19/13 2:33 PM, John Zavgren wrote:
Greetings:
I fixed the bad realloc pattern. Please let me know what you think
On Apr 20, 2013, at 3:16 AM, Dmitry Samersoff
wrote:
> John,
>
> 102, 145 else is redundant.
>
> 438 - we will crash here if start is null
Maybe it is good to have an additional check for start != null, but from what I
see, start will not be null if *netaddrPP is not null.
>
> -Dmi
t stops my eyes.
>
> -Dmitry
>
>
> On 2013-04-20 14:55, Kurchi Subhra Hazra wrote:
>>
>>
>> On Apr 20, 2013, at 3:16 AM, Dmitry Samersoff
>> wrote:
>>
>>> John,
>>>
>>> 102, 145 else is redundant.
>>>
>>&g
Ok, now this is clear to me, which probably indicates that something
like this should be
included in the documentation.
Thanks Michael,
Kurchi
On 4/30/13 3:30 AM, Michael McMahon wrote:
Hi Kurchi,
I can include such an example easily. Eg:
"GET,POST:Header1,Header2"
means one permission that
Hi,
NetworkInterface.getByInetAddress() was crashing on solaris when the system
had a network
interface name longer than 15 characters, due to two instances in the native
code for NetworkInterface where we were copying a char array of size 32
(LIFNAMSIZ)
into a char array of size 16 (IFNAMS
Changeset: 3062bf908281
Author:khazra
Date: 2013-05-02 14:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3062bf908281
8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f
name
Summary: Remove buffer overruns in native code
Reviewed-by: alanb, che
There's something fishy here. So are there are non I/O events queued
up that will not be serviced more quickly? Shouldn't adding events
cause the Selector to wakeup so that it doesn't matter what the
timeout value is.
- This doesn't quite work if we have a single thread doing everything.
Changeset: 86c1e8c799f5
Author:khazra
Date: 2013-05-13 13:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c1e8c799f5
8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive
Summary: Rearrange event-handling code to remove bottle-neck. Also reviewed
Changeset: 790d292ee761
Author:khazra
Date: 2013-05-14 12:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/790d292ee761
6328537: Improve javadocs for Socket class by adding references to SocketOptions
Summary: Insert references to SocketOptions.java where applicable
Reviewed
Changeset: a8be9405bb4b
Author:khazra
Date: 2013-05-16 10:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8be9405bb4b
7150552: network test hangs [macosx]
Summary: Remove usage of test/sun/net/www/httptest
Reviewed-by: chegar
! test/ProblemList.txt
! test/java/net/CookieH
Changeset: 11cdcf87ad5d
Author:jzavgren
Date: 2013-05-31 15:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cdcf87ad5d
8008972: Memory leak: Java_java_net_TwoStacksPlainDatagramSocketImpl_receive0
[parfait]
Summary: Modified the code so that "jumbo frames" are truncated
Changeset: 8b65dfe8f509
Author:khazra
Date: 2013-06-07 10:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b65dfe8f509
7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER
Summary: Return false for null arguments in
ACCEPT_ORIGINAL_SERVER#shouldAcc
Changeset: ff83bd43e36a
Author:khazra
Date: 2013-06-13 11:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff83bd43e36a
8015421: NegativeArraySizeException occurs in ChunkedOutputStream() with
Integer.MAX_VALUE
Summary: Ensure integer overflow does not occur
Reviewed-by: ch
Changeset: 42f9ad39bf42
Author:khazra
Date: 2013-06-13 17:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42f9ad39bf42
7169142: CookieHandler does not work with localhost
Summary: Add .local to derived effective hostnames without dot
Reviewed-by: chegar
! src/share/classes
Changeset: de6b93fd6d23
Author:khazra
Date: 2013-06-19 14:02 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de6b93fd6d23
8016576: Overrides warnings in jdi and jconsole
Summary: Implement hashCode() in classes emitting warnings
Reviewed-by: alanb, chegar
! src/share/classes/
Changeset: e1b18a666f76
Author:khazra
Date: 2013-06-19 14:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1b18a666f76
8016698: Cleanup overrides warning in sun/tools/ClassDeclaration.java
Summary: Override Object.hashCode()
Reviewed-by: alanb, chegar
! src/share/classes/s
Changeset: 2b156531b7eb
Author:arieber
Date: 2013-06-19 17:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b156531b7eb
7025238: HttpURLConnection does not handle URLs with an empty path component.
Summary: Prepend a '/' to file when path is empty
Reviewed-by: chegar, khazr
Hi,
Did anyone have a chance to look at this?
Thanks,
Kurchi
On Thu, Jul 18, 2013 at 4:26 PM, Kurchi Hazra <
kurchi.subhra.ha...@oracle.com> wrote:
> Hi Michael,
>
>I added some comments as to what is the purpose of the latches and
> barriers. Those comments alongwith the
> comments descri
I guess we could have changed class Server to implement AutoCloseable too,
but this looks fine to me.
Thanks,
- Kurchi
On Wed, Aug 21, 2013 at 6:37 AM, Mark Sheppard wrote:
> Hi
> please oblige and review the fix below to address the issue in JDK-8023326
> which makes the test more robust to ce
68 matches
Mail list logo
