hg: jdk8/tl/langtools: 8025050: Doclint doesn't recognize tag

2013-09-24 Thread jonathan . gibbons
Changeset: 96dcb66e6b0a Author:jjg Date: 2013-09-24 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96dcb66e6b0a 8025050: Doclint doesn't recognize tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! test/tools/doclint/html/InlineTags

hg: jdk8/tl/langtools: 8025246: [doclint] doclint is showing error on anchor already defined when it's not

2013-09-24 Thread jonathan . gibbons
Changeset: 503338f16d2b Author:jjg Date: 2013-09-24 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/503338f16d2b 8025246: [doclint] doclint is showing error on anchor already defined when it's not Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Chec

hg: jdk8/tl/langtools: 8025272: doclint needs to check for valid usage of @value tag

2013-09-24 Thread jonathan . gibbons
Changeset: 6a05a713450d Author:jjg Date: 2013-09-24 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a05a713450d 8025272: doclint needs to check for valid usage of @value tag Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/cl

hg: jdk8/tl/langtools: 8002154: [doclint] doclint should check for issues which are errors in javadoc

2013-09-24 Thread jonathan . gibbons
Changeset: 3ae62331a56f Author:jjg Date: 2013-09-24 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae62331a56f 8002154: [doclint] doclint should check for issues which are errors in javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclint/Checker.ja

hg: jdk8/tl/langtools: 8025407: TypeAnnotations does not use Context

2013-09-25 Thread jonathan . gibbons
Changeset: 5043e7056be8 Author:jjg Date: 2013-09-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5043e7056be8 8025407: TypeAnnotations does not use Context Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classe

hg: jdk8/tl/langtools: 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java

2013-09-25 Thread jonathan . gibbons
Changeset: 3d61984b077c Author:jjg Date: 2013-09-25 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d61984b077c 8025412: Add legal header and comments to test/tools/doclint/tidy/util/Main.java Reviewed-by: bpatel ! test/tools/doclint/tidy/util/Main.java ! test/to

hg: jdk8/tl/langtools: 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor

2013-10-04 Thread jonathan . gibbons
Changeset: 2fa6ced325cc Author:jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/p

hg: jdk8/tl/langtools: 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode

2013-10-04 Thread jonathan . gibbons
Changeset: 515d54c1b063 Author:jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main

hg: jdk8/tl/langtools: 8025970: Spurious characters in JavaCompiler

2013-10-04 Thread jonathan . gibbons
Changeset: 3e3c321710be Author:jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java

2013-10-10 Thread jonathan . gibbons
Changeset: f068d235c4f7 Author:jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy ! test/com/sun/javadoc/

hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly

2013-10-14 Thread jonathan . gibbons
Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test

hg: jdk8/tl/langtools: 8026371: "tidy" issues in langtools/src/**/*.html files

2013-10-14 Thread jonathan . gibbons
Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/co

hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail

2013-10-14 Thread jonathan . gibbons
Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/

hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies

2013-10-14 Thread jonathan . gibbons
Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/too

hg: jdk8/tl/langtools: 8026564: import changes from type-annotations forest

2013-10-15 Thread jonathan . gibbons
Changeset: b0c086cd4520 Author:jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdi...@gmail.com, steve.si...@oracle.com ! make/build.properties

hg: jdk8/tl/langtools: 8026704: Build failure with --enable-debug

2013-10-16 Thread jonathan . gibbons
Changeset: d7e155f874a7 Author:jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tool

hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies

2013-10-18 Thread jonathan . gibbons
Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/co

hg: jdk8/tl/langtools: 8025109: Better encapsulation for AnnotatedType

2013-10-20 Thread jonathan . gibbons
Changeset: e5d3cd43c85e Author:jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/com/sun/tools/javac/code/Symbol.j

hg: jdk8/tl/langtools: 8026791: wrong type_path encoded for method_return on an inner class constructor

2013-10-20 Thread jonathan . gibbons
Changeset: ae4f5cb78ebd Author:jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdi...@gmail.com ! src/share/classes/

hg: jdk8/tl/langtools: 2 new changesets

2013-10-22 Thread jonathan . gibbons
Changeset: 351d6808c1a5 Author:jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author:

hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules

2013-11-25 Thread jonathan . gibbons
Changeset: a78f51d6bd5e Author:jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy ! src

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Jonathan Gibbons
On 8/13/20 10:13 AM, Sean Mullan wrote: On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to hav

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-10 Thread Jonathan Gibbons
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy wrote: > I have in mind dozens of improvements all over the code like this one. That sounds scary. Broad updates like these cause unnecessary churn in the codebase, and can make merging and back porting harder. Changes should be discussed ah

RFR: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Jonathan Gibbons
The change is (just) to remove legacy usages of a JDK-private custom tag. - Commit messages: - JDK-8255262: Remove use of legacy custom @spec tag Changes: https://git.openjdk.java.net/jdk/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=814&range=00 Issue: htt

Integrated: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Jonathan Gibbons
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. This pull request has now been integrated. Changeset: 0aa3c925 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/0aa3c925 St

Re: RFR: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed

2020-12-18 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 16:54:59 GMT, Chris Hegarty wrote: > Temporarily revert use of pattern match instanceof construct until > docs-reference is fixed, see JDK-8258657. > > ... > Generating REFERENCE_API javadoc for 21 modules > > if (delegate instanceof ExecutorService service)

RFR: JDK-8262430: doclint warnings in java.base module

2021-02-25 Thread Jonathan Gibbons
Please review some simple doc fixes in the `java.base` module. Two were reported by doclint; the spelling error was detected by the IDE. - Commit messages: - JDK-8262430: doclint warnings in java.base module Changes: https://git.openjdk.java.net/jdk/pull/2734/files Webrev: https:

Integrated: JDK-8262430: doclint warnings in java.base module

2021-02-26 Thread Jonathan Gibbons
On Thu, 25 Feb 2021 22:59:23 GMT, Jonathan Gibbons wrote: > Please review some simple doc fixes in the `java.base` module. Two were > reported by doclint; the spelling error was detected by the IDE. This pull request has now been integrated. Changeset: 3088e1e6 Author:Jonathan G

RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Jonathan Gibbons
Please review some minor doc fixes, for issues found by _doccheck_.There are two kinds of errors that are addressed. 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph. It is not a terminator, to mark the end of a paragraph, or a separator to mark the boundary between

Integrated: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Jonathan Gibbons
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a term

Re: RFR: JDK-8262992: Improve `@see` output [v2]

2021-03-11 Thread Jonathan Gibbons
On Tue, 9 Mar 2021 16:23:26 GMT, Hannes Wallnöfer wrote: >> This changes the output for `@see` tags to a `` structure. A different >> CSS style is used if any of the `@see` tag labels are longer than 30 >> characters or contain a comma. >> >> The layout for the default CSS style is similar to

Re: RFR: JDK-8262992: Improve `@see` output [v2]

2021-03-24 Thread Jonathan Gibbons
On Thu, 11 Mar 2021 15:17:50 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update `@see` tag in class java.security.cert.PKIXRevocationChecker > > Nic

Re: RFR: JDK-8262992: Improve `@see` output [v6]

2021-05-06 Thread Jonathan Gibbons
On Wed, 5 May 2021 15:09:17 GMT, Hannes Wallnöfer wrote: >> This changes the output for `@see` tags to a `` structure. A different >> CSS style is used if any of the `@see` tag labels are longer than 30 >> characters or contain a comma. >> >> The layout for the default CSS style is similar to

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs

2021-10-27 Thread Jonathan Gibbons
On Tue, 19 Oct 2021 13:50:20 GMT, Ludvig Janiuk wrote: > Single-row table was being used for visual effect, but a description list > seems more appropriate. OK, but ... While the basic translation from a single-row table to a definition list looks good, it's not clear you still need the `styl

Re: RFR: JDK-8275518: accessibility issue in Inet6Address docs [v2]

2021-10-28 Thread Jonathan Gibbons
On Thu, 28 Oct 2021 12:11:33 GMT, Ludvig Janiuk wrote: >> Single-row table was being used for visual effect, but a description list >> seems more appropriate. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Removed html f

[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes: https:

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyright

[jdk18] Integrated: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. This pull request has

Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC

2021-12-09 Thread Jonathan Gibbons
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had take

Re: network tests

2008-06-23 Thread Jonathan Gibbons
Alan, I can imagine two possibilities here: 1) pass a system property to each test that defines a config file in properties format that canbe read by any test that needs it 2) allow a new option to main/applet/shell tests that define a config value that will be passed to the test via a syste

hg: jdk7/tl/langtools: 6764226: ListTest fails on javap output with bad characters

2008-10-29 Thread jonathan . gibbons
Changeset: 5ebe90e0afff Author:jjg Date: 2008-10-27 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5ebe90e0afff 6764226: ListTest fails on javap output with bad characters Reviewed-by: darcy ! test/tools/javap/ListTest.java

hg: jdk7/tl/langtools: 6778493: Fix (langtools) ant build to honor fcs MILESTONE setting

2008-12-01 Thread jonathan . gibbons
Changeset: 6210fb7e7544 Author:jjg Date: 2008-12-01 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6210fb7e7544 6778493: Fix (langtools) ant build to honor fcs MILESTONE setting Reviewed-by: ohair Contributed-by: [EMAIL PROTECTED] ! make/Makefile

hg: jdk7/tl/langtools: 6778638: javadoc regression tests require tabs

2008-12-02 Thread jonathan . gibbons
Changeset: 8db0c5fd6e99 Author:jjg Date: 2008-12-02 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8db0c5fd6e99 6778638: javadoc regression tests require tabs Reviewed-by: darcy ! test/com/sun/javadoc/testSourceTab/DoubleTab/C.java ! test/com/sun/javadoc/testSour

hg: jdk7/tl/langtools: 6512707: "incompatible types" after (unrelated) annotation processing

2009-01-07 Thread jonathan . gibbons
Changeset: 7a595d92e252 Author:jjg Date: 2009-01-07 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7a595d92e252 6512707: "incompatible types" after (unrelated) annotation processing Reviewed-by: darcy Contributed-by: pru...@velocitynet.com.au ! src/share/classes/

hg: jdk7/tl/langtools: 6794520: MessageRetriever should be upgraded to use varargs Object...

2009-01-15 Thread jonathan . gibbons
Changeset: 42f9d392159d Author:jjg Date: 2009-01-15 18:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/42f9d392159d 6794520: MessageRetriever should be upgraded to use varargs Object... Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/u

hg: jdk7/tl/langtools: 6794959: add new switch -XDexpectKeys=key, key....

2009-01-19 Thread jonathan . gibbons
Changeset: d0b33fe8e710 Author:jjg Date: 2009-01-19 19:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d0b33fe8e710 6794959: add new switch -XDexpectKeys=key,key Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/c

hg: jdk7/tl/langtools: 6794582: javadoc should read files using a FileManager

2009-01-20 Thread jonathan . gibbons
Changeset: 1bf037016426 Author:jjg Date: 2009-01-20 15:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1bf037016426 6794582: javadoc should read files using a FileManager Reviewed-by: darcy, bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDoc

hg: jdk7/tl/langtools: 6795903: fix latent build warnings in langtools repository

2009-01-20 Thread jonathan . gibbons
Changeset: b4b1f7732289 Author:jjg Date: 2009-01-20 18:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b4b1f7732289 6795903: fix latent build warnings in langtools repository Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/apt/comp/Annota

hg: jdk7/tl/langtools: 6795030: Files in langtools build can be compiled ignoring java.home settings

2009-01-21 Thread jonathan . gibbons
Changeset: d486ac6389d7 Author:jjg Date: 2009-01-21 08:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d486ac6389d7 6795030: Files in langtools build can be compiled ignoring java.home settings Reviewed-by: mcimadamore ! make/build.xml

hg: jdk7/tl/langtools: 6796965: dev-time wrapper script for javac broken

2009-01-22 Thread jonathan . gibbons
Changeset: e6dafbf35355 Author:jjg Date: 2009-01-22 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e6dafbf35355 6796965: dev-time wrapper script for javac broken Reviewed-by: ksrini ! make/build.xml

hg: jdk7/tl/langtools: 6795365: NetBeans projects in langtools repository are not NB6.5-friendly

2009-01-23 Thread jonathan . gibbons
Changeset: e3930187199c Author:jjg Date: 2009-01-23 11:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e3930187199c 6795365: NetBeans projects in langtools repository are not NB6.5-friendly Reviewed-by: mcimadamore ! make/README ! make/build.xml ! make/netbeans/READM

hg: jdk7/tl/langtools: 6176978: current Javadoc's invocation and extension (Doclet) mechanisms are problematic

2009-01-27 Thread jonathan . gibbons
Changeset: 9199b9092f73 Author:jjg Date: 2009-01-27 18:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9199b9092f73 6176978: current Javadoc's invocation and extension (Doclet) mechanisms are problematic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/D

hg: jdk7/tl/langtools: 6595666: fix -Werror

2009-02-06 Thread jonathan . gibbons
Changeset: 9d541fd2916b Author:jjg Date: 2009-02-06 10:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9d541fd2916b 6595666: fix -Werror Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/ma

hg: jdk7/tl/corba: 6809563: corba build in JDK uses invalid bootclasspath for javah

2009-02-26 Thread jonathan . gibbons
Changeset: 9e6c48c2582d Author:jjg Date: 2009-02-26 18:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/9e6c48c2582d 6809563: corba build in JDK uses invalid bootclasspath for javah Reviewed-by: ohair ! make/common/shared/Defs-java.gmk

hg: jdk7/tl/corba: 6810915: Sun proprietary warnings in JDK build

2009-02-26 Thread jonathan . gibbons
Changeset: db35452e8965 Author:jjg Date: 2009-02-26 18:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/db35452e8965 6810915: Sun proprietary warnings in JDK build Reviewed-by: ohair ! make/Makefile ! make/common/shared/Defs-java.gmk

hg: jdk7/tl/jdk: 6810915: Sun proprietary warnings in JDK build

2009-02-26 Thread jonathan . gibbons
Changeset: 4f0b6455a977 Author:jjg Date: 2009-02-26 18:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4f0b6455a977 6810915: Sun proprietary warnings in JDK build Reviewed-by: ohair ! make/common/shared/Defs-java.gmk ! make/docs/Makefile ! make/javax/swing/beaninfo/SwingBe

hg: jdk7/tl/langtools: 6819246: improve support for decoding instructions in classfile library

2009-03-30 Thread jonathan . gibbons
Changeset: 07da2ffbb76b Author:jjg Date: 2009-03-30 15:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/07da2ffbb76b 6819246: improve support for decoding instructions in classfile library Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfile/Code_attribute.

hg: jdk7/tl/langtools: 6817950: refactor ClassReader to improve attribute handling

2009-03-31 Thread jonathan . gibbons
Changeset: 89f67512b635 Author:jjg Date: 2009-03-31 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/89f67512b635 6817950: refactor ClassReader to improve attribute handling Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/s

hg: jdk7/tl/langtools: 6813059: replace use of JavaCompiler.errorCount with shouldContinue

2009-03-31 Thread jonathan . gibbons
Changeset: af10262bd031 Author:jjg Date: 2009-03-31 11:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/af10262bd031 6813059: replace use of JavaCompiler.errorCount with shouldContinue Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.

hg: jdk7/tl/langtools: 6841422: classfile: add Type visitor

2009-05-19 Thread jonathan . gibbons
Changeset: b5872f0790e7 Author:jjg Date: 2009-05-19 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b5872f0790e7 6841422: classfile: add Type visitor Reviewed-by: mcimadamore Contributed-by: kevin.t.loo...@sun.com ! src/share/classes/com/sun/tools/classfile/Type.j

hg: jdk7/tl/langtools: 6841420: classfile: add new methods to ConstantClassInfo

2009-05-19 Thread jonathan . gibbons
Changeset: f838537fb1ac Author:jjg Date: 2009-05-19 11:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f838537fb1ac 6841420: classfile: add new methods to ConstantClassInfo Reviewed-by: mcimadamore Contributed-by: kevin.t.loo...@sun.com ! src/share/classes/com/sun/to

hg: jdk7/tl/langtools: 6841419: classfile: add constant pool iterator

2009-05-19 Thread jonathan . gibbons
Changeset: fc634a593812 Author:jjg Date: 2009-05-19 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fc634a593812 6841419: classfile: add constant pool iterator Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/cl

hg: jdk7/tl/langtools: 6824493: experimental support for additional info for instructions

2009-05-19 Thread jonathan . gibbons
Changeset: cd0630109de5 Author:jjg Date: 2009-05-19 11:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cd0630109de5 6824493: experimental support for additional info for instructions Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/StackMapTable_a

hg: jdk7/tl/langtools: 6843013: missing files in fix for 6824493

2009-05-19 Thread jonathan . gibbons
Changeset: 0c6cd88f72b9 Author:jjg Date: 2009-05-19 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0c6cd88f72b9 6843013: missing files in fix for 6824493 Reviewed-by: darcy + src/share/classes/com/sun/tools/javap/LocalVariableTableWriter.java + src/share/classes/

hg: jdk7/tl/langtools: 6832154: refactor Paths to be just a utility class for JavacFileManager

2009-05-19 Thread jonathan . gibbons
Changeset: 4ce1c1400334 Author:jjg Date: 2009-05-19 15:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ce1c1400334 6832154: refactor Paths to be just a utility class for JavacFileManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/s

hg: jdk7/tl/langtools: 6827026: Change javac source and target default to 7

2009-05-20 Thread jonathan . gibbons
Changeset: 79eb8795a1de Author:jjg Date: 2009-05-20 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/79eb8795a1de 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml ! src/share/cla

hg: jdk7/tl/corba: 6827026: Change javac source and target default to 7

2009-05-20 Thread jonathan . gibbons
Changeset: 2752d8bd4142 Author:jjg Date: 2009-05-20 13:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/2752d8bd4142 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile

hg: jdk7/tl/jaxp: 6827026: Change javac source and target default to 7

2009-05-20 Thread jonathan . gibbons
Changeset: bdaf6acaf6e3 Author:jjg Date: 2009-05-20 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bdaf6acaf6e3 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml

hg: jdk7/tl/jaxws: 6827026: Change javac source and target default to 7

2009-05-20 Thread jonathan . gibbons
Changeset: 605e1cdeba48 Author:jjg Date: 2009-05-20 13:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/605e1cdeba48 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Makefile ! make/build.properties ! make/build.xml

hg: jdk7/tl/jdk: 6827026: Change javac source and target default to 7

2009-05-20 Thread jonathan . gibbons
Changeset: 1bc5be8665cc Author:jjg Date: 2009-05-20 13:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bc5be8665cc 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-java.gmk ! mak

hg: jdk7/tl: 6827026: Change javac source and target default to 7

2009-05-20 Thread jonathan . gibbons
Changeset: 54d14906940b Author:jjg Date: 2009-05-20 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/54d14906940b 6827026: Change javac source and target default to 7 Reviewed-by: darcy, ohair ! make/Defs-internal.gmk

hg: jdk7/tl/langtools: 6843648: tools/javac/versions/check.sh is broken

2009-05-20 Thread jonathan . gibbons
Changeset: 44eaac2b4501 Author:jjg Date: 2009-05-20 19:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/44eaac2b4501 6843648: tools/javac/versions/check.sh is broken Reviewed-by: darcy ! test/tools/javac/6341866/Anno.java ! test/tools/javac/6464451/BigFinally.java ! t

hg: jdk7/tl/langtools: 6802102: unignore @ignored tests where possible

2009-05-28 Thread jonathan . gibbons
Changeset: d4828eba4939 Author:jjg Date: 2009-05-28 09:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d4828eba4939 6802102: unignore @ignored tests where possible Reviewed-by: mcimadamore ! test/tools/javac/T6405099.java ! test/tools/javac/api/6431257/T6431257.java

hg: jdk7/tl/jdk: 6838199: remove support for old javap

2009-05-29 Thread jonathan . gibbons
Changeset: aece9096d5cd Author:jjg Date: 2009-05-29 16:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aece9096d5cd 6838199: remove support for old javap Reviewed-by: ohair, mcimadamore ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! make/launchers/Ma

hg: jdk7/tl/langtools: 6838199: remove support for old javap

2009-05-29 Thread jonathan . gibbons
Changeset: 47cf04bb80c9 Author:jjg Date: 2009-05-29 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/47cf04bb80c9 6838199: remove support for old javap Reviewed-by: ohair, mcimadamore ! make/build.xml ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/sha

hg: jdk7/tl/langtools: 6852856: javap changes to facilitate subclassing javap for variants

2009-06-19 Thread jonathan . gibbons
Changeset: ed989c347b3c Author:jjg Date: 2009-06-19 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ed989c347b3c 6852856: javap changes to facilitate subclassing javap for variants Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/AccessFlags.ja

hg: jdk7/tl/jdk: 6843077: JSR 308: Annotations on types

2009-06-26 Thread jonathan . gibbons
Changeset: a5f7d97c3f82 Author:jjg Date: 2009-06-26 18:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5f7d97c3f82 6843077: JSR 308: Annotations on types Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.mit.edu

hg: jdk7/tl/langtools: 6843077: JSR 308: Annotations on types

2009-06-26 Thread jonathan . gibbons
Changeset: 03944ee4fac4 Author:jjg Date: 2009-06-26 18:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/03944ee4fac4 6843077: JSR 308: Annotations on types Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.m

hg: jdk7/tl/langtools: 6855544: add missing files

2009-06-26 Thread jonathan . gibbons
Changeset: 664edca41e34 Author:jjg Date: 2009-06-26 19:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/664edca41e34 6855544: add missing files Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m...@csail.mit.edu, mp...@csail.mit.edu + sr

hg: jdk7/tl/langtools: 6854796: update JSR308 impl with latest code from type-annotations repo

2009-06-26 Thread jonathan . gibbons
Changeset: 7c154fdc3547 Author:jjg Date: 2009-06-26 19:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c154fdc3547 6854796: update JSR308 impl with latest code from type-annotations repo Reviewed-by: jjg, mcimadamore, darcy Contributed-by: mer...@cs.washington.edu, m

hg: jdk7/tl/langtools: 6855563: test broken after merge with latest parser

2009-06-27 Thread jonathan . gibbons
Changeset: 464d58654324 Author:jjg Date: 2009-06-27 12:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/464d58654324 6855563: test broken after merge with latest parser Reviewed-by: jjg Contributed-by: m...@csail.mit.edu ! test/tools/javac/typeAnnotations/failures/Old

hg: jdk7/tl/jdk: 6855069: rmic should support v51 class files.

2009-06-29 Thread jonathan . gibbons
Changeset: d926534a1c17 Author:jjg Date: 2009-06-29 16:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d926534a1c17 6855069: rmic should support v51 class files. Reviewed-by: jrose ! src/share/classes/sun/tools/java/RuntimeConstants.java

hg: jdk7/tl/langtools: 6855993: fix comments in langtools launcher script

2009-06-29 Thread jonathan . gibbons
Changeset: 7913e72a24b0 Author:jjg Date: 2009-06-29 17:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7913e72a24b0 6855993: fix comments in langtools launcher script Reviewed-by: ohair ! src/share/bin/launcher.sh-template

hg: jdk7/tl/langtools: 6863814: javap crashes when facing array class literals

2009-07-23 Thread jonathan . gibbons
Changeset: 99b7a25185aa Author:jjg Date: 2009-07-23 11:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/99b7a25185aa 6863814: javap crashes when facing array class literals Reviewed-by: jjg Contributed-by: m...@csail.mit.edu ! src/share/classes/com/sun/tools/classfile

hg: jdk7/tl/langtools: 6863914: bug number missing from test

2009-07-23 Thread jonathan . gibbons
Changeset: 49387c1440d0 Author:jjg Date: 2009-07-23 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/49387c1440d0 6863914: bug number missing from test Reviewed-by: tbell ! test/tools/javap/typeAnnotations/ArrayClassLiterals.java

hg: jdk7/tl/langtools: 6863746: javap should not scan ct.sym by default

2009-07-24 Thread jonathan . gibbons
Changeset: 631425840408 Author:jjg Date: 2009-07-24 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/631425840408 6863746: javap should not scan ct.sym by default Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapFileManager.java ! src/share/cla

hg: jdk7/tl: 6854244: change source/target used to compile JDK to 7

2009-07-27 Thread jonathan . gibbons
Changeset: 59c202ab8a94 Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/59c202ab8a94 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/README.pre-components

hg: jdk7/tl/langtools: 6854244: change source/target used to compile JDK to 7

2009-07-27 Thread jonathan . gibbons
Changeset: cf08b64e87da Author:jjg Date: 2009-07-27 15:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cf08b64e87da 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/build.properties

hg: jdk7/tl/corba: 6854244: change source/target used to compile JDK to 7

2009-07-27 Thread jonathan . gibbons
Changeset: 2a160e4e0d06 Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/2a160e4e0d06 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/Makefile ! make/common/shared/Defs-java.gmk

hg: jdk7/tl/jdk: 6854244: change source/target used to compile JDK to 7

2009-07-27 Thread jonathan . gibbons
Changeset: 15878be84b9d Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15878be84b9d 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs-java.gmk ! make/jav

hg: jdk7/tl/jaxws: 6854244: change source/target used to compile JDK to 7

2009-07-27 Thread jonathan . gibbons
Changeset: c5dfd37d18a0 Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/c5dfd37d18a0 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/build.properties

hg: jdk7/tl/jaxp: 6854244: change source/target used to compile JDK to 7

2009-07-27 Thread jonathan . gibbons
Changeset: 59cdcbf2c10d Author:jjg Date: 2009-07-27 15:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/59cdcbf2c10d 6854244: change source/target used to compile JDK to 7 Reviewed-by: ohair ! make/build.properties

hg: jdk7/tl/langtools: 6865399: some javac files are missing Sun internal API comment

2009-07-27 Thread jonathan . gibbons
Changeset: 7c2d6da61646 Author:jjg Date: 2009-07-27 19:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7c2d6da61646 6865399: some javac files are missing Sun internal API comment Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java

hg: jdk7/tl/langtools: 6855990: javap InstructionDetailWriter should support new 308 annotations attribute

2009-07-28 Thread jonathan . gibbons
Changeset: 777a3efad0d5 Author:jjg Date: 2009-07-28 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/777a3efad0d5 6855990: javap InstructionDetailWriter should support new 308 annotations attribute Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfi

hg: jdk7/tl/langtools: 6734068: Some variable length attributes set their size incorrectly.

2009-07-28 Thread jonathan . gibbons
Changeset: 85b317ac8a0c Author:jjg Date: 2009-07-28 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/85b317ac8a0c 6734068: Some variable length attributes set their size incorrectly. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/CharacterRang

hg: jdk7/tl/langtools: 4777949: Javap Rewrite : Warn javap usage on package classes with simple name.

2009-07-29 Thread jonathan . gibbons
Changeset: c2dfab9e2f39 Author:jjg Date: 2009-07-29 13:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c2dfab9e2f39 4777949: Javap Rewrite : Warn javap usage on package classes with simple name. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapFi

hg: jdk7/tl/langtools: 6866657: add byteLength method to primary classfile types

2009-07-30 Thread jonathan . gibbons
Changeset: 23505e6ea22d Author:jjg Date: 2009-07-30 07:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/23505e6ea22d 6866657: add byteLength method to primary classfile types Reviewed-by: mchung ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/

hg: jdk7/tl/langtools: 4880672: javap does not output inner interfaces of an interface

2009-07-30 Thread jonathan . gibbons
Changeset: e33efb09ed75 Author:jjg Date: 2009-07-30 09:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e33efb09ed75 4880672: javap does not output inner interfaces of an interface Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/s

hg: jdk7/tl/langtools: 6867671: javap whitespace formatting issues

2009-08-04 Thread jonathan . gibbons
Changeset: 743f17b55b44 Author:jjg Date: 2009-08-04 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/743f17b55b44 6867671: javap whitespace formatting issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/c

hg: jdk7/tl/langtools: 6868553: 6867671 breaks some tests

2009-08-05 Thread jonathan . gibbons
Changeset: bc0b1f404c40 Author:jjg Date: 2009-08-05 07:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bc0b1f404c40 6868553: 6867671 breaks some tests Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! test/tools/javac/code/ArrayC

  1   2   3   4   5   6   >