hg: jdk8/tl/langtools: 8025913: Rename jdk.Supported to jdk.Exported

2013-10-04 Thread joe . darcy
Changeset: 379c04c090cf Author:darcy Date: 2013-10-04 10:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379c04c090cf 8025913: Rename jdk.Supported to jdk.Exported Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg ! src/share/classes/com/sun/source/doctree/Attr

hg: jdk8/tl/langtools: 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer

2013-10-07 Thread joe . darcy
Changeset: 4dd7ffbf01fb Author:darcy Date: 2013-10-07 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dd7ffbf01fb 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element

hg: jdk8/tl/jdk: 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation

2013-10-09 Thread joe . darcy
Changeset: c13309f658e1 Author:darcy Date: 2013-10-09 18:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation Reviewed-by: mduigou, briangoetz ! src/share/cla

hg: jdk8/tl/langtools: 8026838: Fix new doclint issues in javax.annotation.processing

2013-10-17 Thread joe . darcy
Changeset: 7af634b1fc5b Author:darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java

hg: jdk8/tl/jdk: 8026840: Fix new doclint issues in javax.naming

2013-10-17 Thread joe . darcy
Changeset: 8a7b1b615100 Author:darcy Date: 2013-10-17 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100 8026840: Fix new doclint issues in javax.naming Reviewed-by: mchung ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/Co

hg: jdk8/tl/jdk: 8022658: Revisit FunctionalInterface on some core libs types

2013-10-21 Thread joe . darcy
Changeset: c1700125d041 Author:darcy Date: 2013-10-21 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1700125d041 8022658: Revisit FunctionalInterface on some core libs types Reviewed-by: briangoetz, mduigou, mr ! src/share/classes/java/io/Closeable.java ! src/share/cl

hg: jdk8/tl/langtools: 8026984: Clarity intended use of jdk.Exported

2013-10-21 Thread joe . darcy
Changeset: b82982ac3ca2 Author:darcy Date: 2013-10-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b82982ac3ca2 8026984: Clarity intended use of jdk.Exported Reviewed-by: psandoz, mr, alanb ! src/share/classes/jdk/Exported.java

hg: jdk8/tl/jdk: 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager}

2013-10-22 Thread joe . darcy
Changeset: 9a32af82bd1e Author:darcy Date: 2013-10-22 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager} Reviewed-by: chegar, forax, alanb, mduigou ! src/share/classe

hg: jdk8/tl/jdk: 8005294: Consider default methods for additions to AnnotatedElement

2013-10-30 Thread joe . darcy
Changeset: e8894e3224d9 Author:darcy Date: 2013-10-30 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9 8005294: Consider default methods for additions to AnnotatedElement Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel ! src/share/classes/java/lang/r

hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types

2013-11-07 Thread joe . darcy
Changeset: e39bd9401ea5 Author:darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/Simple

hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes

2013-11-08 Thread joe . darcy
Changeset: 11376ad23e21 Author:darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/ref

hg: jdk8/tl/jdk: 8028229: Fix more raw types lint warning in core libraries

2013-11-12 Thread joe . darcy
Changeset: 69432cb5bca2 Author:darcy Date: 2013-11-12 09:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2 8028229: Fix more raw types lint warning in core libraries Reviewed-by: chegar, forax, lancea, alanb, jfranck ! src/share/classes/java/io/ObjectOutputStrea

hg: jdk8/tl/jdk: 8028300: Fix raw type lint warnings in java.util.concurrent

2013-11-13 Thread joe . darcy
Changeset: e6333788b117 Author:darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/sh

hg: jdk8/tl/jdk: 8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors

2013-12-01 Thread joe . darcy
Changeset: ca911e383e26 Author:darcy Date: 2013-12-01 23:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca911e383e26 8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors Reviewed-by: psandoz, mduigou ! src/share/classes/java/util/

hg: jdk8/tl/jdk: 8029478: Fix more doclint issues in javax.script

2013-12-03 Thread joe . darcy
Changeset: 1c3d58caa7da Author:darcy Date: 2013-12-03 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c3d58caa7da 8029478: Fix more doclint issues in javax.script Reviewed-by: chegar, mduigou ! src/share/classes/javax/script/ScriptEngineFactory.java

hg: jdk8/tl/jdk: 8029475: Fix more doclint issues in javax.security

2013-12-03 Thread joe . darcy
Changeset: cd4aabc40f72 Author:darcy Date: 2013-12-03 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd4aabc40f72 8029475: Fix more doclint issues in javax.security Reviewed-by: juh ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherSpi

hg: jdk8/tl/jdk: 8023471: Add compatibility note to AnnotatedElement

2013-12-06 Thread joe . darcy
Changeset: f8da1f34c65c Author:darcy Date: 2013-12-06 11:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8da1f34c65c 8023471: Add compatibility note to AnnotatedElement Reviewed-by: smarks, jfranck, abuckley ! src/share/classes/java/lang/annotation/Annotation.java ! src/s

hg: jdk8/tl/langtools: 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model)

2013-12-17 Thread joe . darcy
Changeset: 6d1f9d1fd585 Author:darcy Date: 2013-12-17 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d1f9d1fd585 8030080: Correct misstatement in JSR 269 MR (in javax.lang.model) Reviewed-by: jfranck ! src/share/classes/javax/lang/model/type/IntersectionType.jav

hg: jdk8/tl/jdk: 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"

2014-01-03 Thread joe . darcy
Changeset: 68de5492a06d Author:darcy Date: 2014-01-03 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68de5492a06d 8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity" Reviewed-by: mduigou, psandoz ! src/share/classes/java/ut

JDK 9 RFR of JDK-8031201: Fix casting lint issues in java.net

2014-01-06 Thread Joe Darcy
Hello, Please review the simple patch below to address JDK-8031201: Fix casting lint issues in java.net (The various ObjectInputStream.GetField.get methods which have a default parameter, have an property-typed return value already.) Thanks, -Joe diff -r 9af7c1225730 src/share/classes

JDK 9 RFR of 8031326: Use Class rather than Class in java.net method signatures

2014-01-07 Thread Joe Darcy
Hello, Please review these changes to remove use of raw Class in some method signatures in java.net: JDK-8031326: Use Class rather than Class in java.net method signatures Patch below. Thanks, -Joe --- a/src/share/classes/java/net/URL.javaTue Jan 07 09:17:56 2014 -0800 +++ b/

JDK 9 RFR of JDK-8041395: Doclint regression in java.net.SocketOption

2015-02-09 Thread joe darcy
Hello, Please review these straightforward changes to address some doclint issues in java.net: JDK-8041395: Doclint regression in java.net.SocketOption http://cr.openjdk.java.net/~darcy/8041395.0/ Patch below. Thanks, -Joe --- old/src/java.base/share/classes/java/net/DatagramSocket

Re: Temporarily remove java/net/httpclient from jdk_net test group

2016-10-25 Thread joe darcy
Looks fine Chris; thanks, -Joe On 10/25/2016 5:55 AM, Chris Hegarty wrote: Hi, There are some intermittent test failures in java/net/httpclient. Since development is ongoing over in the sandbox [1], then it is probably best to exclude these tests from the jdk_net test group, in the JDK 9 ma

JDK 12 RFR of JDK-8213911: Use example.com in java.net and other examples

2018-11-26 Thread joe darcy
Hello, Please review a simple doc-only change to address:     JDK-8213911: Use example.com in java.net and other examples     http://cr.openjdk.java.net/~darcy/8213911.0/ Patch below. Thanks, -Joe --- old/src/java.base/share/classes/java/net/HostPortrange.java 2018-11-26 13:32:47.07800

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

2019-10-02 Thread Joe Darcy
Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Cheers, -Joe On 10/2/2019 4:26 PM, Ivan Gerasimov wrote: Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't thi

JDK 16 RFR of JDK-8250244: Address reliance on default constructors in java.net

2020-07-23 Thread Joe Darcy
Hello, Please review the replacement of default constructors in various abstract classes in java.net with explicit constructors:     webrev: http://cr.openjdk.java.net/~darcy/8250244.0/     CSR: https://bugs.openjdk.java.net/browse/JDK-8250245 (This is part of a larger effort to remove defaul

Re: JDK 16 RFR of JDK-8250244: Address reliance on default constructors in java.net

2020-07-24 Thread Joe Darcy
Hi Alan, On 7/24/2020 3:34 AM, Alan Bateman wrote: On 24/07/2020 01:33, Joe Darcy wrote: Hello, Please review the replacement of default constructors in various abstract classes in java.net with explicit constructors:     webrev: http://cr.openjdk.java.net/~darcy/8250244.0/     CSR: https

Re: RFR: JDK-8255262: Remove use of legacy custom @spec tag

2020-10-22 Thread Joe Darcy
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/814

RFR: 8250564: Remove terminally deprecated constructor in GSSUtil

2021-01-05 Thread Joe Darcy
Back in JDK 16, two unintended default constructors were identified and deprecated for removal. The time has come to remove them. Please also review the corresponding CSRs: JDK-8258521 Remove terminally deprecated constructor in GSSUtil https://bugs.openjdk.java.net/browse/JDK-8258521 JDK-825

Integrated: 8250564: Remove terminally deprecated constructor in GSSUtil

2021-01-06 Thread Joe Darcy
On Tue, 5 Jan 2021 21:02:21 GMT, Joe Darcy wrote: > Back in JDK 16, two unintended default constructors were identified and > deprecated for removal. The time has come to remove them. > > Please also review the corresponding CSRs: > > JDK-8258521 Remove terminally depreca

Re: RFR: JDK-8262875: doccheck: empty paragraphs, etc in java.base module

2021-03-02 Thread Joe Darcy
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote: > Please review some minor doc fixes, for issues found by _doccheck_.There > are two kinds of errors that are addressed. > > 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a > paragraph. It is not a terminator, to mark

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Joe Darcy
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Joe Darcy
On 8/18/2021 6:20 AM, Roger Riggs wrote: On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) 34 Minutes

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Joe Darcy
This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback on

RFR: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net

2021-10-05 Thread Joe Darcy
Augmentations to javac's Xlint:serial checking are out for review (#5709) and the sun.net classes in this PR would need some changes to pass under the expanded checks. The changes are to suppress warnings where non-transient fields in serializable types are not declared with a type statically k

Integrated: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net

2021-10-05 Thread Joe Darcy
On Tue, 5 Oct 2021 18:55:09 GMT, Joe Darcy wrote: > Augmentations to javac's Xlint:serial checking are out for review (#5709) and > the sun.net classes in this PR would need some changes to pass under the > expanded checks. > > The changes are to suppress warnings where

Re: RFR: 8274835: Remove unnecessary castings in java.base

2021-10-06 Thread Joe Darcy
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to select only casts which are definitely safe to remove. Also didn't > touch primitive types casts. Curious. The JDK build is done with javac -Xlint:

Re: RFR: 8276348: Use blessed modifier order in java.base

2021-11-02 Thread Joe Darcy
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it at > mass? > > As far as I remember, the first mass-canonicalization of modifiers took place

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Joe Darcy
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Joe Darcy
Use presumed syntax that will be introduced by JDK-8280488. - Commit messages: - JDK-8280492: Address remaining doclint issues in JDK build Changes: https://git.openjdk.java.net/jdk/pull/7189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=00 Issue: https:/

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This should be the (near) final step to fully enable all doclint checks during the javac portion of the build. The "reference" doclint check is currently disabled

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Joe Darcy
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote: > > Use presumed syntax that will be introduced by JDK-8280488. > > Is that a wrong bug? If you are talking about module-prefix syntax for links, > then it was introduced in JDK 15; JDK-8164408: Add module support for @see, > @link and @link

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links [v2]

2022-01-24 Thread Joe Darcy
> Use presumed syntax that will be introduced by JDK-8280488. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits si

Integrated: JDK-8280492: Use cross-module syntax for cross-module links

2022-01-24 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This pull request has now been integrated. Changeset: 8e82d002 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c11

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-31 Thread Joe Darcy
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

RFR: JDK-8282686: Add constructors taking a cause to SocketException

2022-03-04 Thread Joe Darcy
Please review this small API enhancement to add the usual constructors taking a cause to SocketException and then update uses of initiCause on creating SocketException to instead pass the cause via the constructor. Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688 ---

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Joe Darcy
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException [v2]

2022-03-07 Thread Joe Darcy
.net/browse/JDK-8282688 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Add regression

Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException [v3]

2022-03-07 Thread Joe Darcy
.net/browse/JDK-8282688 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Improve test. - Changes: - all: https://git.openjdk.java.net/jdk/pull/7705/files - new: https://git.openjdk.java.net/jdk/pull/7705/files/978b379d..da

Integrated: JDK-8282686: Add constructors taking a cause to SocketException

2022-03-07 Thread Joe Darcy
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote: > Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Ple

Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Joe Darcy
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote: > Let's take advantage of Java 7 language feature - "Catching Multiple > Exception Types". > It simplifies code. Reduces duplication. > Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' > statement Core libs changes lo

network tests

2008-06-23 Thread Joe Darcy
Greetings. Recently Mark Wielaard started an effort to run the regression tests on OpenJDK builds and publish the results (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). Certain tests in the nio and networking area assume Sun-internal hosts like javaweb are ava

Re: network tests

2008-06-23 Thread Joe Darcy
Alan Bateman wrote: Joe Darcy wrote: Greetings. Recently Mark Wielaard started an effort to run the regression tests on OpenJDK builds and publish the results (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). Certain tests in the nio and networking area assume

hg: jdk7/tl/jdk: 6792545: Typo in java.util.Collection JavaDoc; ...

2009-01-14 Thread joe . darcy
Changeset: 7f6969c09075 Author:darcy Date: 2009-01-14 16:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7f6969c09075 6792545: Typo in java.util.Collection JavaDoc 6655123: Incorrect ref to The Art of Computer Programming in doc for java.util.Random Summary: Fix a pair of

hg: jdk7/tl/langtools: 6583626: Improve serialization support in javax.lang.model.type exception classes

2009-01-16 Thread joe . darcy
Changeset: 18c433be7aa7 Author:darcy Date: 2009-01-16 14:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/18c433be7aa7 6583626: Improve serialization support in javax.lang.model.type exception classes Reviewed-by: jjg ! src/share/classes/javax/lang/model/type/Mirrore

hg: jdk7/tl/jdk: 6604864: Double.valueOf(String) does not specify behaviour for overflow and underflow

2009-01-23 Thread joe . darcy
Changeset: cb641d17bbb3 Author:darcy Date: 2009-01-23 10:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb641d17bbb3 6604864: Double.valueOf(String) does not specify behaviour for overflow and underflow Reviewed-by: emcmanus ! src/share/classes/java/lang/Double.java ! sr

hg: jdk7/tl/jdk: 6601457: Move wrapper class tests from closed to open; ...

2009-01-26 Thread joe . darcy
Changeset: f3ad2ee4600b Author:darcy Date: 2009-01-26 19:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3ad2ee4600b 6601457: Move wrapper class tests from closed to open 6601458: Move java.math tests from closed to open 6740185: Move java/lang/annotations tests to open 67

hg: jdk7/tl/langtools: 6707027: langtools/test/tools/javac/processing/model/testgetallmember/Main.java fails

2009-01-27 Thread joe . darcy
Changeset: edb8d7985cfd Author:darcy Date: 2009-01-27 17:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/edb8d7985cfd 6707027: langtools/test/tools/javac/processing/model/testgetallmember/Main.java fails Reviewed-by: jjg ! test/tools/javac/processing/model/testgetal

hg: jdk7/tl/jdk: 6704655: Test test/java/lang/reflect/Generics/Probe.java fails under OpenJDK

2009-01-28 Thread joe . darcy
Changeset: c2d2185a79dd Author:darcy Date: 2009-01-28 10:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2d2185a79dd 6704655: Test test/java/lang/reflect/Generics/Probe.java fails under OpenJDK Reviewed-by: ksrini ! test/java/lang/reflect/Generics/Probe.java

hg: jdk7/tl/jdk: 6719182: update legal notice in java/lang/instrument/package.html

2009-01-28 Thread joe . darcy
Changeset: 1ebbc958f06a Author:darcy Date: 2009-01-28 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ebbc958f06a 6719182: update legal notice in java/lang/instrument/package.html Reviewed-by: jjh ! src/share/classes/java/lang/instrument/package.html

hg: jdk7/tl/jdk: 6239194: Object.hashCode() should reference System.identityHashCode()

2009-01-29 Thread joe . darcy
Changeset: 7241bd422542 Author:darcy Date: 2009-01-29 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7241bd422542 6239194: Object.hashCode() should reference System.identityHashCode() Reviewed-by: emcmanus ! src/share/classes/java/lang/Object.java

hg: jdk7/tl/jdk: 6327048: Enum javadoc could link to JLS; ...

2009-01-29 Thread joe . darcy
Changeset: ff9ad99b63cc Author:darcy Date: 2009-01-29 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff9ad99b63cc 6327048: Enum javadoc could link to JLS 6653154: Exception message for bad Enum.valueOf has spurious "class" Reviewed-by: emcmanus ! src/share/classes/java

hg: jdk7/tl/jdk: 6799343: (fmt) java.util.Formatter uses plainlink instead of linkplain

2009-01-30 Thread joe . darcy
Changeset: 483e5c97d438 Author:darcy Date: 2009-01-30 12:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/483e5c97d438 6799343: (fmt) java.util.Formatter uses plainlink instead of linkplain Reviewed-by: alanb ! src/share/classes/java/util/Formatter.java

hg: jdk7/tl/jdk: 6799462: Minor typo (wrong word) in JavaDoc for InputStream.read(byte[] b) method

2009-01-30 Thread joe . darcy
Changeset: 948c504d6ef7 Author:darcy Date: 2009-01-30 15:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/948c504d6ef7 6799462: Minor typo (wrong word) in JavaDoc for InputStream.read(byte[] b) method Reviewed-by: sherman, martin ! src/share/classes/java/io/InputStream.jav

hg: jdk7/tl/jdk: 6548433: (enum spec) java.lang.Enum docs should explain about values() and valueOf(String)

2009-02-03 Thread joe . darcy
Changeset: 050da121df16 Author:darcy Date: 2009-02-03 16:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/050da121df16 6548433: (enum spec) java.lang.Enum docs should explain about values() and valueOf(String) Reviewed-by: martin ! src/share/classes/java/lang/Enum.java

hg: jdk7/tl/langtools: 6794071: Provide exception superclass for UnknownFooExceptions

2009-02-06 Thread joe . darcy
Changeset: 58fcba61a77d Author:darcy Date: 2009-02-06 12:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/58fcba61a77d 6794071: Provide exception superclass for UnknownFooExceptions Reviewed-by: jjg + src/share/classes/javax/lang/model/UnknownEntityException.java ! s

hg: jdk7/tl/langtools: 6460529: Provide mixin interfaces for getQualifiedName and getTypeParameters

2009-02-20 Thread joe . darcy
Changeset: dab918a1c907 Author:darcy Date: 2009-02-20 11:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dab918a1c907 6460529: Provide mixin interfaces for getQualifiedName and getTypeParameters Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/Prin

hg: jdk7/tl/langtools: 6501749: 6501749 Filer should state connection between created files and root elements

2009-02-24 Thread joe . darcy
Changeset: 435d5d9bb87d Author:darcy Date: 2009-02-24 17:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/435d5d9bb87d 6501749: 6501749 Filer should state connection between created files and root elements Reviewed-by: jjg ! src/share/classes/javax/annotation/process

hg: jdk7/tl/langtools: 6498938: Faulty comparison of TypeMirror objects in getElementsAnnotatedWith implementation

2009-02-24 Thread joe . darcy
Changeset: 1fbc1cc6e260 Author:darcy Date: 2009-02-24 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1fbc1cc6e260 6498938: Faulty comparison of TypeMirror objects in getElementsAnnotatedWith implementation Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac

hg: jdk7/tl/langtools: 6843761: Update langtools tests to remove unncessary -source and -target options

2009-05-27 Thread joe . darcy
Changeset: 84061bd68019 Author:darcy Date: 2009-05-27 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/84061bd68019 6843761: Update langtools tests to remove unncessary -source and -target options Reviewed-by: jjg ! test/com/sun/javadoc/testIndex/TestIndex.java ! t

hg: jdk7/tl/langtools: 6593082: MirroredTypeException constructor does not throw NPE when type is null

2009-06-26 Thread joe . darcy
Changeset: ca063536e4a6 Author:darcy Date: 2009-06-26 12:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca063536e4a6 6593082: MirroredTypeException constructor does not throw NPE when type is null Reviewed-by: jjg ! src/share/classes/javax/lang/model/type/MirroredTy

hg: jdk7/tl/jdk: 6857803: Missing links to exceptions in javadoc for Class.getGeneric{Superclass, Interfaces}

2009-07-07 Thread joe . darcy
Changeset: 0a294c066e7a Author:darcy Date: 2009-07-07 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a294c066e7a 6857803: Missing links to exceptions in javadoc for Class.getGeneric{Superclass, Interfaces} Reviewed-by: chegar ! src/share/classes/java/lang/Class.java

hg: jdk7/tl/jdk: 6628737: Specification of wrapper class valueOf static factories should require caching

2009-07-09 Thread joe . darcy
Changeset: ae60bb671e54 Author:darcy Date: 2009-07-09 12:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae60bb671e54 6628737: Specification of wrapper class valueOf static factories should require caching Reviewed-by: mr ! src/share/classes/java/lang/Byte.java ! src/shar

hg: jdk7/tl/jdk: 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-15 Thread joe . darcy
Changeset: aaf0cb20646e Author:darcy Date: 2009-07-15 12:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aaf0cb20646e 6857789: (reflect) Create common superclass of reflective exceptions Reviewed-by: martin ! src/share/classes/java/lang/ClassNotFoundException.java ! src/sh

hg: jdk7/tl/jdk: 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble

2009-07-15 Thread joe . darcy
Changeset: 2a1b1075f583 Author:darcy Date: 2009-07-15 14:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a1b1075f583 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble Reviewed-by: lancea, iris ! src/share/classes/java/lang/Double.java

hg: jdk7/tl/langtools: 6381698: Warn of decommissioning of apt

2009-07-26 Thread joe . darcy
Changeset: d043adadc8b6 Author:darcy Date: 2009-07-26 21:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d043adadc8b6 6381698: Warn of decommissioning of apt Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java ! sr

hg: jdk7/tl/langtools: 6871291: Please clarify javax.tools.JavaCompiler.getTask() "classes" parameter

2009-08-19 Thread joe . darcy
Changeset: 2ce3597237f0 Author:darcy Date: 2009-08-19 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2ce3597237f0 6871291: Please clarify javax.tools.JavaCompiler.getTask() "classes" parameter Reviewed-by: jjg ! src/share/classes/javax/tools/JavaCompiler.java

hg: jdk7/tl/jdk: 6378701: (enum) Unclear purpose of EnumConstantNotPresentException

2009-08-22 Thread joe . darcy
Changeset: 3992a43bb0a5 Author:darcy Date: 2009-08-21 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3992a43bb0a5 6378701: (enum) Unclear purpose of EnumConstantNotPresentException Reviewed-by: lancea, andrew, alanb ! src/share/classes/java/lang/EnumConstantNotPresentE

hg: jdk7/tl/langtools: 6872011: Update printing processor to support JSR 308

2009-08-25 Thread joe . darcy
Changeset: 40aca381dcaf Author:darcy Date: 2009-08-25 16:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/40aca381dcaf 6872011: Update printing processor to support JSR 308 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java

hg: jdk7/tl/langtools: 6548708: Annotation processing should free service loader if there are no processors

2009-08-26 Thread joe . darcy
Changeset: 25f15fdd168a Author:darcy Date: 2009-08-26 19:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/25f15fdd168a 6548708: Annotation processing should free service loader if there are no processors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/proce

hg: jdk7/tl/jdk: 6876628: @throw instead of @throws in two ParagraphView classes

2009-08-27 Thread joe . darcy
Changeset: 25371bf31658 Author:darcy Date: 2009-08-27 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25371bf31658 6876628: @throw instead of @throws in two ParagraphView classes Reviewed-by: peterz ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/cla

hg: jdk7/tl/jdk: 6877122: Many javadoc warnings from java.awt.Window, other awt classes

2009-08-28 Thread joe . darcy
Changeset: 4a5f2147f953 Author:darcy Date: 2009-08-28 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a5f2147f953 6877122: Many javadoc warnings from java.awt.Window, other awt classes Reviewed-by: anthony ! src/share/classes/java/awt/Cursor.java ! src/share/classes/ja

hg: jdk7/tl/jdk: 6261502: (reflect) Add the functionality to screen out the "inappropriate" modifier bits

2009-08-28 Thread joe . darcy
Changeset: e0f79982edd2 Author:darcy Date: 2009-08-28 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0f79982edd2 6261502: (reflect) Add the functionality to screen out the "inappropriate" modifier bits Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Construc

hg: jdk7/tl/jdk: 6873951: test/java/lang/reflect/Generics/Probe.java fails.

2009-09-04 Thread joe . darcy
Changeset: c34f92a47245 Author:darcy Date: 2009-09-04 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c34f92a47245 6873951: test/java/lang/reflect/Generics/Probe.java fails. Reviewed-by: alanb ! test/java/lang/reflect/Generics/Probe.java

hg: jdk7/tl/langtools: 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements

2009-09-21 Thread joe . darcy
Changeset: 789ee1acf107 Author:darcy Date: 2009-09-21 21:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/789ee1acf107 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements Reviewed-by: ahe ! src/share/classes/javax/lang/model/ele

hg: jdk7/tl/jdk: 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes.

2009-09-22 Thread joe . darcy
Changeset: c715b68cdcaf Author:darcy Date: 2009-09-22 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c715b68cdcaf 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes. Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Co

hg: jdk7/tl/langtools: 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception; ...

2009-09-23 Thread joe . darcy
Changeset: e992e602788e Author:darcy Date: 2009-09-23 18:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e992e602788e 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception 6517907: javax.lang.model.util.Elements.getConstantExpres

hg: jdk7/tl/langtools: 6337964: should ignore last comma in annotation array

2009-09-24 Thread joe . darcy
Changeset: d0f541480556 Author:darcy Date: 2009-09-24 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d0f541480556 6337964: should ignore last comma in annotation array Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/j

hg: jdk7/tl/jdk: 5062288: (reflect) Core reflection uses raw types when it could be using wildcards

2009-10-06 Thread joe . darcy
Changeset: 572791538be5 Author:darcy Date: 2009-10-06 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/572791538be5 5062288: (reflect) Core reflection uses raw types when it could be using wildcards Reviewed-by: alanb ! src/share/classes/java/lang/Class.java ! src/share

hg: jdk7/tl/jdk: 6480728: Byte.valueOf(byte) returns a cached value but Byte.valueOf(String); ...

2009-10-07 Thread joe . darcy
Changeset: e7ad502130ba Author:darcy Date: 2009-10-07 14:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7ad502130ba 6480728: Byte.valueOf(byte) returns a cached value but Byte.valueOf(String) 6655735: Integer.toString() and String.valueOf(int) contain slow delegations Rev

hg: jdk7/tl/jdk: 6797535: Add shared two argument static equals method to the platform

2009-10-09 Thread joe . darcy
Changeset: 3b45b809d8ff Author:darcy Date: 2009-10-09 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3b45b809d8ff 6797535: Add shared two argument static equals method to the platform Reviewed-by: sherman ! make/java/java/FILES_java.gmk + src/share/classes/java/util/Ob

hg: jdk7/tl/jdk: 6648344: (reflect spec) State default of isAccessible for reflective objects

2009-10-13 Thread joe . darcy
Changeset: 9d240dbadaa3 Author:darcy Date: 2009-10-13 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d240dbadaa3 6648344: (reflect spec) State default of isAccessible for reflective objects Reviewed-by: alanb ! src/share/classes/java/lang/reflect/AccessibleObject.java

hg: jdk7/tl/jdk: 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap

2009-10-13 Thread joe . darcy
Changeset: 151baf5e19ca Author:darcy Date: 2009-10-13 17:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/151baf5e19ca 6349921: (enum) Include links from java.lang.Enum to EnumSet and EnumMap Reviewed-by: martin ! src/share/classes/java/lang/Enum.java

hg: jdk7/tl/langtools: 6558804: Specification for Elements.getDocComment(Element e) should be clarified

2009-10-14 Thread joe . darcy
Changeset: b8936a7930fe Author:darcy Date: 2009-10-14 18:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b8936a7930fe 6558804: Specification for Elements.getDocComment(Element e) should be clarified Reviewed-by: jjg ! src/share/classes/javax/lang/model/util/Elements.

hg: jdk7/tl/jdk: 4428022: System.out.println(0.001) outputs 0.0010

2009-10-15 Thread joe . darcy
Changeset: f85aa3aedf41 Author:darcy Date: 2009-10-15 18:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f85aa3aedf41 4428022: System.out.println(0.001) outputs 0.0010 Reviewed-by: darcy Contributed-by: a...@redhat.com ! src/share/classes/sun/misc/FloatingDecimal.java + te

hg: jdk7/tl/jdk: 6889858: Add nonNull methods to java.util.Objects

2009-10-19 Thread joe . darcy
Changeset: 1602e8848bde Author:darcy Date: 2009-10-19 16:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1602e8848bde 6889858: Add nonNull methods to java.util.Objects Reviewed-by: darcy Contributed-by: j...@google.com ! src/share/classes/java/util/Objects.java ! test/java

hg: jdk7/tl/jdk: 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError

2009-10-20 Thread joe . darcy
Changeset: 0dd3d16e8183 Author:darcy Date: 2009-10-20 09:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0dd3d16e8183 6371401: java.math.BigInteger.shift(Integer.MIN_VALUE) throws StackOverflowError Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java + test/ja

hg: jdk7/tl/jdk: 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent

2009-10-21 Thread joe . darcy
Changeset: 98558a60c555 Author:darcy Date: 2009-10-21 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98558a60c555 6560935: BigInteger.modPow() throws ArithmeticException for negative exponent Reviewed-by: alanb ! src/share/classes/java/math/BigInteger.java

hg: jdk7/tl/jdk: 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default

2009-10-23 Thread joe . darcy
Changeset: 80102c165e09 Author:darcy Date: 2009-10-23 11:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80102c165e09 6891113: More methods for java.util.Objects: deepEquals, hash, toString with default Reviewed-by: alanb, gafter ! src/share/classes/java/util/Arrays.java

hg: jdk7/tl/jdk: 6897550: BigInteger constructor should use local cached String length

2009-11-03 Thread joe . darcy
Changeset: e740080fd1a4 Author:darcy Date: 2009-11-03 15:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e740080fd1a4 6897550: BigInteger constructor should use local cached String length Reviewed-by: andrew, chegar ! src/share/classes/java/math/BigInteger.java

  1   2   3   4   >