Brian,
On 3/10/2013 5:40 AM, Brian Burkhalter wrote:
I agree that is an ugly style but it guarantees that mistakes such as
if (error = EAI_AGAIN) {}
are caught at compilation time.
True but as I understand it this is not the preferred/common style in
the JDK code.
David
Changeset: 254173b48dcb
Author:dholmes
Date: 2013-10-10 04:57 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/254173b48dcb
8026232: Move libnpt from profile compact1 to compact3
Reviewed-by: mchung, alanb
! makefiles/profile-includes.txt
Changeset: e33aea66caa3
Author:dholmes
Date: 2013-10-15 20:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33aea66caa3
8026378: TEST_BUG: Clean up TEST.groups
Reviewed-by: mduigou, mchung, alanb
! test/TEST.groups
Brian,
On 17/10/2013 9:21 AM, Brian Burkhalter wrote:
Dmitry,
I think you are correct: that slipped by both me and the reviewers. I have
reopened the issue and posted an amendment to the original webrev here:
You can not reopen a bug once it has been fixed! You need to create a
new bug for
Changeset: d19ab5da83cc
Author:dholmes
Date: 2013-11-04 06:58 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc
8025198: Intermittent test failure:
java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java
Reviewed-by: martin, dholmes
Contributed-by: Tristan Yan
My commit pulled in a bunch of local changes that should never have been
pushed (the import commit failed due to whitespace and when I re-issued
the commit I didn't restrict it to the single test file).
Can anyone roll this back on the actual server?
Thanks,
David
Original Message --
On 4/11/2013 10:35 PM, Alan Bateman wrote:
On 04/11/2013 12:10, David Holmes wrote:
My commit pulled in a bunch of local changes that should never have
been pushed (the import commit failed due to whitespace and when I
re-issued the commit I didn't restrict it to the single test file).
Changeset: 23982079ad49
Author:dholmes
Date: 2013-11-04 07:39 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23982079ad49
8027755: Anti-delta incorrect push for 8025198
Reviewed-by: alanb
! makefiles/CompileLaunchers.gmk
! makefiles/lib/CoreLibraries.gmk
! src/share/bin/java
Hi Roger,
On 11/01/2014 1:37 AM, roger riggs wrote:
Please review:
To enable native code checking consistently for thrown exceptions,
the macros in net_util.h and java/util/jar/pack/coding.cpp are
made consolidated and promoted to jni_util.h
webrev:
http://cr.openjdk.java.net/~rriggs/webrev-ch
Just a note on this part (I havent looked at the code):
On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...)
are defined to different values than on other operating systems. The problem is
however, that these constants are hardcoded as public final static members of
v
On 15/01/2014 12:10 AM, Volker Simonis wrote:
On Tue, Jan 14, 2014 at 12:29 PM, David Holmes mailto:david.hol...@oracle.com>> wrote:
Just a note on this part (I havent looked at the code):
On AIX, the constants used for the polling events (i.e. POLLIN,
POLLOUT, ..
Sounds like a question for net-dev more than core-libs - cc'd.
David
On 20/02/2014 4:11 PM, michael cui wrote:
On 02/18/2014 12:51 AM, michael cui wrote:
Hi,
I would like to discuss my current root cause analysis of JDK-7052625
: com/sun/net/httpserver/bugs/6725892/Test.java fails intermitten
Author can host the patch on
cr.openjdk.java.net on your behalf.
Cheers,
David
[1] http://openjdk.java.net/legal/tou/terms
-- Sebastian
Am 08.09.2015 2:03 vorm. schrieb David Holmes :
On 7/09/2015 11:46 PM, Ivan Krylov wrote:
Hi Sebastian,
The current OpenJDK rules [1] do not allow to accept
Hi Scott,
cc'ing net-dev as this is not a build issue.
David
On 21/01/2016 4:18 AM, Scott Palmer wrote:
I was searching for a way to set TCP_NODELAY for an Endpoint using the default
HTTP server and after finally tracking down the existence of the
“sun.net.httpserver.nodelay” system property
Hi Yuji,
Not sure who would look at this so cc'ing net-dev.
Also note that contributions can only be accepted if presented via
OpenJKDK infrastructure. Links to patches on
http://icedtea.classpath.org are not acceptable. The patch needs to be
included in the email (beware stripped attachments
please find the updated
webrev(http://cr.openjdk.java.net/~vtewari/8165437/webrev0.7/index.html).
This change is broken on 32-bit systems - JVM_Nanotime returns a jlong
which is always 64-bit, but the code uses long for the nanotimeout
values, which will be 32-bit on 32-bit systems!
This cha
On 4/05/2017 2:07 PM, Vyom Tewari wrote:
Hi David,
I will look into the issue.
Thanks. I filed:
https://bugs.openjdk.java.net/browse/JDK-8179602
as you probably saw.
David
Thanks,
Vyom
On Thursday 04 May 2017 06:29 AM, David Holmes wrote:
please find the updated
webrev(http
cc'ing net-dev as that might be the more appropriate list.
On 22/12/2017 10:59 AM, Steven Schlansker wrote:
On Dec 21, 2017, at 4:35 PM, David Holmes wrote:
On 22/12/2017 10:29 AM, Steven Schlansker wrote:
On Dec 21, 2017, at 11:11 AM, Steven Schlansker
wrote:
What if ConnectExce
Hi Ivan,
Just a thought, but just because the actual native function may return
either code, that doesn't mean our native wrapper can't treat them the
same and present them to the Java code as one error?
It seems pointless to double up these condition checks everywhere just
in case there is
Hi Ivan,
On 25/05/2018 1:58 PM, Ivan Gerasimov wrote:
Hi David!
Thank you for reviewing the fix!
I looked but did not review - it was just an observation :)
On 5/24/18 7:44 PM, David Holmes wrote:
Hi Ivan,
Just a thought, but just because the actual native function may return
either
On 25/05/2018 3:34 PM, Ivan Gerasimov wrote:
Hi David!
On 5/24/18 9:45 PM, David Holmes wrote:
I looked but did not review - it was just an observation :)
Well, thank you anyway :)
It seems pointless to double up these condition checks everywhere
just in case there is some platform
On 25/05/2018 4:14 PM, Ivan Gerasimov wrote:
Hi David!
If gcc, then we already have the same test for both constants in code
with no issues.
For example, java.base/unix/native/libnet/SocketInputStream.c, in
NET_ReadWithTimeout():
result = NET_NonBlockingRead(fd, bufP, len);
In reference to 8205959, where is it stated that dup2 is any more
restartable than close ??
AFAICS both leave things undefined/unspecified if they set EINTR.
David
On 2/07/2018 7:03 PM, Langer, Christoph wrote:
Hi Matthias,
forwarding to serviceability-dev, because debugging is usually discu
That all seems fine to me.
Thanks for fixing.
David
On 26/09/2018 5:48 AM, Langer, Christoph wrote:
Hi Matthias,
looks good (and trivial). Ccing serviceability-dev because of change in
libjdwp.
Best regards
Christoph
*From:*nio-dev *On Behalf Of
*Baesken, Matthias
*Sent:* Mittwoch, 26
Hi Leonid,
This seems fine to me. It's been some time since hotspot hosted any of
the native code used by networking.
Thanks,
David
On 5/12/2018 7:36 am, Leonid Mesnik wrote:
Hi
Could you please review following fix which removes
vmTestbase/nsk/stress/network tests. These tests are pretty
m all -
myself included.
On Mon, Mar 25, 2019 at 1:34 AM David Holmes <mailto:david.hol...@oracle.com>> wrote:
Hi Thomas,
A few queries, comments and concerns ...
On 25/03/2019 6:58 am, Thomas Stüfe wrote:
> Hi all,
>
> After a long time I tried to b
Hi Christoph,
I'm very reluctant to see changes like this that the compiler folk have
not determined are actually incorrect. That said ...
On 15/05/2019 7:03 am, Langer, Christoph wrote:
Thanks Daniel.
Can anybody help reviewing the changes to:
src/java.base/share/classes/java/lang/invoke/Me
What compiler was used here? We shouldn't be using anything that doesn't
handle loop variable declarations!
Thanks,
David
On 16/05/2019 7:41 pm, Daniel Fuchs wrote:
Hi Ao Qi,
I'm adding serviceability-dev, since this is for jdwp.
The proposed changes look good to me - but please get
someone
. :(
alternative is to move the file to a C++ file. Adding an extern "C" at
the top would make symbols not be mangled and it should "work" without
having to go to old-C requirements.
Not sure if that's feasible.
Cheers,
David
-
Thanks,
Jc
On Thu, May 16, 201
On 16/05/2019 11:41 pm, Ao Qi wrote:
Hi Serguei,
I saw your email [1], but I didn't receive it yet. Thanks for your
review! I updated:
http://cr.openjdk.java.net/~aoqi/8224028/webrev.01/
On Thu, May 16, 2019 at 8:30 PM David Holmes wrote:
What compiler was used here? We shouldn'
ready done this dance. Solaris was setting a
flag to use C89 IIRC and we removed it.
Cheers,
David
On Thu, May 16, 2019 at 3:25 PM David Holmes <mailto:david.hol...@oracle.com>> wrote:
On 16/05/2019 11:41 pm, Ao Qi wrote:
> Hi Serguei,
>
> I saw your
On 17/05/2019 9:14 am, Martin Buchholz wrote:
On Thu, May 16, 2019 at 4:05 PM David Holmes <mailto:david.hol...@oracle.com>> wrote:
On 17/05/2019 8:57 am, Martin Buchholz wrote:
> Maybe you just need to ask gcc to use a more modern -std=...
> It might reasonably b
load
this webrev on cr.openjdk.java.net
Please suggest if there is any way I can create my user id to upload this patch.
This is ~300 line patch file.
Regards,
Vipin
On Apr 6, 2020, at 3:25 AM, David Holmes wrote:
Hi Vipin,
On 6/04/2020 6:42 am, Vipin Sharma wrote:
Hi,
I have fixed a few warni
given how error-prone that can be, I still wouldn't do it in this changeset.
-Pavel
On 8 Apr 2020, at 13:56, David Holmes wrote:
Hi Pavel,
Not a review ...
On 8/04/2020 9:50 pm, Pavel Rappo wrote:
Vipin, here you go:
https://bugs.openjdk.java.net/browse/JDK-8242366
http:/
Ship it!
Thanks,
David
The test started failing after JDK-8243099.
JBS: https://bugs.openjdk.java.net/browse/JDK-8245518
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8245518/webrev.00/open/webrev/
Cheers,
Mikael
Looks good to me - and trivial.
Thanks,
David
On 7/09/2020 2:22 pm, Christoph Langer wrote:
The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.
There should not be a comma character (",")
On Mon, 7 Sep 2020 07:28:36 GMT, Christoph Langer wrote:
>>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
>>> [nio-dev](mailto:nio-...@openjdk.java.net):_
>>> Looks good to me - and trivial.
>>>
>>> Thanks,
>&
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote:
> The format for SAP copyrights in OpenJDK headers should be like:
> Copyright (c) SAP SE. All rights reserved.
> or
> Copyright (c) , SAP SE. All rights reserved.
>
> There should not be a comma character (",") before "SAP SE".
>
> Thi
On Thu, 10 Sep 2020 10:40:15 GMT, Alan Bateman wrote:
>> @kevinrushforth thanks. Done.
>>
>> Similar issues:
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=822
On Thu, 10 Sep 2020 12:18:51 GMT, Kevin Rushforth wrote:
>> This should be broken up to deal with the files in different functional
>> areas under different bugids and PRs. Otherwise
>> the cross-posting to so many lists is prohibitive. Files in different areas
>> need to be reviewed by differe
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Mon, 7 Jun 2021 20:42:53 GMT, Weijun Wang wrote:
> More loudly and precise warning messages when a security manager is either
> enabled at startup or installed at runtime.
There are a number of hotspot tests that will trigger this warning, so please
ensure they work correctly with the extra
.html
(or https://github.com/openjdk/jdk/pull/6191#pullrequestreview-79465)
[^2]:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html
_Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
[core-libs-dev](mailto:core-libs
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote:
> Please review this semi-automatic update for the nroff man pages for JDK 18.
> The changes update the version number, copyright year, and incorporate the
> changes from the latest upstream files.
Hi Jon,
This all looks good - I'm fa
On Fri, 10 Dec 2021 02:48:43 GMT, Jonathan Gibbons wrote:
>> Please review this semi-automatic update for the nroff man pages for JDK 18.
>> The changes update the version number, copyright year, and incorporate the
>> changes from the latest upstream files.
>
> We will also want to regenerate
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On Thu, 21 Apr 2022 18:08:05 GMT, Kevin Walls wrote:
>> But on the other hand we have `javax.script.Invocable`. :-)
>>
>> Codespell suggested this change, and I based my decision to keep it based on
>> [Merriam-Webster](https://www.merriam-webster.com/dictionary/invocable) not
>> even listing
webrev: http://cr.openjdk.java.net/~dholmes/7022386/webrev/
This is a very simple forward-port of a change that already went into 6u23.
Please cc me as I'm not on the net-dev list (which probably means this
will get held up for approval :( )
Thanks,
David
Changeset: a3b6c262195b
Author:dholmes
Date: 2011-02-28 06:40 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a3b6c262195b
7022386: gethostbyname_r needs a pointer aligned buffer passed to it
Summary: Change buffer type to ensure pointer-alignment
Reviewed-by: alanb, chegar
!
Changeset: 38626f41e458
Author:dholmes
Date: 2011-03-09 19:52 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38626f41e458
7022370: Launcher ergonomics should provide simple default implementation
Summary: Use a common, platform independent, implementation unless an
architect
Changeset: eb54e565c491
Author:ohair
Date: 2011-02-26 09:45 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb54e565c491
7016175: HTML generated from new JavaDoc has tags added from makefile
Reviewed-by: jjg
! make/common/shared/Defs-javadoc.gmk
! make/docs/Makefile
Changese
Just a heads up that this changeset includes a pre-integration with
changes from jdk7/build/jdk. Those changes needed to be merged with my
changset so that the integrators wouldn't have to handle a larger merge
down the track. The changes would have been pulled down later this week.
David
dav
Changeset: 54d8193f177b
Author:dholmes
Date: 2011-03-16 18:54 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/54d8193f177b
7027910: Add basic cross-compilation support and add ARM/PPC to the known
architectures in the open code
Summary: Cross-compilation support
Reviewed-by:
Changeset: a2793622a8d8
Author:dholmes
Date: 2011-03-25 07:09 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a2793622a8d8
7030063: AWT support for SE-Embedded integration
Summary: AWT support for SE-Embedded
Reviewed-by: anthony, art, bobv, collins, alanb
! make/launchers/Ma
Changeset: 19567f9d6962
Author:dholmes
Date: 2011-03-29 08:15 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/19567f9d6962
7031929: Variable names typos in Release-embedded.gmk
Reviewed-by: alanb
! make/common/Release-embedded.gmk
Changeset: 5107fb3a9c06
Author:dholmes
Date: 2011-03-30 22:20 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5107fb3a9c06
7032364: Add jvm.cfg file for ARM and PPC architectures
Reviewed-by: darcy, bdelsart, alanb, mduigou
+ src/solaris/bin/arm/jvm.cfg
+ src/solaris/bin/ppc/
Changeset: fe232d7e4ff1
Author:dholmes
Date: 2011-03-22 18:56 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe232d7e4ff1
7025066: Build systems changes to support SE Embedded Integration
Summary: Define Embedded specific files and include them in the main files.
Allow finer
Changeset: 3abc52f0a4dc
Author:dholmes
Date: 2011-06-27 20:13 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3abc52f0a4dc
7039182: PPC: NIO: java.io.IOException: Invalid argument in
sun.nio.ch.FileDispatcherImpl.read0
Summary: Allow platform specific files to be located at b
Changeset: d177eecda07e
Author:dholmes
Date: 2011-09-20 22:20 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d177eecda07e
7012206: ~20 tools tests failing due to -XX:-UsePerfData default in Java SE
Embedded
Summary: Explicitly enable UsePerfData for the tools that require it
Changeset: cf47846165f4
Author:dholmes
Date: 2011-11-29 00:26 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf47846165f4
7109092: Wrong computation results with double at armsflt
Summary: need to link to custom soft-float library with required FP accuracy
Reviewed-by: alanb,
Changeset: d4a6627d5004
Author:dholmes
Date: 2012-03-08 00:46 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4a6627d5004
7092140: Test: java/util/concurrent/locks/Lock/TimedAcquireLeak.java fails on
SE-E due to -XX:-UsePerfData
Summary: Add -XX:+UsePerfData to invocation of
Changeset: 48513d156965
Author:dholmes
Date: 2012-05-08 02:59 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48513d156965
7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is
installed
Summary: Perform class.getField inside a doPrivileged block
Reviewed-b
Changeset: dfe5617c18b4
Author:dholmes
Date: 2012-06-20 22:40 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfe5617c18b4
7178483: Change version string for Embedded releases
Reviewed-by: dholmes, lancea
Contributed-by: Gary Collins
! make/common/Defs-embedded.gmk
Changeset: 94b525ce3653
Author:dholmes
Date: 2012-06-27 01:36 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94b525ce3653
7161229: PriorityBlockingQueue keeps hard reference to last removed element
Reviewed-by: dholmes, forax, alanb
Contributed-by: Doug Lea
! src/share/clas
level? (I don't know
how this code is used)
David Holmes
On 2/08/2012 8:54 PM, Christian Schulte wrote:
Hi,
using the system property 'java.net.useSystemProxies', JDK 7 crashes on
OpenBSD 5.2.
$ /usr/local/jre-1.7.0/bin/java -version
openjdk version "1.7.0_03"
Changeset: 9b3867244eec
Author:dholmes
Date: 2012-11-01 18:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b3867244eec
7198815: Add the minimal VM as "known" in jvm.cfg
Reviewed-by: alanb, forax, mchung
! src/solaris/bin/arm/jvm.cfg
! src/solaris/bin/i586/jvm.cfg
! src/so
Changeset: cb65e3315b27
Author:jiangli
Date: 2012-11-05 12:51 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb65e3315b27
7197210: java/lang/invoke/CallSiteTest.java failing on armsflt.
Summary: Reduce work load and set longer timeout for java/lang/invoke tests.
Reviewed-by:
Changeset: 60550cd2b527
Author:dholmes
Date: 2012-12-02 19:16 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60550cd2b527
7200297: agent code does not handle multiple boot library path elements
correctly
Summary: When bug 6819213 was fixed it enabled sun.boot.library.path pr
Changeset: 8d7323a9d8ed
Author:dholmes
Date: 2012-12-13 21:18 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d7323a9d8ed
8003632: HPROF class file version java.lang.RuntimeException errors
Reviewed-by: mchung, lancea
! src/share/javavm/export/classfile_constants.h
Real sense of deja-vu here. Didn't we go through this same thing with
the HPI socket routines?
Depending on the OS (and version?) we should be using socklen_t not int
and not uint32_t.
David
On 20/12/2012 2:35 AM, Chris Hegarty wrote:
John,
I grabbed your patch, and with it I now see diffe
Changeset: 1109bfff4e92
Author:dholmes
Date: 2013-01-13 19:57 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1109bfff4e92
8005232: (JEP-149) Class Instance size reduction
Summary: Moved the fields for cached reflection objects into a seperate
ReflectionData object to reduce
Changeset: 929e2461818b
Author:dholmes
Date: 2013-03-05 22:45 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/rev/929e2461818b
8009529: Fix for 8006988 missed closed configure changes
Reviewed-by: mr
! common/autoconf/generated-configure.sh
Changeset: 19a59a13b3ef
Author:dholmes
Date: 2013-03-14 01:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/19a59a13b3ef
8009428: Revert changes to $ substitution performed as part of nashorn
integration
Reviewed-by: alanb, erikj
! common/makefiles/MakeBase.gmk
Changeset: 41289b4a1819
Author:dholmes
Date: 2013-03-14 01:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41289b4a1819
8009429: Miscellaneous profiles cleanup
8009428: Revert changes to $ substitution performed as part of nashorn
integration
Reviewed-by: alanb, erikj
! m
Changeset: 82dc1e827c2a
Author:dholmes
Date: 2013-03-14 01:45 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82dc1e827c2a
8009429: Miscellaneous profiles cleanup
Reviewed-by: jjg, alanb
! src/share/classes/com/sun/tools/javac/sym/Profiles.java
Sorry for the wide distribution but you all see the push messages anyway.
I've just pushed a coordinated set of changes to the top-level,
langtools and jdk repos in the tl forest. If you use tl you will need to
ensure that you update all of these repos to ensure they are in sync.
Thanks,
Davi
Changeset: e766da5575fa
Author:dholmes
Date: 2013-03-19 06:01 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e766da5575fa
8009426: "profiles" target fails due to nashorn if "images" is not built first
Reviewed-by: alanb
! makefiles/CreateJars.gmk
! makefiles/Profiles.gmk
! m
Changeset: 3c1a4966d901
Author:dholmes
Date: 2013-03-20 22:39 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1a4966d901
8006818: SunEC and SunPKCS11 providers should be in all profiles
Reviewed-by: dholmes, alanb, valeriep
Contributed-by: Jen Dority
! makefiles/profile-in
Changeset: 10775618db00
Author:aharlap
Date: 2013-04-26 15:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/10775618db00
8011152: Precision problems on sflt builds
Summary: Need to add global flag to the linker
Reviewed-by: tbell, dholmes
! common/makefiles/NativeCompilation.gm
Changeset: 138f767b8eff
Author:dholmes
Date: 2013-04-29 07:40 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/138f767b8eff
8010280: jvm.cfg needs updating for non-server builds
Summary: Generate jvm.cfg based on chosen VMs for non-"standard" builds and
remove legacy entries f
Changeset: a3d79a4c2a24
Author:dholmes
Date: 2013-05-15 00:36 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3d79a4c2a24
8013395: StringBuffer.toString performance regression impacting embedded
benchmarks
Summary: cache a copy of the char[] to use with toString() and clear
Changeset: 08ebdb2b53cc
Author:plevart
Date: 2013-05-17 14:41 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08ebdb2b53cc
8014477: (str) Race condition in String.contentEquals when comparing with
StringBuffer
Reviewed-by: alanb, mduigou, dholmes
! src/share/classes/java/lan
Changeset: a1a8e71e130a
Author:dholmes
Date: 2013-05-22 20:21 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1a8e71e130a
8014814: (str) StringBuffer "null" is not appended
Reviewed-by: alanb
! src/share/classes/java/lang/StringBuffer.java
! test/java/lang/StringBuffer/ToStr
Changeset: 0b8dab7fec54
Author:plevart
Date: 2013-05-27 09:41 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b8dab7fec54
7038914: VM could throw uncaught OOME in ReferenceHandler thread
Summary: Catch OutOfMemoryError in reference handler thread if caused by
allocation of a
Changeset: 571e5f452640
Author:dholmes
Date: 2013-06-06 05:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/571e5f452640
8015470: Remove redundant calls of toString() on String objects
Reviewed-by: dholmes, alanb
Contributed-by: Otavio Goncalves
! src/share/classes/com/sun
Changeset: 7bb17aa9a09f
Author:dholmes
Date: 2013-07-09 22:01 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bb17aa9a09f
8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently
Summary: Ensure WeakRef object can't be prematurely gc'd
Reviewed-by: chegar, pl
On 8/08/2013 11:20 AM, Ivan Gerasimov wrote:
Thanks Alan!
I've checked that and it turns out that GetStringUTFChars cannot return
NULL.
For allocation of the result string it calls AllocateHeap() with the
default EXIT_OOM fail strategy.
Thus, in case of being unable to allocate memory it simply
rely yours,
Ivan
On 08.08.2013 5:35, David Holmes wrote:
On 8/08/2013 11:20 AM, Ivan Gerasimov wrote:
Thanks Alan!
I've checked that and it turns out that GetStringUTFChars cannot return
NULL.
For allocation of the result string it calls AllocateHeap() with the
default EXIT_OOM fail strategy
post an update webrev to cr.openjdk.java.net.
-Chris.
On 08/08/2013 06:01 AM, David Holmes wrote:
Ivan,
On 8/08/2013 2:05 PM, Ivan Gerasimov wrote:
David, Alan,
I added checking for NULL results and throwing OOMException if
necessary.
You don't need to throw it yourself:
JNU_ThrowO
Thumbs up!
Thanks,
David
On 9/08/2013 8:19 AM, Ivan Gerasimov wrote:
Thanks David!
On 09.08.2013 1:15, David Holmes wrote:
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Yes, it's a good point.
Since there may be a memory leak i
thin ice anyway, but better to at
least attempt to do the right thing.
FYI I filed 8022683 to fix GetStringUTFChars.
David
-
On 9/08/2013 3:21 PM, David Holmes wrote:
Thumbs up!
Thanks,
David
On 9/08/2013 8:19 AM, Ivan Gerasimov wrote:
Thanks David!
On 09.08.2013 1:15, David Holmes wrote
[2]
http://docs.oracle.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp17626
Sincerely yours,
Ivan
On 09.08.2013 11:25, Chris Hegarty wrote:
On 09/08/2013 06:47, David Holmes wrote:
Sorry I messed this up. The JNI book says GetStringUTFChars will return
NULL and post OOME but the JNI spe
/2commit/8022584-jdk8-Memleak-in-NetworkInterface.patch
Sincerely yours,
Ivan
On 09.08.2013 16:18, David Holmes wrote:
Hi Chris,
On 9/08/2013 8:36 PM, Chris Hegarty wrote:
Firstly, I think the memory leak issue should be moved forward
separately to this cleanup effort. They are unrelated, and I&#
Changeset: e17da8b09f5e
Author:dholmes
Date: 2013-08-20 03:18 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e17da8b09f5e
8023311: Clean up profile-includes.txt
Reviewed-by: alanb
! makefiles/profile-includes.txt
Changeset: 3b8fed46b2a8
Author:dholmes
Date: 2013-08-21 05:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8fed46b2a8
8023460: OPENJDK build fails due to missing jfr.jar
Reviewed-by: alanb
! makefiles/Profiles.gmk
Changeset: 9586ca82bd8b
Author:bpittore
Date: 2013-08-26 11:27 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9586ca82bd8b
8014135: The JVMTI specification does not conform to recent changes in JNI
specification
Summary: Added support for statically linked agents
Reviewed-by
Changeset: 2cdd1078f45b
Author:dholmes
Date: 2013-09-03 23:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cdd1078f45b
8024140: [TESTBUG] Profile based regression test groups for jdk repo
Reviewed-by: alanb, chegar
! test/TEST.groups
97 matches
Mail list logo
