Re: RFR: 8202343: Disable TLS 1.0 and 1.1 [v2]

2020-11-17 Thread Xue-Lei Andrew Fan
On Tue, 17 Nov 2020 17:55:19 GMT, Sean Mullan wrote: >> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the >> jdk.tls.disabledAlgorithms security property in the java.security file. >> These protocols use weak algorithms and are being deprecated by the IETF. >> They sho

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Xue-Lei Andrew Fan
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8254631: Better support ALPN byte wire values in SunJSSE

2020-12-01 Thread Xue-Lei Andrew Fan
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote: > Certain TLS ALPN values can't be properly read or written by the SunJSSE > provider. This is due to the choice of Strings as the API interface and the > undocumented internal use of the UTF-8 Character Set which converts > characters

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Xue-Lei Andrew Fan
On Wed, 13 Jan 2021 18:46:10 GMT, Rajan Halade wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Update copyright year >> - Add error handling guidelines >> - Fix bugids and use serv

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-28 Thread Xue-Lei Andrew Fan
On Tue, 26 Jan 2021 18:56:57 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has up

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-01-28 Thread Xue-Lei Andrew Fan
On Thu, 28 Jan 2021 20:12:14 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has up

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-02-02 Thread Xue-Lei Andrew Fan
On Tue, 2 Feb 2021 01:15:25 GMT, Clive Verghese wrote: > Hi, > > Thank you for the feedback. > > I have verified that tier1 and tier2 tests pass on Windows, MacOS and Linux. Thank you! I will address the closed test failures. I will post you when the update is ready. - PR: htt

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v9]

2021-02-03 Thread Xue-Lei Andrew Fan
On Tue, 2 Feb 2021 01:19:01 GMT, Clive Verghese wrote: >> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears >> to not be fully fixed >> >> This also fixes JDK-8259516: Alerts sent by peer may not be received >> correctly during TLS handshake > > Clive Verghese has upd

Re: RFR: JDK-8260925: HttpsURLConnection does not work with other JSSE provider.

2021-03-02 Thread Xue-Lei Andrew Fan
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote: > HttpsURLConnection, works with SunJSSE provider but does not work with other > JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as > follows > > s = (SSLSocket)serverSocket; >if (s instanceof SSLSocketImpl) { >

Re: RFR: JDK-8260925: HttpsURLConnection does not work with other JSSE provider.

2021-03-02 Thread Xue-Lei Andrew Fan
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote: > HttpsURLConnection, works with SunJSSE provider but does not work with other > JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as > follows > > s = (SSLSocket)serverSocket; > if (s instanceof SSLSocketImpl) { > ((S

Re: RFR: JDK-8260925: HttpsURLConnection does not work with other JSSE provider. [v4]

2021-03-03 Thread Xue-Lei Andrew Fan
On Wed, 3 Mar 2021 15:10:54 GMT, Vyom Tewari wrote: >> HttpsURLConnection, works with SunJSSE provider but does not work with other >> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as >> follows >> >> s = (SSLSocket)serverSocket; >>if (s instanceof SSLSocketImpl)

Re: RFR: JDK-8260925: HttpsURLConnection does not work with other JSSE provider. [v5]

2021-03-03 Thread Xue-Lei Andrew Fan
On Wed, 3 Mar 2021 17:56:02 GMT, Vyom Tewari wrote: >> HttpsURLConnection, works with SunJSSE provider but does not work with other >> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as >> follows >> >> s = (SSLSocket)serverSocket; >>if (s instanceof SSLSocketImpl)

Re: RFR: JDK-8260925: HttpsURLConnection does not work with other JSSE provider. [v6]

2021-03-03 Thread Xue-Lei Andrew Fan
On Thu, 4 Mar 2021 04:02:03 GMT, Vyom Tewari wrote: >> HttpsURLConnection, works with SunJSSE provider but does not work with other >> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as >> follows >> >> s = (SSLSocket)serverSocket; >>if (s instanceof SSLSocketImpl)

Re: RFR: 8255674: SSLEngine class description is missing "case" in switch statement

2021-05-24 Thread Xue-Lei Andrew Fan
On Tue, 25 May 2021 04:36:53 GMT, Jaikiran Pai wrote: > Can I please get a review for this trivial fix in the code sample in javadoc > comment of `javax.net.ssl.SSLEngine` class? > > I've run `make docs-image` locally and the generated javadoc after this > change looks fine. Marked as reviewe

Re: RFR: 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code

2021-08-26 Thread Xue-Lei Andrew Fan
On Fri, 27 Aug 2021 01:35:17 GMT, Bradford Wetmore wrote: > Did a quick sweep of some minor non-standard javadoc issues. This silences > 3rd party tooling warnings and fixes some linkage issues. Looks good to me. Thank you for the clean up. src/java.base/share/classes/javax/net/ssl/SNIHostNa

RFR: 8280363: Minor correction of ALPN specification in SSLParameters

2022-01-19 Thread Xue-Lei Andrew Fan
In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the return statement says that "The array is ordered based on protocol preference, with protocols[0] being the most preferred.". However, there is no "protocols" variable in this method. The update is a minor correction so

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Xue-Lei Andrew Fan
thod. > > The update is a minor correction so that the specification is not rely on the > "protocols" variable. Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: Update per feedback - Changes:

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Jan 2022 14:16:43 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update per feedback > > src/java.base/share/classes/javax/net/ssl/SSLParam

Re: RFR: 8280363: Minor correction of ALPN specification in SSLParameters [v2]

2022-01-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Jan 2022 15:31:55 GMT, Daniel Fuchs wrote: >> Hm, much better. Thanks! > >> The phrase "descending order" seems more appropriate for numerical values. I >> think the previous wording was more clear, with a small change: "The array >> is ordered based on protocol preference, with the

Integrated: 8280363: Minor correction of ALPN specification in SSLParameters

2022-01-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Jan 2022 07:12:42 GMT, Xue-Lei Andrew Fan wrote: > In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the > return statement says that "The array is ordered based on protocol > preference, with protocols[0] being the most preferred.". Howe

RFR: 8280494: (D)TLS signature schemes

2022-01-27 Thread Xue-Lei Andrew Fan
This update is to support signature schemes customization for individual (D)TLS connection. Please review the CSR as well: CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 - Commit messages: - 8280494: https://bugs.openjdk.

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-27 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-27 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 23:43:51 GMT, Jie Fu wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 15:17:25 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParam

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 15:50:49 GMT, Jamil Nimeh wrote: >> You should also define the interaction with the system properties (probably >> as an @implNote). Does `getSignatureSchemes` ever return the value of the >> system properties? Does the `setSignatureSchemes` API always override the >> prope

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 00:54:53 GMT, Bernd wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 15:26:56 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 00:58:37 GMT, Bernd wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.jav

Re: RFR: 8280494: (D)TLS signature schemes [v3]

2022-01-28 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v3]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 01:05:22 GMT, Bernd wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Enrich the APIs specification > > src/java.base/share/classes/sun/security/ssl/

Re: RFR: 8280494: (D)TLS signature schemes [v4]

2022-01-29 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v5]

2022-01-29 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v5]

2022-01-29 Thread Xue-Lei Andrew Fan
On Sun, 30 Jan 2022 03:03:37 GMT, Bernd wrote: >> If we want to reuse the result, we may have to cache something. It is not >> good to me. The parsing of the signature scheme names actually depends on >> the provider. So at this point, in the Java SE API specification, it is not >> easy to

Re: RFR: 8280494: (D)TLS signature schemes [v5]

2022-01-29 Thread Xue-Lei Andrew Fan
On Sun, 30 Jan 2022 03:06:35 GMT, Bernd wrote: >> Yes. Array copy is a concern of mine, too. Hopefully, the frozen array >> feature could help address the array copy issues in the future. > > Hmm.. I guess the different packages make it really hard to have an internal > optimized getter. What

Re: RFR: 8280494: (D)TLS signature schemes [v6]

2022-01-31 Thread Xue-Lei Andrew Fan
On Sun, 30 Jan 2022 03:08:22 GMT, Bernd wrote: >> Yes, it does. Do you like to use a for-loop, without new object allocation? > > Yes, static helper Thanks for confirm. Updated to use a static helper method. - PR: https://git.openjdk.java.net/jdk/pull/7252

Re: RFR: 8280494: (D)TLS signature schemes [v6]

2022-01-31 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification

2022-01-31 Thread Xue-Lei Andrew Fan
In the JSSE specification, the reference to "Java Security Standard Algorithm Names" specification is documented as "Java Cryptography Architecture Standard Algorithm Name Documentation". As should be corrected. - Commit messages: - 8280949: Correct the references for the Java Sec

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
> In the JSSE specification, the reference to "Java Security Standard Algorithm > Names" specification is documented as "Java Cryptography Architecture > Standard Algorithm Name Documentation". As should be corrected. Xue-Lei Andrew Fan has updated the pull r

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v3]

2022-01-31 Thread Xue-Lei Andrew Fan
> In the JSSE specification, the reference to "Java Security Standard Algorithm > Names" specification is documented as "Java Cryptography Architecture > Standard Algorithm Name Documentation". As should be corrected. Xue-Lei Andrew Fan has updated the pull r

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 16:39:34 GMT, Sean Mullan wrote: > Please capitalize "specification" (i.e. "Specification") to be consistent > with other references in the javadoc. Looks good otherwise. OK. Just curious, why we want to use capitalized "specification"? This word "specification" is not a

Re: RFR: 8280949: Correct the references for the Java Security Standard Algorithm Names specification [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 20:05:45 GMT, Sean Mullan wrote: > > > Please capitalize "specification" (i.e. "Specification") to be consistent > > > with other references in the javadoc. Looks good otherwise. > > > > > > OK. Just curious, why we want to use capitalized "specification"? This word > > "s

Re: RFR: 8280494: (D)TLS signature schemes [v7]

2022-01-31 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Integrated: 8280949: Correct the references for the Java Security Standard Algorithm Names specification

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 15:37:38 GMT, Xue-Lei Andrew Fan wrote: > In the JSSE specification, the reference to "Java Security Standard Algorithm > Names" specification is documented as "Java Cryptography Architecture > Standard Algorithm Name Documentation". As sh

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-01-31 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 21:26:46 GMT, Sean Mullan wrote: >> As there is increasing number of SSL parameters, applications may just use >> the constructor with no argument, and use the set methods individually. > > Ok. You should specify what the default value of the signature schemes > parameter is

Re: RFR: 8280494: (D)TLS signature schemes [v7]

2022-01-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jan 2022 21:55:18 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rollback to use captialized S > > src/java.base/share/classes/javax/net/s

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 14:45:21 GMT, Sean Mullan wrote: > A few more comments on the API. All good catches! Thank you very much. Updated the spec, CSR and impl. - PR: https://git.openjdk.java.net/jdk/pull/7252

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.ope

Withdrawn: 8280494: (D)TLS signature schemes

2022-02-02 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.ne

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 22:13:07 GMT, Sean Mullan wrote: > On a related issue, have you given any thought as to what the behavior should > be if a 3rd-party JSSE provider is not updated to support these new methods? > I don't know of a good way to address that since the API is not part of the > pro

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-03 Thread Xue-Lei Andrew Fan
On Thu, 3 Feb 2022 21:30:59 GMT, Sean Mullan wrote: > > > On a related issue, have you given any thought as to what the behavior > > > should be if a 3rd-party JSSE provider is not updated to support these > > > new methods? I don't know of a good way to address that since the API is > > > not

Re: RFR: 8280494: (D)TLS signature schemes [v10]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-04 Thread Xue-Lei Andrew Fan
On Fri, 4 Feb 2022 16:34:14 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More update for the sec and impl > > src/java.base/share/classes/javax/net/s

Re: RFR: 8280494: (D)TLS signature schemes [v11]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v12]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-04 Thread Xue-Lei Andrew Fan
On Fri, 4 Feb 2022 16:35:22 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More update for the sec and impl > > src/java.base/share/classes/javax/net/s

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-04 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the

RFR: 8281289: Improve with List.copyOf

2022-02-04 Thread Xue-Lei Andrew Fan
Please review this trivial code clean up, for a little bit better performance. - Commit messages: - 8281289: Improve with List.copyOf Changes: https://git.openjdk.java.net/jdk/pull/7356/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7356&range=00 Issue: https://bugs.

Integrated: 8281289: Improve with List.copyOf

2022-02-04 Thread Xue-Lei Andrew Fan
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote: > Please review this trivial code clean up, for a little bit better performance. This pull request has now been integrated. Changeset: 42e272e1 Author: Xue-Lei Andrew Fan URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8281289: Improve with List.copyOf

2022-02-05 Thread Xue-Lei Andrew Fan
On Sat, 5 Feb 2022 13:22:25 GMT, Claes Redestad wrote: > There's a small compatibility risk with this change, e.g., > `List.copyOf(...).contains(null)` will throw NPE while > `Collections.unmodifiableList(...).contains(null)` won't. > > If we accept that compatibility risk (which should probab

RFR: 8281298: Revise the creation of unmodifiable list

2022-02-05 Thread Xue-Lei Andrew Fan
In [JDK-8281289](https://bugs.openjdk.java.net/browse/JDK-8281289), the SSLParameters class was updated with the patch: - return Collections.unmodifiableList(new ArrayList<>(sniNames.values())); + return List.copyOf(sniNames.values()); However, there's a small compatibility risk with this chang

Re: RFR: 8281298: Revise the creation of unmodifiable list

2022-02-06 Thread Xue-Lei Andrew Fan
On Sun, 6 Feb 2022 22:11:06 GMT, Claes Redestad wrote: > This looks like an appropriate solution which avoids the minor compatibility > risk introduced by the previous change - and you might even end up being more > efficient both when setting and reading the names/matchers. > > (Since we're g

Integrated: 8281298: Revise the creation of unmodifiable list

2022-02-06 Thread Xue-Lei Andrew Fan
On Sat, 5 Feb 2022 20:29:50 GMT, Xue-Lei Andrew Fan wrote: > In [JDK-8281289](https://bugs.openjdk.java.net/browse/JDK-8281289), the > SSLParameters class was updated with the patch: > > - return Collections.unmodifiableList(new > ArrayList<>(sniNames.values())); &

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 19:51:28 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct null tags > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java l

Re: RFR: 8280494: (D)TLS signature schemes [v14]

2022-02-07 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: Update class summary - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.net/jdk/pull/7252

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 19:59:32 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct null tags > > src/java.base/share/classes/javax/net/ssl/SSLParameters.jav

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 22:18:03 GMT, Sean Mullan wrote: >> I think lines 714-816/723-725 describe the behavior already. >> >> I was hesitate to use "override", as the System Property values and the >> default signature schemes are not actually overrode. The default signature >> schemes are still

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 22:56:45 GMT, Xue-Lei Andrew Fan wrote: >> Sorry, you will have to bear with me as I am still not sure how it works - I >> want to know who wins, the API or the properties, if both are set and I >> can't find where it answers that above. Maybe I nee

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Feb 2022 20:18:20 GMT, Sean Mullan wrote: >>> Are you maybe saying that this method returns the value of the system >>> properties if they are set? >> >> The return value of this method depends on the following specs: >> >> * If the {@link #setSignatureSchemes} method has not be

Re: RFR: 8280494: (D)TLS signature schemes [v15]

2022-02-09 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: Spec update - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.net/jdk/pull/7252/files/830

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-09 Thread Xue-Lei Andrew Fan
On Wed, 9 Feb 2022 14:33:11 GMT, Sean Mullan wrote: >> Basically, the suggestion captures the implementation behaviors correctly. >> To make it more accuracy, if we want to use it, we may need to consider more >> cases: >> 1. _explicitly set by application_, with null, empty or 1+ schemes. >>

Re: RFR: 8280494: (D)TLS signature schemes [v15]

2022-02-09 Thread Xue-Lei Andrew Fan
On Wed, 9 Feb 2022 21:38:22 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Spec update > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 74

Re: RFR: 8280494: (D)TLS signature schemes [v16]

2022-02-09 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: spec re-wording - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.net/jdk/pull/7252

Re: RFR: 8280494: (D)TLS signature schemes [v17]

2022-02-16 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: Add implSpec about existence of the new methods - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openj

Re: RFR: 8280494: (D)TLS signature schemes [v17]

2022-02-16 Thread Xue-Lei Andrew Fan
On Wed, 16 Feb 2022 19:21:58 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.ope

Re: RFR: 8280494: (D)TLS signature schemes [v18]

2022-02-17 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: more spec update per CSR feedback - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.ne

RFR: 8273042: TLS Certificate Compression

2022-02-23 Thread Xue-Lei Andrew Fan
Hi, Please review the implementation of RFC 8879, TLS Certificate Compression, in JDK. The TLS Certificate Compression standard is an essential part for QUIC connections and performance improvement for TLS connections. More details, please refer to the [JEP](https://bugs.openjdk.java.net/brow

Re: RFR: 8273042: TLS Certificate Compression

2022-02-28 Thread Xue-Lei Andrew Fan
On Mon, 28 Feb 2022 19:44:19 GMT, Jamil Nimeh wrote: >> src/java.base/share/classes/sun/security/ssl/CompressionAlgorithm.java line >> 49: >> >>> 47: } >>> 48: >>> 49: static CompressionAlgorithm nameOf(String name) { >> >> Shouldn't this be valueOf? We're not consistent in the metho

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread Xue-Lei Andrew Fan
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-cl

Re: RFR: JDK-8282686: Add constructors taking a cause to SocketException

2022-03-05 Thread Xue-Lei Andrew Fan
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote: > Please review this small API enhancement to add the usual constructors taking > a cause to SocketException and then update uses of initiCause on creating > SocketException to instead pass the cause via the constructor. > > Please also review

Re: RFR: 8280494: (D)TLS signature schemes [v19]

2022-03-05 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: add test for DTLS - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.net/jdk/pull/7252

Re: RFR: 8280494: (D)TLS signature schemes [v18]

2022-03-05 Thread Xue-Lei Andrew Fan
On Fri, 4 Mar 2022 16:29:04 GMT, Sean Mullan wrote: > Since this new API is also intended to be supported for DTLS, have you added > implementation support for that, and if so have you added a test for it? Yes, the DTLS implementation is included. I added a test case for DTLS. -

RFR: 8282723: Add constructors taking a cause to JSSE exceptions

2022-03-07 Thread Xue-Lei Andrew Fan
Please review this small API enhancement to add the usual constructors taking a cause to javax.net.ssl exceptions. The use of initCause in the JSSE implementation code is updated to use the new constructors accordingly. Please review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282724 --

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8282724 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: typo correction - Changes: - all: https://git.openjdk.java.net/jdk/pull/7722/files - new: https://git.openjdk.java.net/jdk/pull/7722

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:30:07 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo correction > > src/java.base/share/classes/sun/security/ssl/SSLTraffic

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constr

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:24:08 GMT, Rajan Halade wrote: > Update following for SSLPeerUnverifiedException - > > https://github.com/openjdk/jdk/blob/master/src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java#L439 Hm, I will check more usage out of the JSSE implementation c

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:36:41 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo correction > > src/java.base/share/classes/sun/security/ssl/SSLSock

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v3]

2022-03-07 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8282724 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: update more usage and add test cases - Changes: - all: https://git.openjdk.java.net/jdk/pull/7722/files - new: https://git.openjdk.java.ne

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v2]

2022-03-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Mar 2022 20:34:02 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo correction > > src/java.base/share/classes/sun/security/ssl/ECDHKeyExc

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v4]

2022-03-07 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8282724 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: update usage in test template - Changes: - all: https://git.openjdk.java.net/jdk/pull/7722/files - new: https://git.openjdk.java.net/jdk/

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v5]

2022-03-08 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8282724 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: more test case udpate - Changes: - all: https://git.openjdk.java.net/jdk/pull/7722/files - new: https://git.openjdk.java.net/jdk/pull/7722

Re: RFR: 8280494: (D)TLS signature schemes [v19]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 16:13:08 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test for DTLS > > src/java.base/share/classes/sun/security/ssl/SSLConfigur

Re: RFR: 8280494: (D)TLS signature schemes [v20]

2022-03-09 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8281290 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: correct test case issues and more - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.ne

Integrated: 8280494: (D)TLS signature schemes

2022-03-09 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.ne

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v4]

2022-03-09 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote: >> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was >> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / >> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() >> performed hal

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v5]

2022-03-18 Thread Xue-Lei Andrew Fan
On Tue, 8 Mar 2022 08:02:16 GMT, Xue-Lei Andrew Fan wrote: >> Please review this small API enhancement to add the usual constructors >> taking a cause to javax.net.ssl exceptions. The use of initCause in the >> JSSE implementation code is updated to use the new constr

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v5]

2022-03-18 Thread Xue-Lei Andrew Fan
On Fri, 18 Mar 2022 21:08:56 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> more test case udpate > > test/jdk/javax/net/ssl/SSLException/CheckSSLH

Re: RFR: 8282723: Add constructors taking a cause to JSSE exceptions [v6]

2022-03-18 Thread Xue-Lei Andrew Fan
.net/browse/JDK-8282724 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: update copyright years - Changes: - all: https://git.openjdk.java.net/jdk/pull/7722/files - new: https://git.openjdk.java.net/jdk/pull/7722

  1   2   >