On Tue, 5 Jan 2021 09:48:11 GMT, Jayashree S Kumar
wrote:
>> Issue
>>
>> https://bugs.openjdk.java.net/browse/JDK-8243376
>>
>> Problem
>>
>> The scenario is:
>> - Some specified target hostname resolves to two IP addresses (always the
>> same address pair).
>> - The DNS resolved order of
On Mon, 15 Feb 2021 19:19:29 GMT, Alan Bateman wrote:
>> This change removes sun.net.www.MimeLauncher, a package-private class that
>> is no longer used.
>>
>> The sun.net.www package is exported to java.net.http and jdk.jartool. The
>> only public access point to a MimeLauncher instance is
>
On Wed, 17 Feb 2021 13:36:18 GMT, Jaikiran Pai wrote:
>> Hi Jaikiran,
>>
>> Thanks for taking a go at this one.
>>
>> At a glance - the proposed fix seems reasonable to me. It would be good to
>> have another pair of eyes (and analysis) on this though. Some issues with
>> the test.
>
> Hello
On Thu, 18 Feb 2021 01:06:50 GMT, Jaikiran Pai wrote:
> > Changes looks OK to me, any specific reason for removing "final" specifier
> > from "getInstance" & "register" methods ?.
>
> Hello Vyom, thank you for the review. Since those two methods are `static`,
> the `final` was redundant on the
On Thu, 18 Feb 2021 05:01:41 GMT, Jaikiran Pai wrote:
>>> > Changes looks OK to me, any specific reason for removing "final"
>>> > specifier from "getInstance" & "register" methods ?.
>>>
>>> Hello Vyom, thank you for the review. Since those two methods are `static`,
>>> the `final` was redund
On Thu, 18 Feb 2021 13:05:48 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java line 189:
>>
>>> 187: }
>>> 188: }
>>> 189: return instance;
>>
>> I'd suggest changing these two lines as well:
>>
>> // the
On Fri, 19 Feb 2021 04:26:26 GMT, Jaikiran Pai wrote:
> After thinking a bit more about this issue and the patch I had proposed, I
> realized what I did wrong in this patch. The `synchronized` block in the
> `sun.net.ext.ExtendedSocketOptions#getInstance()` was scoped one statement
> too many.
