Am 16.01.2014 17:26, schrieb roger riggs:
Please review:
webrev:
http://cr.openjdk.java.net/~rriggs/webrev-jnu-check-rename-8031737/
I more would like a "while (true)" loop, rather than a "do" loop.
-Ulf
Maybe little faster, especially for short strings:
private CoderResult decodeArrayLoop(ByteBuffer src, CharBuffer
dst) {
byte[] sa = src.array();
int sp = src.arrayOffset() + src.position();
int sr = src.remaining(); // faster than ...
src.arrayOffset() + s
Maybe:
for (int sl = sp + (sr <= dr ? sr : dr); sp != sl; sp++, dp++)
is little more faster than:
for (int sl = sp + (sr <= dr ? sr : dr); sp < sl; sp++, dp++)
-Ulf
Am 15.12.2008 21:56, Ulf Zibis schrieb:
Maybe little faster, especially for short strings:
Hi Sherman,
where can I get information, if this changeset is included in JDK7
snapshot source bundle + snapshot binaries?
Regards,
Ulf
Am 10.12.2008 23:10, xueming.s...@sun.com schrieb:
Changeset: b89ba9a6d9a6
Author:sherman
Date: 2008-12-10 14:03 -0800
URL: http://hg.openjd
Congratulation ;-)
... I'm wondering, that euc_tw.map is not part of the changeset. ??
-Ulf
Am 20.05.2009 00:36, xueming.s...@sun.com schrieb:
Changeset: 842fb12a21d7
Author:sherman
Date: 2009-05-19 15:25 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/842fb12a21d7
68317
My tiny comment:
It would suffice, to make the constants package private, instead of public.
-Ulf
Am 14.08.2009 23:39, xueming.s...@sun.com schrieb:
Changeset: 77a1c2056565
Author:sherman
Date: 2009-08-14 14:29 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/77a1c2056565
Hi Sherman,
I've seen, that you have again changed GenerateSBCS.java
I like to remember to review my changes on:
https://bugs.openjdk.java.net/attachment.cgi?id=130&action=diff#a/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java_sec1
IMHO my code is much smarter, and faster too (saves
Am 30.08.2009 08:54, tim.b...@sun.com schrieb:
Changeset: 4c6a5ea563ba
Author:peytoia
Date: 2009-07-30 14:45 +0900
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4c6a5ea563ba
6866243: Javadoc for java.lang.Character still refers to Unicode 4 instead of 5
Reviewed-by: okutsu
! sr
Am 04.09.2009 22:59, marti...@google.com schrieb:
Changeset: 704296144175
Author:martin
Date: 2009-09-04 13:44 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/704296144175
6879368: Remove stray quote in Character javadoc
Summary: Remove stray quote in Character.valueOf javad
Hi,
in most cases you use the empty diamond operator '<>' on instantiation,
but not for SoftReference: "new SoftReference(cs)" in
AbstractCharsetProvider.java
Why?
I don't see a big advantage for casting to (Class) against (Class)
for the cache of Converters.java. Wouldn't you better use a s
Hi all,
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
(2) following code snipped is repeated many times:
+ ClassLoader cl = tclass.getClassLoader();
+ ClassLoader ccl = caller.getClassLoader();
+ if ((ccl != null) && (ccl != cl) &&
+
11 matches
Mail list logo
