Re: RFR(XS): 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6

2019-08-21 Thread Nick Gasson
brary /test/lib` to the test headers to be able to use it). best regards, -- daniel [1] http://hg.openjdk.java.net/jdk/jdk/file/tip/test/lib/jdk/test/lib/NetworkConfiguration.java#l383 On 21/08/2019 07:55, Nick Gasson wrote: Hi, Bug: https://bugs.openjdk.java.net/browse/JDK-8229912 Webrev:

Re: RFR(XS): 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6

2019-08-21 Thread Nick Gasson
On 21/08/2019 18:30, Alan Bateman wrote: Daniel - if there are other changes to this test then it might be worth re-examining the ensureXXX methods. The naming is very strange as they return a boolean. Also they print messages to say that the test is skipped but it's the caller that will determi

RFR(S): 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout

2020-08-13 Thread Nick Gasson
Hi, Bug: http://cr.openjdk.java.net/~ngasson/8251517/webrev.0/ Webrev: https://bugs.openjdk.java.net/browse/JDK-8251517 This case fails in our testing when run with -Xcomp on a fastdebug build. The 5s socket read timeout is too short for this configuration. Fix by scaling by the jtreg timeout fac

Re: RFR(S): 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout

2020-08-14 Thread Nick Gasson
Hi Daniel, On 08/14/20 17:27 pm, Daniel Fuchs wrote: > > Looks good to me. But while you're at it, could you make > the `ok` and `requests` fields volatile? > Sure, this one ok to push? https://cr.openjdk.java.net/~ngasson/8251517/webrev.1/ -- Thanks, Nick