RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-06 Thread Hamlin Li
Would you please review the following simple doc patch? bug: https://bugs.openjdk.java.net/browse/JDK-8158881 webrev: http://cr.openjdk.java.net/~mli/8158881/webrev.00/ Thank you -Hamlin --- a/src/java.base/share/classes/java/net/URI.javaTue Jun 07 10:33:38 2016 +0800 +++ b/src/java.base/

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-07 Thread Hamlin Li
On 2016/6/7 17:34, Chris Hegarty wrote: On 7 Jun 2016, at 05:50, Hamlin Li wrote: Would you please review the following simple doc patch? bug: https://bugs.openjdk.java.net/browse/JDK-8158881 webrev: http://cr.openjdk.java.net/~mli/8158881/webrev.00/ I’m not sure why the URL’s were ever

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-07 Thread Hamlin Li
Thank you -Hamlin Thanks, Brad [1] RFC 2606: https://tools.ietf.org/html/rfc2606 On 6/7/2016 2:34 AM, Chris Hegarty wrote: On 7 Jun 2016, at 05:50, Hamlin Li wrote: Would you please review the following simple doc patch? bug: https://bugs.openjdk.java.net/browse/JDK-8158881 we

Re: RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

2018-03-15 Thread Hamlin Li
On 15/03/2018 7:20 PM, Alan Bateman wrote: On 15/03/2018 08:43, Hamlin Li wrote: : Hi Alan, Thank you for reviewing, I have updated the webrev in place. ( cc'ing serviceability-dev and net-dev as these are the other areas that use the getFreePort method in the test library. For co

Re: RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

2018-03-16 Thread Hamlin Li
On 16/03/2018 4:05 PM, Alan Bateman wrote: On 16/03/2018 01:54, Hamlin Li wrote: : Hi Alan, Thank you for detailed reviewing. I have updated the webrev in place. (http://cr.openjdk.java.net/~mli/8199215/webrev.00/) Looks good, just a minor typo "is better choice" -> "

RFR of JDK-8210802,temp files left by tests in jdk/java/net/httpclient

2018-09-16 Thread Hamlin Li
Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8210802 webrev: http://cr.openjdk.java.net/~mli/8210802/webrev.00/ Thank you -Hamlin

Re: RFR of JDK-8210802,temp files left by tests in jdk/java/net/httpclient

2018-09-17 Thread Hamlin Li
xit() as well... Best regards Christoph -Original Message----- From: net-dev On Behalf Of Hamlin Li Sent: Montag, 17. September 2018 07:55 To: OpenJDK Network Dev list Subject: RFR of JDK-8210802,temp files left by tests in jdk/java/net/httpclient Would you please review the following patch? b

Re: RFR of JDK-8210802,temp files left by tests in jdk/java/net/httpclient

2018-09-17 Thread Hamlin Li
ly blocks? But I guess one can do it with deleteOnExit() as well... Best regards Christoph -Original Message- From: net-dev On Behalf Of Hamlin Li Sent: Montag, 17. September 2018 07:55 To: OpenJDK Network Dev list Subject: RFR of JDK-8210802,temp files left by tests in jd