Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-06 Thread Frank Ding
Hi all, In source code "jdk\src\solaris\native\java\net\PlainDatagramSocketImpl.c", there are several macros in the form of #ifdef AF_INET6 #if defined(__solaris__) || defined(MACOSX) // code for solaris and macosx (unix) [1] #endif #ifdef __linux__ // code for linux #endif #else

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-13 Thread Frank Ding
On 8/7/2012 1:46 PM, Frank Ding wrote: Hi all, In source code "jdk\src\solaris\native\java\net\PlainDatagramSocketImpl.c", there are several macros in the form of #ifdef AF_INET6 #if defined(__solaris__) || defined(MACOSX) // code for solaris and macosx (unix) [1] #en

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-16 Thread Frank Ding
On 8/14/2012 10:42 PM, Chris Hegarty wrote: On 14/08/12 13:11, Alan Bateman wrote: On 14/08/2012 04:11, Frank Ding wrote: On 8/7/2012 1:46 PM, Frank Ding wrote: : Could anybody take a look at my patch below and make comment? http://cr.openjdk.java.net/~youdwei/ojdk-533/webrev.00/ Thanks

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Frank Ding
Hi Chris and Jonathan, Thank you all. The change set is OK. Best regards, Frank On 8/17/2012 5:20 PM, Jonathan Lu wrote: On 08/17/2012 04:14 PM, Chris Hegarty wrote: On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built

Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-11-07 Thread Frank Ding
Hi guys, Could you please take a look at patch below aimed to resolve existing bug http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6512101 ? http://cr.openjdk.java.net/~dingxmin/6512101/webrev.01/ I happen to have a Chinese Win 7 environment. "buggy.png" is current output of test cas

Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-11-28 Thread Frank Ding
or if MultiByteToWideChar return error, rather than abort. I agree with Dmitry, fall back would be preferable. Can you make the changes and post an updated webrev. -Chris. -Dmitry On 2012-11-07 13:08, Frank Ding wrote: Hi guys, Could you please take a look at patch below aimed to re

Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-12-09 Thread Frank Ding
Hi Dmitry and Chris, Could you please review the second revision again? Thanks and Best regards, Frank On 11/29/2012 1:08 PM, Frank Ding wrote: Hi Dmitry and Chris, Thanks for your comments. With your comments incorporated, I've prepared v2 @ http://cr.openjdk.java.net/~dingxmin/65

Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-12-10 Thread Frank Ding
ood for me. May be "Can't get WIDE string" should be changed to something more verbose. -Dmitry On 2012-12-10 11:40, Frank Ding wrote: Hi Dmitry and Chris, Could you please review the second revision again? Thanks and Best regards, Frank On 11/29/2012 1:08 PM, Frank Ding wr

Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-12-10 Thread Frank Ding
? Otherwise, just let me know and I can do it. -Chris. -Dmitry On 2012-12-10 12:00, Frank Ding wrote: Hi Dmitry, I updated wording accordingly @ http://cr.openjdk.java.net/~dingxmin/6512101/webrev.03. It is now changed to "Cannot get multibyte char for interface display name". What

Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-12-10 Thread Frank Ding
Thanks Jonathan. On 12/11/2012 10:44 AM, Jonathan Lu wrote: Hi Frank, Patch pushed @ http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd Best regards! - Jonathan On 12/11/2012 09:49 AM, Frank Ding wrote: Hi All, Thank you all. I will have Jonathan help to commit. Best regards

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-06 Thread Frank Ding
Hi Michael, After reading carefully discussion thread, let me elaborate my investigation and conclusion. The 2nd version of Shirish's patch tries to address your concern that "Would it be possible to fix this within the context of whatever loader is currently being invoked?". The new solut

[7u] Request for review and approval/backport: 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2013-01-08 Thread Frank Ding
Hi all, I'd like to request for approval to push the following change into 7u11. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6512101 Changeset in jdk8 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/883feced1cdd Reviewed by chegar, dsamersoff Webrev for 7u http://cr.openjdk.java.net

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-17 Thread Frank Ding
Hi Michael, Could you please take a look at my comment below? Best regards, Frank On 1/6/2013 4:23 PM, Frank Ding wrote: Hi Michael, After reading carefully discussion thread, let me elaborate my investigation and conclusion. The 2nd version of Shirish's patch tries to address

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-21 Thread Frank Ding
Frank Ding wrote: Hi Michael, Could you please take a look at my comment below? Best regards, Frank On 1/6/2013 4:23 PM, Frank Ding wrote: Hi Michael, After reading carefully discussion thread, let me elaborate my investigation and conclusion. The 2nd version of Shirish's patch tries to ad

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-22 Thread Frank Ding
:20 AM, Frank Ding wrote: Hi Chris, Thanks for your review. I did jtreg test on net module (java/net and sun/net) and no regression issue was found. Could anybody else review the patch as well? Best regards, Frank On 1/18/2013 10:55 PM, Chris Hegarty wrote: I haven't been able to spe

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2013-01-23 Thread Frank Ding
Hi Kurchi, Thanks. Is it eligible for committing? Best regards, Frank On 1/23/2013 4:45 PM, Kurchi Subhra Hazra wrote: Looks good to me. Thanks, Kurchi On 1/22/13 6:50 PM, Frank Ding wrote: Hi Chris and Kurchi, Thank you both for your comments. I have reformatted the patch