On 09/26/2018 11:24 AM, Baesken, Matthias wrote:
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211146.0/
Oh, nice catch. This looks good to me.
-Aleksey
signature.asc
Description: OpenPGP digital signature
On 8/6/19 10:58 AM, Langer, Christoph wrote:
> Hi,
>
> please review the jdk11u backport of another fix for test
> java/net/httpclient/UnknownBodyLengthTest.java. The patch did apply mostly
> clean but needed some help in the import directives. Now the change looks
> effectively the same as the
On Tue, 15 Sep 2020 08:53:35 GMT, Julia Boes wrote:
> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
> and added a benchmark to confirm that
> there is no performance impact.
Drive-by benchmark comments below.
test/micro/org/openjdk/bench/java/net/ThreadLocalPars
On Tue, 15 Sep 2020 15:43:59 GMT, Julia Boes wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching
>> CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit
On Wed, 16 Sep 2020 09:27:01 GMT, Julia Boes wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching
>> CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit
On Wed, 30 Sep 2020 10:22:11 GMT, Conor Cleary wrote:
> This patch replaces a LinkedList data structure used in the
> net.http.Http2Connection class with an ArrayList. This
> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
> java.net](https://bugs.openjdk.java.net/browse/JDK
On Tue, 6 Oct 2020 17:02:37 GMT, Aleksey Shipilev wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8253179: Removed ArrayList copy of streams
>
> Marked as reviewed by shade (Reviewer
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote:
>> This patch replaces a LinkedList data structure used in the
>> net.http.Http2Connection class with an ArrayList. This
>> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in
>> java.net](https://bugs.openjdk.java.net/browse/
On Wed, 21 Oct 2020 06:52:42 GMT, Сергей Цыпанов
wrote:
> Hello, while working with `java.net.URL` I've found unused package-private
> method `URL.set(String protocol, String host, int port, String file, String
> ref)` which can be safely removed from JDK. Testing: tier1, tier2
>
> Could some
On Tue, 27 Oct 2020 19:46:27 GMT, Сергей Цыпанов
wrote:
>> Submitted [here](https://bugs.openjdk.java.net/browse/JDK-8255477), please
>> try to update the PR title to "8255477: Remove unused method URL.set(String
>> protocol, String host, int port, String file, String ref)". Also, merge from
On Sat, 28 Nov 2020 19:42:01 GMT, Turbanov Andrey
wrote:
> Incorrect format string was found by IntelliJ IDEA inspection `Java |
> Probable bugs | Malformed format string`
Submitted: https://bugs.openjdk.java.net/browse/JDK-8257707 -- rename this PR
to "8257707: Fix incorrect format string in
On Thu, 3 Dec 2020 20:05:36 GMT, Andrey Turbanov
wrote:
> === Output from failing command(s) repeated here ===
> * For target
> hotspot_variant-server_libjvm_objs_bytecodeInterpreterWithChecks.obj:
> bytecodeInterpreterWithChecks.cpp
> ./build/windows-x86_64-server-release/hotspot/variant-serve
On Fri, 4 Dec 2020 06:33:35 GMT, Aleksey Shipilev wrote:
>> make test-tier2 fails with error on my machine: :(
>> user@WORK-PC /cygdrive/f/Projects/official_openjdk
>> $ make test-tier2
>> Building target 'test-tier2' in configuration 'windows-x86_64-ser
On Sat, 28 Nov 2020 19:42:01 GMT, Andrey Turbanov
wrote:
> Incorrect format string was found by IntelliJ IDEA inspection `Java |
> Probable bugs | Malformed format string`
Looks good to me.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1495
On Fri, 4 Dec 2020 08:36:36 GMT, Aleksey Shipilev wrote:
>> Incorrect format string was found by IntelliJ IDEA inspection `Java |
>> Probable bugs | Malformed format string`
>
> Looks good to me.
@dfuch, are you still good with this? Please submit your formal review here :)
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt
wrote:
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes the issues in the `java.base
On Wed, 17 Mar 2021 12:31:22 GMT, Claes Redestad wrote:
>> Sonar displays a warning message that modifiers should be declared in the
>> order listed in the JLS; specifically, that isntead of using `final static`
>> the `static final` should be preferred.
>>
>> This fixes the issues in the `jav
On Fri, 16 Jul 2021 09:16:23 GMT, Jonathan Dowland wrote:
> The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` uses
> the IP address "1.1.1.1" as a value. I think at the time the address was
> picked, the assumption was the address was not valid / not routable. Since
> Ap
On Fri, 6 Aug 2021 19:50:48 GMT, Jonathan Dowland wrote:
>> The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java`
>> uses the IP address "1.1.1.1" as a value. I think at the time the address
>> was picked, the assumption was the address was not valid / not routable.
>> Since
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote:
> Recently added test fails on my desktop in the course of newly added `tier4`
> runs. The reason is simple: the test verifies that lsof outputs no more than
> LIMIT_LINES (2) lines. And on my machine, lsof prints some warn
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote:
> Recently added test fails on my desktop in the course of newly added `tier4`
> runs. The reason is simple: the test verifies that lsof outputs no more than
> LIMIT_LINES (2) lines. And on my machine, lsof prints some warn
On Tue, 28 Sep 2021 15:54:09 GMT, Aleksey Shipilev wrote:
> Recently added test fails on my desktop in the course of newly added `tier4`
> runs. The reason is simple: the test verifies that lsof outputs no more than
> LIMIT_LINES (2) lines. And on my machine, lsof prints some warn
On Sun, 5 Dec 2021 16:44:05 GMT, Alan Bateman wrote:
> There are several thread safety issues in java.net.ServerSocket, issues that
> go back to at least JDK 1.4.
>
> The issue of most concern is async close of a ServerSocket that is initially
> created unbound and where close may be called at
On Mon, 6 Dec 2021 11:40:46 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/net/ServerSocket.java line 90:
>>
>>> 88: private volatile boolean created; // impl.create(boolean) called
>>> 89: private volatile boolean bound;
>>> 90: private volatile boolean closed;
>>
>
24 matches
Mail list logo
