- use `String.equalsIgnoreCase()` instead of hand-written code relying on
`String.charAt()`
- use `String.compareToIgnoreCase()` instead of hand-written code relying on
`String.charAt()`
- drop branches that are never executed
- drop unused argument from `URI.resolvePath()`
- simplify String-rela
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote:
> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - drop branches that are never executed
>
On Tue, 26 Apr 2022 11:35:10 GMT, Daniel Fuchs wrote:
>> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
>> `String.charAt()`
>> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
>> `String.charAt()`
>> - drop branches that are never executed
On Tue, 26 Apr 2022 11:35:10 GMT, Daniel Fuchs wrote:
>> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
>> `String.charAt()`
>> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
>> `String.charAt()`
>> - drop branches that are never executed
On Tue, 26 Apr 2022 07:02:55 GMT, Сергей Цыпанов wrote:
> - use `String.equalsIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - use `String.compareToIgnoreCase()` instead of hand-written code relying on
> `String.charAt()`
> - drop branches that are never executed
>
On Tue, 26 Apr 2022 12:41:38 GMT, Сергей Цыпанов wrote:
> Btw, I see that `java.net.URI` duplicates some methods from
> `sun.net.www.ParseUtil`. Should we consolidate them e.g. in a way of reusing
> functionality of `sun.net.www.ParseUtil` in `java.net.URI`?
I don't think the ratio benefit/ris
On Tue, 26 Apr 2022 12:39:50 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/net/URI.java line 1921:
>>
>>> 1919: return sn - tn;
>>> 1920: int val = 0;
>>> 1921: int n = Math.min(sn, tn);
>>
>> Can we drop this change? I wouldn
On Thu, 14 Apr 2022 16:04:22 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following PR review please? It adds a new JDK specific
> extended socket option
> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
> and IPv6
> UDP sockets (NIO DatagramChannels). For
Hi,
Could I get the following small test update reviewed please?
It includes a test scenario that should have been included with JDK-8284890
Thanks,
Michael
-
Commit messages:
- test update
Changes: https://git.openjdk.java.net/jdk/pull/8405/files
Webrev: https://webrevs.openjdk.
On Tue, 26 Apr 2022 04:37:58 GMT, Jaikiran Pai wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/KeyStoreBuilderParameters.java line
> 71:
>
>> 69:
On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
> https://bugs.openjdk.java.net/browse/JDK-8285504
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/java.base/share/classes/java/net
Mark Powers has u
On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Tue, 26 Apr 2022 18:39:33 GMT, Bradford Wetmore wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/KeyStoreBuilderParameters.java line
> 72:
>
>>
On Tue, 26 Apr 2022 19:05:05 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java line 69:
>
>> 67: Str
On Tue, 26 Apr 2022 19:49:11 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java line 69:
>>
>>> 67: String type;
>>> 68: type = AccessController.doPrivileged((PrivilegedAction)
>>> () ->
>>> 69: Security.getProperty("ssl.
On Tue, 26 Apr 2022 16:41:08 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small test update reviewed please?
> It includes a test scenario that should have been included with JDK-8284890
>
> Thanks,
> Michael
I'm closing this PR as the related bugfix has caused some regressi
On Tue, 26 Apr 2022 16:41:08 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small test update reviewed please?
> It includes a test scenario that should have been included with JDK-8284890
>
> Thanks,
> Michael
This pull request has been closed without being integrated.
-
On Tue, 26 Apr 2022 20:40:50 GMT, Bradford Wetmore wrote:
>> Wasn't there another bug to address this?
>
> Perhaps as part of
> [JDK-6725221](https://bugs.openjdk.java.net/browse/JDK-6725221)?
No problem.
-
PR: https://git.openjdk.java.net/jdk/pull/8384
20 matches
Mail list logo
