Re: RFR: JDK-8284353 : Update java/net and sun/net/www tests to eliminate dependency on sun.net.www.MessageHeader

2022-04-06 Thread Daniel Fuchs
On Tue, 5 Apr 2022 10:27:54 GMT, Mahendra Chhipa wrote: > Updated java/net and sun/net/www tests to remove dependency on > sun.net.www.MessageHeader. Looks reasonable to me, but please make sure the tests are stable before pushing. The proxy/tunnel classes have exhibited some instability in th

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v14]

2022-04-06 Thread Jaikiran Pai
On Mon, 4 Apr 2022 09:52:56 GMT, Jaikiran Pai wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.java >> line 140: >> >>> 138: return this; >>> 139: } >>> 140: >> >> Either this should check that localAddr is an `InetSocketAddress` and that >> p

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v15]

2022-04-06 Thread Daniel Fuchs
On Mon, 4 Apr 2022 09:53:02 GMT, Jaikiran Pai wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a specifi

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v15]

2022-04-06 Thread Daniel Fuchs
On Mon, 6 Dec 2021 14:39:27 GMT, Jaikiran Pai wrote: >> Also it's better if the test is IP version agnostic. > > Hello Daniel, I will update the test accordingly in the next round of updates. I'd suggest HttpClientLocalAddrTest implements HttpServerAdapters like other tests do. -