Re: RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects. [v2]

2022-03-25 Thread Jaikiran Pai
On Tue, 15 Feb 2022 15:33:01 GMT, Conor Cleary wrote: >> As described in the title, this is a simple change to the >> `HttpRequest.Builder::build` method to highlight that an immutable and >> reusable instance of an `HttpRequest` is created when this method is >> invoked. This is done by addin

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v7]

2022-03-25 Thread Michael McMahon
> Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new system property > "http.auth.digest.reEnabledAlgs" to include the value M

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-25 Thread Michael McMahon
> Hi, > > Could I get the following change reviewed please, which is to disable the MD5 > message digest algorithm by default in the HTTP Digest authentication > mechanism? The algorithm can be opted into by setting a new system property > "http.auth.digest.reEnabledAlgs" to include the value M

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-25 Thread Michael McMahon
On Fri, 25 Mar 2022 15:07:40 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system pro

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v6]

2022-03-25 Thread Conor Cleary
On Thu, 24 Mar 2022 18:21:45 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8263031: further verification of push promise and response >> - 8263031: Removed duplicate import > > src/java.net.h

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v6]

2022-03-25 Thread Conor Cleary
On Fri, 25 Mar 2022 15:51:44 GMT, Conor Cleary wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java >> line 807: >> >>> 805: } catch (UncheckedIOException e) { >>> 806: debug.log("Error handling Push Promise with >>> C

Re: RFR: 8281561: Disable http DIGEST mechanism with MD5 and SHA-1 by default [v8]

2022-03-25 Thread Daniel Fuchs
On Fri, 25 Mar 2022 15:07:40 GMT, Michael McMahon wrote: >> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system pro