Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v14]

2022-03-24 Thread Daniel Fuchs
On Thu, 24 Mar 2022 06:46:01 GMT, Jaikiran Pai wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a specif

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v6]

2022-03-24 Thread Conor Cleary
> **Problem** > When a Continuation Frame is received by the httpclient using HTTP/2 after a > Push Promise frame (can happen if the amount of headers to be sent in a > single Push Promise frame exceeds the maximum frame size, so a Continuation > frame is required), the following exception occur

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v5]

2022-03-24 Thread Conor Cleary
On Tue, 22 Mar 2022 10:57:35 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - 8263031: Added return statements and pcs var >> - 8263031: Test cleanup, added third case >> - Revert "Test cleanu

Re: RFR: 8281223: Improve the API documentation of HttpRequest.Builder::build to state that the default implementation provided by the JDK returns immutable objects. [v2]

2022-03-24 Thread Conor Cleary
On Tue, 15 Feb 2022 15:33:01 GMT, Conor Cleary wrote: >> As described in the title, this is a simple change to the >> `HttpRequest.Builder::build` method to highlight that an immutable and >> reusable instance of an `HttpRequest` is created when this method is >> invoked. This is done by addin

Integrated: 8282917: Remove InetAddressImplFactory from InetAddress

2022-03-24 Thread Aleksei Efimov
On Wed, 16 Mar 2022 13:26:36 GMT, Aleksei Efimov wrote: > Hi, > > This cleanup change removes `InetAddressImplFactory` class from > `InetAddress`. The list of changes: > - Remove `InetAddressImplFactory` from `InetAddress` > - Since `isIPv6Supported` native code is identical for Windows and Uni

Re: RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v6]

2022-03-24 Thread Daniel Fuchs
On Thu, 24 Mar 2022 12:41:26 GMT, Conor Cleary wrote: >> **Problem** >> When a Continuation Frame is received by the httpclient using HTTP/2 after a >> Push Promise frame (can happen if the amount of headers to be sent in a >> single Push Promise frame exceeds the maximum frame size, so a Conti