On Fri, 11 Mar 2022 05:28:36 GMT, Jaikiran Pai wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Copyright years
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
> line 162:
>
>> 160:
On Fri, 11 Mar 2022 10:12:46 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
>> line 170:
>>
>>> 168: Http2Connection c1 = connections.putIfAbsent(key, c);
>>> 169: if (c1 != null) {
>>> 170: c.setFin
On Fri, 11 Mar 2022 10:07:21 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
>> line 162:
>>
>>> 160:
>>> 161: String key = c.key();
>>> 162: synchronized(this) {
>>
>> Hello Daniel, it's not fully clear to me why this syn
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
The changes to the usages in src/java.base look okay.
-
Marked as reviewed by alanb (Reviewer).
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
Marked as reviewed by dfuchs (Reviewer).
The `libnet` changes look good to me - but please get someone from t
On Thu, 10 Mar 2022 11:17:26 GMT, Daniel Fuchs wrote:
>> These changes make sure that pending requests are terminated if the selector
>> manager thread exits due to exceptions.
>> This includes:
>>1. completing CompletableFutures that were returned to the caller code
>>2. cancelling requ
On Fri, 11 Mar 2022 10:33:09 GMT, Jaikiran Pai wrote:
>> I'm not completely sure of the purpose of the synchronized block here - but
>> I'd rather not change this in this PR (and I'd rather not change it at all
>> unless it proves to cause issues). As for the second check for isOpen() - I
>> i
On Thu, 24 Feb 2022 16:01:57 GMT, Mahendra Chhipa wrote:
> Updated following remaining tests to remove depenedies of TestHttpServer,
> HttpTransaction, HttpCallback
> open/test/jdk/java/net/ProxySelector/LoopbackAddresses.java
> open/test/jdk/java/net/ProxySelector/ProxyTest.java
> open/test/jdk
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch that solves an intermittent issue detected by
>> the CancelRequestTest.java
>>
>> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
>> after the Http2Connection has been created, and
On Fri, 11 Mar 2022 10:33:29 GMT, Alan Bateman wrote:
>> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
>> calls, should be a `jboolean*` instead of a `jboolean`.
>
> The changes to the usages in src/java.base look okay.
Thanks, @AlanBateman @dfuch
-
PR:
On Thu, 10 Mar 2022 21:12:46 GMT, Zhengyu Gu wrote:
> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
> calls, should be a `jboolean*` instead of a `jboolean`.
This pull request has now been integrated.
Changeset: 0fd09d38
Author:Zhengyu Gu
URL:
https://git
On Fri, 11 Mar 2022 10:33:29 GMT, Alan Bateman wrote:
>> Another trivial cleanup to fix the last parameter of `GetStringXXXChars`
>> calls, should be a `jboolean*` instead of a `jboolean`.
>
> The changes to the usages in src/java.base look okay.
> Thanks, @AlanBateman @dfuch
but make sure to
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
The security related changes look fine,
The following fix seals the `java.net.InetAddress` class and permits only two
implementations - `java.net.Inet4Address` and `java.net.Inet6Address`.
No issues have been detected by regression and JCK tests.
Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536)
[CSR](https://bugs.openj
On Thu, 10 Mar 2022 15:02:17 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update
>> - update after first review round
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthen
On Mon, 7 Mar 2022 14:41:47 GMT, Weijun Wang wrote:
>> 2nd test of https://datatracker.ietf.org/doc/html/rfc7616#section-3.9 is on
>> this algorithm, but it requires UTF-8 charset support and a way to provide a
>> predefined cnonce. If it's not worth modifying our implementation to create
>> a
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
> "http.auth.digest.reEnabledAlgs" to include the value M
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote:
> The following fix seals the `java.net.InetAddress` class and permits only two
> implementations - `java.net.Inet4Address` and `java.net.Inet6Address`.
>
> No issues have been detected by regression and JCK tests.
>
> Links: [JBS](https
On Fri, 11 Mar 2022 17:37:44 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system pro
On Fri, 11 Mar 2022 13:23:23 GMT, Zhengyu Gu wrote:
>> The changes to the usages in src/java.base look okay.
>
> Thanks, @AlanBateman @dfuch
@zhengyu123 - why did you ignore the request to wait for a client reviewer ?
Over half the files touched are in client ? Might I ask what tests you ran ?
A
On Fri, 11 Mar 2022 17:37:44 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system pro
On Thu, 10 Mar 2022 16:50:05 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 234:
>>
>>> 232: in the {@code java.security} properties file and currently
>>> comprises {@code MD5} and
>>> 233: {@code SHA-1}. If it is still re
On Tue, 8 Mar 2022 15:23:13 GMT, zzambers wrote:
>>> Sure if more changes are desired I can pull your changes. When It comes to
>>> CSR I am not fully familiar with the
>> process. Is action expected from my side?
>>
>> One of us needs to get the CSR approved. Why don't you pull the changes
23 matches
Mail list logo
