On Wed, 9 Mar 2022 11:55:27 GMT, Daniel Fuchs wrote:
> Here we don't need to check whether it's been acquired because we know it's
> been acquired if we reach here.
Hello Daniel, may be I am misreading the diff but from what I can see, the
`acquire()` method now returns a `boolean` which we ar
On Wed, 9 Mar 2022 12:09:48 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
>> line 179:
>>
>>> 177: } catch (Throwable t) {
>>> 178: errorHandler.accept(command, t);
>>> 179: ASYNC_POOL.execute(co
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For simple webserver resource files - should the copyright year be 2022?
-
PR: https://git.openjdk.java.net/jdk/pull/7765
On Thu, 10 Mar 2022 10:08:16 GMT, Jaikiran Pai wrote:
>> tryRelease can be called multiple time - it will only decrement the ref
>> counting once. It could happen when different threads notice that the
>> operation is finished (usually due to some exceptions being propagated) and
>> try concur
On Wed, 9 Mar 2022 15:53:02 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
>> line 85:
>>
>>> 83: public String run() {
>>> 84: return Security.getProperty(secPropName)
>>> 85:
On Wed, 9 Mar 2022 14:23:24 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update
>> - update after first review round
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthent
On Wed, 9 Mar 2022 15:18:43 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update
>> - update after first review round
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthen
On Wed, 9 Mar 2022 16:54:58 GMT, Daniel Fuchs wrote:
>> These changes make sure that pending requests are terminated if the selector
>> manager thread exits due to exceptions.
>> This includes:
>>1. completing CompletableFutures that were returned to the caller code
>>2. cancelling reque
On Wed, 9 Mar 2022 15:41:08 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update
>> - update after first review round
>
> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthent
On Thu, 10 Mar 2022 10:41:23 GMT, Daniel Fuchs wrote:
> The acquire() method will return true the first time it's been called. And it
> is called only once. So we only need to check whether acquired is true at
> places where we are in doubt about whether the method has been called.
I see what
> These changes make sure that pending requests are terminated if the selector
> manager thread exits due to exceptions.
> This includes:
>1. completing CompletableFutures that were returned to the caller code
>2. cancelling requests that are in flight
>3. calling onError on BodySubscr
On Thu, 10 Mar 2022 10:44:45 GMT, Jaikiran Pai wrote:
>> The acquire() method will return true the first time it's been called. And
>> it is called only once. So we only need to check whether `acquired` is true
>> at places where we are in doubt about whether the method has been called.
>> The
On Thu, 10 Mar 2022 10:54:52 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
>> line 82:
>>
>>> 80: @SuppressWarnings("removal")
>>> 81: String secprops = AccessController.doPrivileged(
>>> 82: new Privil
On Fri, 4 Mar 2022 12:28:41 GMT, Mahendra Chhipa wrote:
>> Updated following remaining tests to remove depenedies of TestHttpServer,
>> HttpTransaction, HttpCallback
>> open/test/jdk/java/net/ProxySelector/LoopbackAddresses.java
>> open/test/jdk/java/net/ProxySelector/ProxyTest.java
>> open/test
On Thu, 10 Mar 2022 10:48:09 GMT, Michael McMahon wrote:
>> Maybe `String.trim()` should be called on each element after splitting
>> instead: you want to remove spaces before and after commas, not necessarily
>> spaces within a name. "MD 5, SHA-256" probably shouldn't be parsed as
>> "MD5,SHA
On Wed, 9 Mar 2022 14:23:38 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system prop
On Thu, 10 Mar 2022 14:21:41 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update
>> - update after first review round
>
> src/java.base/share/conf/security/java.security line 711:
>
>> 70
Please find enclosed a patch that solves an intermittent issue detected by the
CancelRequestTest.java
If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
after the Http2Connection has been created the handshake has proceeded, and the
response headers to the upgrade have
On Thu, 10 Mar 2022 14:26:28 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update
>> - update after first review round
>
> src/java.base/share/classes/java/net/doc-files/net-properties.html
> Please find enclosed a patch that solves an intermittent issue detected by
> the CancelRequestTest.java
>
> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
> after the Http2Connection has been created, and the handshake has proceeded,
> and the response headers to
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
IIRC, localized resource files should have the same copyright year as the base
English one. That's what I was told by the l10n engineer when I had the same
comment.
-
PR: https://git.openjdk.ja
> Please find enclosed a patch that solves an intermittent issue detected by
> the CancelRequestTest.java
>
> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
> after the Http2Connection has been created, and the handshake has proceeded,
> and the response headers to
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote:
> IIRC, localized resource files should have the same copyright year as the
> base English one. That's what I was told by the l10n engineer when I had the
> same comment.
Thanks Naoto! I have no objection then.
-
PR: https://git
On Thu, 10 Mar 2022 16:43:23 GMT, Michael McMahon wrote:
>> src/java.base/share/conf/security/java.security line 711:
>>
>>> 709: # separated list of algorithms to be allowed.
>>> 710: #
>>> 711: jdk.httpdigest.defaultDisabledAlgorithms = MD5, MD-5, SHA1, SHA-1
>>
>> I haven't seen people using
> msg drop for jdk19, Mar 9, 2022
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
moved CurrencyNames changes to jdk.localedata
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7765/files
- new: https://git.op
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
src/jdk.jdi/share/classes/com/sun/tools
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
src/jdk.localedata/share/classes/sun/ut
Another trivial cleanup to fix the last parameter of `GetStringXXXChars` calls,
should be a `jboolean*` instead of a `jboolean`.
-
Commit messages:
- Fix
- 8282978: Wrong parameter passed to GetStringXXXChars in various places
Changes: https://git.openjdk.java.net/jdk/pull/7779/fi
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch that solves an intermittent issue detected by
>> the CancelRequestTest.java
>>
>> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
>> after the Http2Connection has been created, and
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch that solves an intermittent issue detected by
>> the CancelRequestTest.java
>>
>> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
>> after the Http2Connection has been created, and
30 matches
Mail list logo
