RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Masanori Yano
I added socket connection check same as IPv6_supported(). Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, java.net.InetAddress.PLATFORM_LOOKUP_POLICY.characteristics is always set to 1(IPv4), because IPv4_su

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v9]

2022-02-02 Thread Daniel Fuchs
On Wed, 2 Feb 2022 06:18:39 GMT, Jaikiran Pai wrote: >> This change proposes to implement the enhancement noted in >> https://bugs.openjdk.java.net/browse/JDK-8209137. >> >> The change introduces a new API to allow applications to build a >> `java.net.http.HTTPClient` configured with a specifi

Re: RFR: 8209137: Add ability to bind to specific local address to HTTP client [v9]

2022-02-02 Thread Daniel Fuchs
On Tue, 7 Dec 2021 14:28:01 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor - rename variable in test > > Generally it would be good if the test did not make any assumption on the > presenc

Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Daniel Jeliński
On Wed, 2 Feb 2022 08:31:08 GMT, Masanori Yano wrote: > I added socket connection check same as IPv6_supported(). > Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 > uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, > java.net.InetAddress.PLATFORM_LOOKUP_P

Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Alan Bateman
On Wed, 2 Feb 2022 08:31:08 GMT, Masanori Yano wrote: > I added socket connection check same as IPv6_supported(). > Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 > uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, > java.net.InetAddress.PLATFORM_LOOKUP_P

Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Daniel Fuchs
On Wed, 2 Feb 2022 08:31:08 GMT, Masanori Yano wrote: > I added socket connection check same as IPv6_supported(). > Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 > uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, > java.net.InetAddress.PLATFORM_LOOKUP_P

Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Aleksei Efimov
On Wed, 2 Feb 2022 08:31:08 GMT, Masanori Yano wrote: > I added socket connection check same as IPv6_supported(). > Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 > uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, > java.net.InetAddress.PLATFORM_LOOKUP_P

Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-02 Thread Mark Sheppard
On Wed, 2 Feb 2022 08:31:08 GMT, Masanori Yano wrote: > I added socket connection check same as IPv6_supported(). > Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 > uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, > java.net.InetAddress.PLATFORM_LOOKUP_P

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-02-02 Thread Sean Mullan
On Tue, 1 Feb 2022 06:47:00 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-02-02 Thread Sean Mullan
On Tue, 1 Feb 2022 06:42:30 GMT, Xue-Lei Andrew Fan wrote: >> Ok. You should specify what the default value of the signature schemes >> parameter is for this constructor as it does for the other parameters. > > Good catch. Updated. Looks good. - PR: https://git.openjdk.java.net/j

Re: RFR: 8280868: LineBodyHandlerTest.java creates and discards too many clients

2022-02-02 Thread Michael McMahon
On Fri, 28 Jan 2022 09:45:02 GMT, Daniel Fuchs wrote: > Please find enclosed a simple test fix for: > 8280868: LineBodyHandlerTest.java creates and discards too many clients > > The LineBodyHandlerTest.java creates and discards many clients (64). > The test has been observed failing intermittent

Integrated: 8280868: LineBodyHandlerTest.java creates and discards too many clients

2022-02-02 Thread Daniel Fuchs
On Fri, 28 Jan 2022 09:45:02 GMT, Daniel Fuchs wrote: > Please find enclosed a simple test fix for: > 8280868: LineBodyHandlerTest.java creates and discards too many clients > > The LineBodyHandlerTest.java creates and discards many clients (64). > The test has been observed failing intermittent

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v8]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 14:45:21 GMT, Sean Mullan wrote: > A few more comments on the API. All good catches! Thank you very much. Updated the spec, CSR and impl. - PR: https://git.openjdk.java.net/jdk/pull/7252

RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Kevin Walls
Reduce noise in test output by adding the @SuppressWarnings("removal") annotation (which has already been widely applied). - Commit messages: - 8272777: Clean up remaining AccessController warnings in test library Changes: https://git.openjdk.java.net/jdk/pull/7328/files Webrev: h

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Sean Mullan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Sean Mullan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Roger Riggs
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7328

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Withdrawn: 8280494: (D)TLS signature schemes

2022-02-02 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280

Re: RFR: 8280494: (D)TLS signature schemes [v9]

2022-02-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Feb 2022 22:13:07 GMT, Sean Mullan wrote: > On a related issue, have you given any thought as to what the behavior should > be if a 3rd-party JSSE provider is not updated to support these new methods? > I don't know of a good way to address that since the API is not part of the > pro

Re: RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Serguei Spitsyn
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7328