[jdk18] Integrated: 8280441: Missing "classpath exception" in several files from jdk.httpserver

2022-01-24 Thread Julia Boes
On Fri, 21 Jan 2022 14:38:08 GMT, Julia Boes wrote: > This change adds the classpath exception to the copyright header of the files > in question. As source files, they should have both the GPL and the classpath > exception. This pull request has now been integrated. Changeset: ead9fecc Autho

RE: Pull Request: 7013: AIX: InetAddress.getByName(addr) does not work as expected

2022-01-24 Thread Michael Felt
Thank you Thomas! From: Thomas Stüfe Sent: Saturday, 22 January 2022 11:23 To: Alan Bateman Cc: Michael Felt ; ppc-aix-port-dev ; net-dev Subject: Re: Pull Request: 7013: AIX: InetAddress.getByName(addr) does not work as expected Redirecting to net-dev On Sat, Jan 22, 2022 at 11:0

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Daniel Fuchs
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by dfuchs (Reviewer). LGTM. I hope in the future IDEs will pick that rule up and offer some help when writing `{@link }` `@see`... - PR: https://git

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Pavel Rappo
On Mon, 24 Jan 2022 11:00:37 GMT, Daniel Fuchs wrote: > LGTM. I hope in the future IDEs will pick that rule up and offer some help > when writing `{@link }` `@see`... They will do it quicker, if you create new or support existing bugs in their bug trackers. - PR: https://git.open

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Pavel Rappo
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Is that a wrong bug? If you are talking about module-prefix syntax for links, then it was introduced in JDK 15; JDK-8164408: Add module support for @see, @link and @linkplain javado

Re: RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC [v2]

2022-01-24 Thread Daniel Fuchs
On Fri, 21 Jan 2022 19:53:55 GMT, Daniel Jeliński wrote: >> Fix RFC compliance. >> Tier1 and tier2 passed. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year LGTM. @Michael-Mc-Mahon what's your take?

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v6]

2022-01-24 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The feature

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v5]

2022-01-24 Thread Michael McMahon
On Fri, 21 Jan 2022 19:48:02 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added root cause to NamingException > > src/java.base/share/classes/java/net/doc-files/net-properties.html line 220:

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v6]

2022-01-24 Thread Daniel Fuchs
On Mon, 24 Jan 2022 13:36:47 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task

2022-01-24 Thread Daniel Fuchs
This changes makes sure that pending requests are terminated if the selector manager thread exits due to exceptions. This includes: 1. completing CompletableFutures that were returned to the caller code 2. cancelling requests that are in flight 3. calling onError on BodySubscribers that m

Re: RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC [v2]

2022-01-24 Thread Michael McMahon
On Fri, 21 Jan 2022 19:53:55 GMT, Daniel Jeliński wrote: >> Fix RFC compliance. >> Tier1 and tier2 passed. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year src/java.base/share/classes/sun/net/www/pr

Re: RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC [v2]

2022-01-24 Thread Michael McMahon
On Mon, 24 Jan 2022 14:38:02 GMT, Michael McMahon wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year > > src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java > line 29

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v6]

2022-01-24 Thread Weijun Wang
On Mon, 24 Jan 2022 13:36:47 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v4]

2022-01-24 Thread Weijun Wang
On Fri, 21 Jan 2022 15:40:16 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> more tidy-up > > src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 144: > >> 142:

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v6]

2022-01-24 Thread Weijun Wang
On Mon, 24 Jan 2022 13:54:12 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> com

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v6]

2022-01-24 Thread Michael McMahon
On Mon, 24 Jan 2022 15:23:44 GMT, Weijun Wang wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> comm

Re: RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC [v2]

2022-01-24 Thread Daniel Jeliński
On Mon, 24 Jan 2022 15:21:44 GMT, Michael McMahon wrote: >> src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java >> line 293: >> >>> 291: static final String acceptString = >>> 292: "text/html, image/gif, image/jpeg, */*; q=0.2"; >>> 293: >> >> It looks syn

Re: RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC [v3]

2022-01-24 Thread Daniel Jeliński
> Fix RFC compliance. > Tier1 and tier2 passed. Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Update accept header to */* - Changes: - all: https://git.openjdk.java.net/jdk/pull/7181/files - new: https://git.ope

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Joe Darcy
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote: > > Use presumed syntax that will be introduced by JDK-8280488. > > Is that a wrong bug? If you are talking about module-prefix syntax for links, > then it was introduced in JDK 15; JDK-8164408: Add module support for @see, > @link and @link

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links

2022-01-24 Thread Alexey Ivanov
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by aivanov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v6]

2022-01-24 Thread Weijun Wang
On Mon, 24 Jan 2022 15:54:01 GMT, Michael McMahon wrote: >> src/java.base/share/classes/sun/security/util/TlsChannelBinding.java line >> 100: >> >>> (failed to retrieve contents of file, check the PR for context) >> I think this method should stay here. Suppose one day the CBT type is >> confi

RFR: Merge jdk18

2022-01-24 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18 - 8280441: Missing "classpath exception" in several files from jdk.httpserver - 8279179: Update nroff pages in JDK 18 before RC The webrevs contain the adjustments done w

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links [v2]

2022-01-24 Thread Joe Darcy
> Use presumed syntax that will be introduced by JDK-8280488. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since t

Integrated: JDK-8280492: Use cross-module syntax for cross-module links

2022-01-24 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This pull request has now been integrated. Changeset: 8e82d002 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c1174d Stat

Re: RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC [v3]

2022-01-24 Thread Michael McMahon
On Mon, 24 Jan 2022 18:07:36 GMT, Daniel Jeliński wrote: >> Fix RFC compliance. >> Tier1 and tier2 passed. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Update accept header to */* LGTM - Marked as revie

Integrated: Merge jdk18

2022-01-24 Thread Jesper Wilhelmsson
On Mon, 24 Jan 2022 19:51:08 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 52ddbe2d Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/52ddbe2dcdb2fa52d85c987443ffa14522ace729 Stats: 62 li

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v7]

2022-01-24 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The feature

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v7]

2022-01-24 Thread Weijun Wang
On Mon, 24 Jan 2022 22:11:51 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu