> Clean up of various issues related to error handling and memory management
Daniel Jelinski has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 12 addition
On Wed, 12 Jan 2022 12:34:35 GMT, Daniel Jelinski wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 216:
>>
>>> 214: break;
>>> 215: }
>>> 216: return -1;
>>
>> *netifPP = NULL;
>>
>> and a similar NULL out value for all return -1 in this f
On Mon, 17 Jan 2022 13:49:35 GMT, Daniel Fuchs wrote:
>> I vote for "jdk.https.tls.cbt"
>
>> It's actually a purely system property rather than a Net property at the
>> moment (same as the other spnego ones). Maybe, I should convert them all to
>> net properties, so they can be documented/set i
On Mon, 17 Jan 2022 13:44:06 GMT, Daniel Fuchs wrote:
>> Shall we log a message if the value is not one of the 3 forms?
>
> Usually malformed values are just ignored - and the property takes its
> default value. But yes - s.n.w.h.HttpClient has a logger so it wouldn't be
> much effort to log it
On Sat, 15 Jan 2022 14:02:15 GMT, Michael Osipov wrote:
>> I suggest moving the `TlsChannelBinding` class into
>> `java.base/sun.security.util` since it's not only used by LDAP anymore. It's
>> even not restricted to GSS-API. According to
>> https://www.rfc-editor.org/rfc/rfc5056, "Although in
On Fri, 29 Oct 2021 11:20:57 GMT, Сергей Цыпанов wrote:
> There are unused methods/constructors in mentioned classes that can be safely
> removed.
Marked as reviewed by dfuchs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6169
On Wed, 19 Jan 2022 15:36:16 GMT, Michael McMahon wrote:
>>> It's actually a purely system property rather than a Net property at the
>>> moment (same as the other spnego ones). Maybe, I should convert them all to
>>> net properties, so they can be documented/set in that file?
>>
>> AFAICS thi
On Fri, 24 Dec 2021 20:12:39 GMT, Сергей Цыпанов wrote:
>> There are unused methods/constructors in mentioned classes that can be
>> safely removed.
>
> Not now
Happy to /sponsor once you /integrate, @stsypanov.
-
PR: https://git.openjdk.java.net/jdk/pull/6169
Small test-only fix that generalizes the expected exception type from
SSLHandshakeException to SSLException (a super class of the former).
Testing: tier 1-3 and repeated runs of test in question all clear
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jd
On Fri, 14 Jan 2022 15:06:12 GMT, Daniel Fuchs wrote:
> Have you been able to test this on a specific setup? Would be good to hear
> from @msheppar too.
I have tested it with the server setup by Prajwal. Security SQE are looking
into configuring a server with a similar setup which can be teste
On Wed, 19 Jan 2022 17:01:22 GMT, Julia Boes wrote:
> Small test-only fix that generalizes the expected exception type from
> SSLHandshakeException to SSLException (a super class of the former).
>
> Testing: tier 1-3 and repeated runs of test in question all clear
LGTM - just remove 8280161 fr
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The feature
On Wed, 19 Jan 2022 22:20:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively inclu
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge
- 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl
- 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null"
when compiling
- 8272058: 25 Null pointer dereference defect groups in 4 files
On Thu, 20 Jan 2022 00:28:55 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 4616c13c
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/4616c13c2f1ced8a8bdeed81f0469523932e91b5
Stats: 1732
In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the
return statement says that "The array is ordered based on protocol preference,
with protocols[0] being the most preferred.". However, there is no "protocols"
variable in this method.
The update is a minor correction so
16 matches
Mail list logo
